Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lombok.builder.className configuration property #2161

Closed
wants to merge 1 commit into from

Conversation

tagae
Copy link

@tagae tagae commented Jun 24, 2019

Allows to configure the default builder class name that @Builder will use when the builderClassName option is not passed explicitly.

@juriad
Copy link

juriad commented Jun 26, 2019

@tagae In my PR #2136, I introduced IdentifierName (https://github.com/rzwitserloot/lombok/blob/2a98c4d1fd80ff0b3181da4fe8d5f3f32f168644/src/core/lombok/core/configuration/IdentifierName.java). You might want to update yours to use it.

@rzwitserloot
Copy link
Collaborator

Good idea but I changed the implementation considerably; yours left a bunch of now useless code, and, crucially, made it impossible to use the type name in the buildername. I noticed your update to the gradle conf file; I also pushed that through.

The changes for supporting the config property are commit c103955

@tagae
Copy link
Author

tagae commented Jul 8, 2019

Nice! Thanks a lot for taking in the idea. No problem that my code didn't get merged: I just cared about having the feature, which is the case now :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants