Fixes for CustomLog, AUTHORS entry, extended changlog #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
any idea when this might get merged? |
|
@rzwitserloot Is there anything preventing to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the style and tried to keep it mostly; I missed some places though. Thanks for fixing them.
I have no complaints to the changes.
There is one improbable breaking change: setting
lombok.log.fieldName=privateused to be valid (and it compiled!); similarlylombok.fieldNameConstants.innerTypeName=42,lombok.copyableAnnotations+=int.float.package.class, andlombok.copyableAnnotations+=a-b-c.I also found two bugs regarding
TypeName.