Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add appstream metainfo.xml file. #441

Merged
merged 6 commits into from
Nov 2, 2019
Merged

Add appstream metainfo.xml file. #441

merged 6 commits into from
Nov 2, 2019

Conversation

GeraldJansen
Copy link
Contributor

@GeraldJansen GeraldJansen commented Sep 13, 2019

Added an metainfo.xml file for Linux software gallery integration.

This is simply an update of PR #336.

Co-authored-by: Mathias Mailänder (@Mailaender).

WIP: I am not 100% sure this works. I tried to validate the xml with appstreamcli validate and got some warnings (eg. screenshots don't yet exist at their eventual destination in master). After installation (in /usr/share/appdata) and running sudo appstreamcli refresh --force, I still didn't find hamster or "time tracker" in Ubuntu software. Tried moving the file to /usr/share/metainfo where most apps now put the xml files (on Ubuntu at least) but no joy.

@GeraldJansen
Copy link
Contributor Author

@Mailaender if you could send me your no-reply.github.com email I will put that in the commit message.

@Mailaender
Copy link
Contributor

Maybe mailaender@users.noreply.github.com

GeraldJansen and others added 2 commits September 14, 2019 15:03
Co-authored-by: Mathias Mailänder <mailaender@users.noreply.github.com>
- checked with: appstream-util validate-relax data/hamster-time-tracker.metainfo.xml
- temporarily use existing online screenshots
- remove release date in the futur
Copy link
Collaborator

@ederag ederag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks !
Few comments below.

data/hamster-time-tracker.metainfo.xml Outdated Show resolved Hide resolved
data/hamster-time-tracker.metainfo.xml Outdated Show resolved Hide resolved
data/hamster-time-tracker.metainfo.xml Outdated Show resolved Hide resolved
data/hamster-time-tracker.metainfo.xml Outdated Show resolved Hide resolved
GeraldJansen and others added 4 commits November 2, 2019 14:43
@GeraldJansen
Copy link
Contributor Author

Thanks @ederag. All suggestions accepted.

@ederag
Copy link
Collaborator

ederag commented Nov 2, 2019

Thanks to both of you !
@Mailaender there is no hurry (after about three years !),
I'm just merging right away to get the screenshots online,
so that Gerald can update the locations.
Please let us know here or in the forthcoming PR
if any of the changes were not appropriate.

@ederag ederag merged commit dc2230c into projecthamster:master Nov 2, 2019
@GeraldJansen GeraldJansen deleted the appdata branch November 2, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants