-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added an appdata.xml file for Linux software gallery integration #336
Conversation
See https://build.opensuse.org/request/show/433055 for an integration test. I am not really sure what's wrong with the rpmlint checker as it crashes. The file seems to otherwise validate just fine. |
Thank you for your feedback, it is much appreciated. Project hamster and its various sub-components is currently undergoing some major changes. We prepare the introduction of a rewritten codebase for most of the underlying functionality. A direct consequence of this is that it is unlikely that any open/new bugs within the current/old codebase will be fixed (unless someone steps up and offers to do so) as most resources currently available will be invested in making the rewrite prime time ready. If you are still interested in working on the new codebase (repositories: hamster-lib/cli/gtk/dbus) we would be most thrilled. Please feel free to either open a new issue with the relevant repository and/or join the discussion on the mailinglist. Thanks for your interest and support! Eric. |
data/wscript_build
Outdated
@@ -12,6 +12,7 @@ bld.install_files('${DATADIR}/icons/hicolor/32x32/apps', 'art/32x32/hamster-ti | |||
bld.install_files('${DATADIR}/icons/hicolor/48x48/apps', 'art/scalable/hamster-time-tracker.png') | |||
bld.install_files('${DATADIR}/icons/hicolor/scalable/apps','art/scalable/hamster-time-tracker.svg') | |||
|
|||
bld.install_files('${DATADIR}/appdata/hamster-time-tracker.appdata.xml', 'hamster-time-tracker.appdata.xml') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Destination must not contain the file name - only the destination directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
https://build.opensuse.org/request/show/433873 now all checks succeed. |
Thanks for your contributions ! Then a separate PR would be best, based on the |
Well, changing the base branch myself turned out to be a mess. 😥 |
This work is being updated in PR #441. Closing, thanks for your contribution ! |
@Mailaender closed, but the proposition to rebase on the hamster-stable branch still holds, |
See https://people.freedesktop.org/~hughsient/appdata/ for more information.