Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an appdata.xml file for Linux software gallery integration #336

Closed
wants to merge 1 commit into from

Conversation

Mailaender
Copy link
Contributor

@Mailaender
Copy link
Contributor Author

See https://build.opensuse.org/request/show/433055 for an integration test. I am not really sure what's wrong with the rpmlint checker as it crashes. The file seems to otherwise validate just fine.

@elbenfreund
Copy link
Contributor

Thank you for your feedback, it is much appreciated.

Project hamster and its various sub-components is currently undergoing some major changes. We prepare the introduction of a rewritten codebase for most of the underlying functionality. A direct consequence of this is that it is unlikely that any open/new bugs within the current/old codebase will be fixed (unless someone steps up and offers to do so) as most resources currently available will be invested in making the rewrite prime time ready.

If you are still interested in working on the new codebase (repositories: hamster-lib/cli/gtk/dbus) we would be most thrilled. Please feel free to either open a new issue with the relevant repository and/or join the discussion on the mailinglist.
For more context please see our website.

Thanks for your interest and support! Eric.

@@ -12,6 +12,7 @@ bld.install_files('${DATADIR}/icons/hicolor/32x32/apps', 'art/32x32/hamster-ti
bld.install_files('${DATADIR}/icons/hicolor/48x48/apps', 'art/scalable/hamster-time-tracker.png')
bld.install_files('${DATADIR}/icons/hicolor/scalable/apps','art/scalable/hamster-time-tracker.svg')

bld.install_files('${DATADIR}/appdata/hamster-time-tracker.appdata.xml', 'hamster-time-tracker.appdata.xml')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Destination must not contain the file name - only the destination directory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@Mailaender
Copy link
Contributor Author

https://build.opensuse.org/request/show/433873 now all checks succeed.

@ederag
Copy link
Collaborator

ederag commented Jan 20, 2019

Thanks for your contributions !
We definitely need this appdata.xml, but the interface changed a lot meanwhile.
Screenshots linked in this appdata.xml are for the "hamster-applet" (before 2.0) version.
So the best course of action might be to rebase this PR on the hamster_stable branch,
so that I can merge it there.

Then a separate PR would be best, based on the master branch,
with updated screenshots and data.
It should be possible to have the main screenshot.png in the root directory,
and other screenshots in a data/screenshots/ directory,
all tracked by git (png screenshots should be small enough for that).
Later on, it will be possible to get links for a specific release version,
and automate the process with bump2version for instance.

@ederag ederag changed the base branch from master to hamster_stable March 10, 2019 11:38
@ederag ederag changed the base branch from hamster_stable to master March 10, 2019 11:39
@ederag
Copy link
Collaborator

ederag commented Mar 10, 2019

Well, changing the base branch myself turned out to be a mess. 😥
Revert. 😌

@ederag
Copy link
Collaborator

ederag commented Sep 14, 2019

This work is being updated in PR #441. Closing, thanks for your contribution !

@ederag ederag closed this Sep 14, 2019
@ederag
Copy link
Collaborator

ederag commented Sep 14, 2019

@Mailaender closed, but the proposition to rebase on the hamster-stable branch still holds,
if you want to get it merged there. Thanks again !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants