Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Append to file if output file is already created. #823

Merged
merged 4 commits into from
Oct 29, 2022
Merged

Append to file if output file is already created. #823

merged 4 commits into from
Oct 29, 2022

Conversation

ShubhamRasal
Copy link
Contributor

No description provided.

@ShubhamRasal ShubhamRasal self-assigned this Oct 21, 2022
@ShubhamRasal ShubhamRasal linked an issue Oct 21, 2022 that may be closed by this pull request
resume flag overwrites output file #792
Closed
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 21, 2022
View reviewed changes
@ShubhamRasal ShubhamRasal marked this pull request as draft October 21, 2022 08:36
@ShubhamRasal ShubhamRasal marked this pull request as ready for review October 21, 2022 09:16
@ShubhamRasal ShubhamRasal added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Oct 21, 2022
Mzack9999
Mzack9999 approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - os.Create uses by default 0666

ehsandeep
ehsandeep requested changes Oct 27, 2022
View reviewed changes
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPEND is required only when the -resume option is used; otherwise httpx and other pd tools default to write/overwrite to the given output file.

@ShubhamRasal ShubhamRasal marked this pull request as draft October 27, 2022 16:30
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ShubhamRasal ShubhamRasal marked this pull request as ready for review October 28, 2022 05:41
@ehsandeep ehsandeep merged commit 33a8fc0 into dev Oct 29, 2022
@ehsandeep ehsandeep deleted the issue-792-resume-output-file branch October 29, 2022 09:06
@ehsandeep ehsandeep removed the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@ShubhamRasal ShubhamRasal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

resume flag overwrites output file
3 participants
@ShubhamRasal @ehsandeep @Mzack9999