Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/xdscache: add v3 package #3121

Merged
merged 3 commits into from
Nov 12, 2020
Merged

Conversation

skriss
Copy link
Member

@skriss skriss commented Nov 12, 2020

Depends on #3120
Depends on #3118

Commit 1486fda is the only one with actual changes.

@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #3121 (fb5f09f) into main (3e0cafd) will increase coverage by 1.68%.
The diff coverage is 82.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3121      +/-   ##
==========================================
+ Coverage   74.53%   76.21%   +1.68%     
==========================================
  Files         112      117       +5     
  Lines        7045     7577     +532     
==========================================
+ Hits         5251     5775     +524     
+ Misses       1686     1672      -14     
- Partials      108      130      +22     
Impacted Files Coverage Δ
internal/xdscache/v3/endpointstranslator.go 70.62% <70.62%> (ø)
internal/xdscache/v3/route.go 81.89% <81.89%> (ø)
internal/xdscache/v3/cluster.go 87.87% <87.87%> (ø)
internal/xdscache/v3/secret.go 89.74% <89.74%> (ø)
internal/xdscache/v3/listener.go 91.84% <91.84%> (ø)
... and 8 more

Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss changed the title V3 xdscache internal/xdscache: add v3 package Nov 12, 2020
@skriss skriss marked this pull request as ready for review November 12, 2020 20:28
Copy link
Member

@stevesloka stevesloka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: Steve Kriss <krisss@vmware.com>
@stevesloka stevesloka merged commit a84d14d into projectcontour:main Nov 12, 2020
@skriss skriss deleted the v3-xdscache branch November 12, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants