Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Migrate all v2 xDS resource versions to v3 for package internal/envoy/v3 #3118

Merged
merged 3 commits into from
Nov 12, 2020

Conversation

stevesloka
Copy link
Member

Updates #1898

@stevesloka stevesloka added this to the 1.11.0 milestone Nov 12, 2020
@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #3118 (c72650a) into main (18fbcf8) will increase coverage by 1.23%.
The diff coverage is 82.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3118      +/-   ##
==========================================
+ Coverage   73.29%   74.53%   +1.23%     
==========================================
  Files         103      112       +9     
  Lines        6190     7045     +855     
==========================================
+ Hits         4537     5251     +714     
- Misses       1552     1686     +134     
- Partials      101      108       +7     
Impacted Files Coverage Δ
internal/envoy/v3/tls.go 0.00% <0.00%> (ø)
internal/envoy/v3/endpoint.go 84.21% <62.50%> (-15.79%) ⬇️
internal/envoy/v3/listener.go 67.28% <64.37%> (+21.83%) ⬆️
internal/envoy/v3/cluster.go 80.80% <77.98%> (-19.21%) ⬇️
internal/envoy/v3/route.go 87.70% <87.70%> (ø)
internal/sorter/sorter.go 91.86% <92.37%> (-3.42%) ⬇️
internal/envoy/v3/accesslog.go 100.00% <100.00%> (ø)
internal/envoy/v3/auth.go 100.00% <100.00%> (ø)
internal/envoy/v3/healthcheck.go 100.00% <100.00%> (ø)
internal/envoy/v3/regex.go 100.00% <100.00%> (ø)
... and 15 more

@stevesloka stevesloka force-pushed the movev2-v3 branch 2 times, most recently from 723245a to 3981fb6 Compare November 12, 2020 17:15
Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I've been working on updating the internal/xdscache code for v3, and I was able to get those changes to compile after rebasing on this branch, so that's another validation that this is 👍 .

I'd like to follow up with some more cleanup on import aliases, but prefer to do that separately.

…oy/v3

Signed-off-by: Steve Sloka <slokas@vmware.com>
…rnal/envoy/v3

Signed-off-by: Steve Sloka <slokas@vmware.com>
Signed-off-by: Steve Sloka <slokas@vmware.com>
@stevesloka
Copy link
Member Author

@skriss I added the tls.go to this PR. Once it passes CI I'll merge it and then can review your xdscache branch.

@stevesloka stevesloka merged commit 3e0cafd into projectcontour:main Nov 12, 2020
@stevesloka stevesloka deleted the movev2-v3 branch November 12, 2020 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants