Make race detector optional. Enable by default. #2386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brian-McM
reviewed
Jun 15, 2020
Brian-McM
approved these changes
Jun 15, 2020
realgaurav
reviewed
Jun 15, 2020
| image-test: image fv/Dockerfile.test.amd64 bin/pktgen bin/test-workload bin/test-connection bin/calico-felix-race-amd64 image-wgtool | ||
| docker build -t $(BUILD_IMAGE)-test:latest-$(ARCH) --build-arg QEMU_IMAGE=$(CALICO_BUILD) --file ./fv/Dockerfile.test.$(ARCH) bin; | ||
| ifeq ($(FV_RACE_DETECTOR_ENABLED),true) | ||
| FV_BINARY=calico-felix-race-amd64 |
There was a problem hiding this comment.
This seem to be forcing ARCH=amd64 but the docker build command below consider $(ARCH).
Is this expected behavior?
There was a problem hiding this comment.
@fasaxc, can you follow up with this later please? Since this isn't a regression we're merging this through so that I can get unblocked.
There was a problem hiding this comment.
Yeah, FVs are amd64 only (previously that was just hard-coded in the dockerfile).
realgaurav
approved these changes
Jun 15, 2020
caseydavenport
added
docs-not-required
release-note-not-required
and removed
docs-pr-required
release-note-required
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new build option to enable/disable the race detector:
Enabled by default.
Todos
Release Note