Merge pull request #2386 from fasaxc/race-detect-option

Make race detector optional. Enable by default.
projectcalico · Jun 15, 2020 · a24d509 · a24d509
2 parents 22a4ef3 + f27861c
commit a24d509
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 6 deletions.
diff --git a/Makefile b/Makefile
@@ -94,6 +94,7 @@ FV_NUM_BATCHES?=1
 # (with FV_NUM_BATCHES=1) to check that it's not a flake.
 FV_BATCHES_TO_RUN?=$(shell seq $(FV_NUM_BATCHES))
 FV_SLOW_SPEC_THRESH=90
+FV_RACE_DETECTOR_ENABLED?=true
 
 # Linker flags for building Felix.
 #
@@ -246,8 +247,14 @@ ifeq ($(ARCH),amd64)
 	docker tag $(BUILD_IMAGE):latest-$(ARCH) $(BUILD_IMAGE):latest
 endif
 
-image-test: image fv/Dockerfile.test.amd64 bin/pktgen bin/test-workload bin/test-connection bin/calico-felix-race-amd64 image-wgtool
-	docker build -t $(BUILD_IMAGE)-test:latest-$(ARCH) --build-arg QEMU_IMAGE=$(CALICO_BUILD) --file ./fv/Dockerfile.test.$(ARCH) bin;
+ifeq ($(FV_RACE_DETECTOR_ENABLED),true)
+FV_BINARY=calico-felix-race-amd64
+else
+FV_BINARY=calico-felix-amd64
+endif
+
+image-test: image fv/Dockerfile.test.amd64 bin/pktgen bin/test-workload bin/test-connection bin/$(FV_BINARY) image-wgtool
+	docker build -t $(BUILD_IMAGE)-test:latest-$(ARCH) --build-arg FV_BINARY=$(FV_BINARY) --file ./fv/Dockerfile.test.$(ARCH) bin;
 ifeq ($(ARCH),amd64)
 	docker tag $(BUILD_IMAGE)-test:latest-$(ARCH) $(BUILD_IMAGE)-test:latest
 endif
@@ -405,6 +412,7 @@ fv fv/latency.log fv/data-races.log: $(REMOTE_DEPS) image-test bin/iptables-lock
 	  GINKGO_ARGS='$(GINKGO_ARGS)' \
 	  GINKGO_FOCUS="$(GINKGO_FOCUS)" \
 	  FELIX_FV_ENABLE_BPF="$(FELIX_FV_ENABLE_BPF)" \
+	  FV_RACE_DETECTOR_ENABLED=$(FV_RACE_DETECTOR_ENABLED) \
 	  ./run-batches
 	@if [ -e fv/latency.log ]; then \
 	   echo; \

diff --git a/fv/Dockerfile.test.amd64 b/fv/Dockerfile.test.amd64
@@ -30,5 +30,7 @@ RUN apt-get update && apt-get install -y \
     ethtool \
     tcpdump
 
+ARG FV_BINARY=calico-felix-amd64
+
 ADD test-connection test-workload pktgen  /
-ADD calico-felix-race-amd64 /code/calico-felix
+ADD $FV_BINARY /code/calico-felix
diff --git a/fv/fv_infra_test.go b/fv/fv_infra_test.go
@@ -203,9 +203,15 @@ var _ = infrastructure.DatastoreDescribe("Container self tests",
 				options.ExtraEnvVars["FELIX_DebugSimulateDataRace"] = "true"
 			})
 
-			It("should detect a race", func() {
-				Eventually(felixes[0].DataRaces).ShouldNot(BeEmpty())
-			})
+			if os.Getenv("FV_RACE_DETECTOR_ENABLED") == "true" {
+				It("should detect a race", func() {
+					Eventually(felixes[0].DataRaces).ShouldNot(BeEmpty())
+				})
+			} else {
+				It("should not detect a race because race detector is disabled", func() {
+					Consistently(felixes[0].DataRaces).Should(BeEmpty())
+				})
+			}
 		})
 	},
 )