Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect "open enhanced commissioning window" UI on M5Stack. #9576

Conversation

bzbarsky-apple
Copy link
Contributor

The option doesn't actually open an enhanced commissioning window. It
opens a basic one, but then advertises as if it opened an enhanced
one, sort of. This is not actually usable/useful, as far as I can
tell.

Problem

UI was accidentally added as part of a build fix in #9114 that does not do what it says it does.

Change overview

Just remove the new UI.

Testing

Looked at M5Stack screen, option is gone.

The option doesn't actually open an enhanced commissioning window.  It
opens a basic one, but then advertises as if it opened an enhanced
one, sort of.  This is not actually usable/useful, as far as I can
tell.
@github-actions
Copy link

github-actions bot commented Sep 9, 2021

Size increase report for "esp32-example-build" from f0c70d3

File Section File VM
chip-shell.elf .flash.text -48 -48
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-bridge-app.elf and ./pull_artifact/chip-bridge-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
[Unmapped],0,48
.flash.text,-48,-48

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize


@bzbarsky-apple bzbarsky-apple merged commit fce8561 into project-chip:master Sep 9, 2021
@bzbarsky-apple bzbarsky-apple deleted the remove-bogus-window-option branch September 10, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants