Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add argument to AdvertiseCommissionableNode for M5Stack #9114

Merged
merged 3 commits into from
Aug 18, 2021

Conversation

andy31415
Copy link
Contributor

Problem

Compile error when running

./scripts/build/build_examples.py --platform esp32 --app all-clusters build

Change overview

Add required argument to commisionable mode advertisement

Testing

Compilation passes.

@andy31415 andy31415 added hotfix urgent fix needed, can bypass review Tested manually labels Aug 18, 2021
@andy31415 andy31415 merged commit 0bdeccb into project-chip:master Aug 18, 2021
@github-actions
Copy link

Size increase report for "esp32-example-build" from 98e5494

File Section File VM
chip-bridge-app.elf .flash.text -48 -48
chip-shell.elf .flash.text -8 -8
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-bridge-app.elf and ./pull_artifact/chip-bridge-app.elf:

sections,vmsize,filesize
[Unmapped],0,48
.flash.text,-48,-48

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
[Unmapped],0,8
.flash.text,-8,-8

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize


nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
…#9114)

* Add argument to AdvertiseCommissionableNode for M5Stack

* Fix namespace, add basic and enhanced options for commisioning

* Fix typo
@andy31415 andy31415 deleted the fix_commisionable_mode_build branch October 28, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples hotfix urgent fix needed, can bypass review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant