Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix log and add slight clarification #8225

Merged
merged 1 commit into from
Jul 9, 2021
Merged

Fix log and add slight clarification #8225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/darwin/Framework/CHIP/CHIPThreadOperationalDataset.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ extern size_t const CHIPSizeThreadPSKc;
*/
@property (nonatomic, readwrite) uint16_t channel;
/**
* The Thread PAN ID
* A uint16_t stored as 2-bytes in host order representing the Thread PAN ID
*/
@property (nonatomic, nullable, readwrite) NSData * panID;

Expand All @@ -62,7 +62,9 @@ extern size_t const CHIPSizeThreadPSKc;

/**
* Create a Thread Operational Dataset object with the individual network fields.
* This initializer will return nil if any of the NSData fields are smaller than expected.
* This initializer will return nil if any of the NSData fields don't match the expected size.
*
* Note: The panID is expected to be a uint16_t stored as 2-bytes in host order
*/
- (nullable instancetype)initWithNetworkName:(NSString *)networkName
extendedPANID:(NSData *)extendedPANID
Expand Down
2 changes: 1 addition & 1 deletion src/darwin/Framework/CHIP/CHIPThreadOperationalDataset.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ - (BOOL)_populateCppOperationalDataset
- (BOOL)_checkDataLength:(NSData *)data expectedLength:(size_t)expectedLength
{
if (data.length != expectedLength) {
CHIP_LOG_ERROR("Length Check Failed. Length:%tu is too short, must be at least %tu", data.length, expectedLength);
CHIP_LOG_ERROR("Length Check Failed. Length:%tu is incorrect, must be %tu", data.length, expectedLength);
return NO;
}
return YES;
Expand Down