-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement User Directed Commissioning - Phase 2 #8084
Conversation
fix listen portconnectedhomeip/src/controller/CHIPDeviceController.cpp Lines 843 to 853 in e86bd42
This comment was generated by todo based on a
|
determine when UDC client's state should time out
This comment was generated by todo based on a
|
check length of instanceNameconnectedhomeip/src/protocols/user_directed_commissioning/UDCClients.h Lines 153 to 163 in e86bd42
This comment was generated by todo based on a
|
do we need these std::move calls?connectedhomeip/src/protocols/user_directed_commissioning/UserDirectedCommissioningServer.cpp Lines 47 to 57 in e86bd42
This comment was generated by todo based on a
|
determine when UDC client's state should time out
This comment was generated by todo based on a
|
determine when UDC client's state should time out
This comment was generated by todo based on a
|
determine when UDC client's state should time out
This comment was generated by todo based on a
|
src/protocols/user_directed_commissioning/UserDirectedCommissioningServer.cpp
Show resolved
Hide resolved
I only saw one thing that I thought could warrant action: https://github.com/project-chip/connectedhomeip/pull/8084/files#r674043623 All else looks good to me. My other comments about ports are editorial in regards to larger stack architecture and / or covered by future work. |
* second round of UDC feature * build fixes * build fixes * CI build fixes * CI build fixes * CI build fixes - Android * CI build fixes * CI linux build fix * Restyled by whitespace (project-chip#8247) Co-authored-by: Restyled.io <commits@restyled.io> * address comments * address comments * address comments * address comments * address comments * revert changes to echo requester/responder * fix CI builds Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io>
Address 6789 - User Directed Commissioning (UDC) needs implementation
Summary of Changes
How was this Tested