Implement User Directed Commissioning - Phase 2

[chrisdecenzo]

Address 6789 - User Directed Commissioning (UDC) needs implementation

Summary of Changes

• Add Message handler for UDC messages, enabled when CHIP_DEVICE_CONFIG_ENABLE_COMMISSIONER_DISCOVERY=1
• Add Client for UDC messages, enabled when CHIP_DEVICE_CONFIG_ENABLE_COMMISSIONER_DISCOVERY_CLIENT=1
• Add shell commands to invoke these features
• Enable commissioner on tv-app
• Enable UDC client on linux lighting-app for testing via shell
• Fixes Implement User Directed Commissioning #6789

How was this Tested

• tv-app now includes the device commissioner code along with shell commands for managing the UDC state cache.
• lighting-app for linux now includes the UDC client along with shell commands for sending the UDC message. To do this call "commissionee sendudc 127.0.0.1 11100" from lighting app. See printouts of tv-app indicating UDC message received, perform commissionable discovery on result, print out callback intended for UX (for user to accept commissioning of client).

[todo]

fix listen port

connectedhomeip/src/controller/CHIPDeviceController.cpp

Lines 843 to 853 in e86bd42

	// TODO: fix listen port
	ReturnErrorOnFailure(mUdcTransportMgr->Init(Transport::UdpListenParameters(mInetLayer)
	.SetAddressType(Inet::kIPAddressType_IPv6)
	.SetListenPort((uint16_t)(mListenPort + 1))
	#if INET_CONFIG_ENABLE_IPV4
	,
	Transport::UdpListenParameters(mInetLayer)
	.SetAddressType(Inet::kIPAddressType_IPv4)
	.SetListenPort((uint16_t)(mListenPort + 1))
	#endif
	#if CONFIG_NETWORK_LAYER_BLE

---

This comment was generated by todo based on a TODO comment in e86bd42 in #8084. cc @project-chip.

[todo]

determine when UDC client's state should time out

connectedhomeip/src/protocols/user_directed_commissioning/UDCClients.h

Lines 29 to 39 in e86bd42

	// TODO: determine when UDC client's state should time out
	constexpr const uint64_t kUDCClientTimeoutMs = 60 * 60 * 1000;
	/**
	* Handles a set of UDC Client Processing States.
	*
	* Intended for:
	* - ignoring/dropping duplicate UDC messages for the same instance
	* - tracking state of UDC work flow (see UDCClientProcessingState)
	* - timing out failed/declined UDC Clients
	*/

---

This comment was generated by todo based on a TODO comment in e86bd42 in #8084. cc @project-chip.

[todo]

check length of instanceName

connectedhomeip/src/protocols/user_directed_commissioning/UDCClients.h

Lines 153 to 163 in e86bd42

	// TODO: check length of instanceName
	if (strncmp(iter->GetInstanceName(), instanceName, chip::Mdns::kMaxInstanceNameSize + 1) == 0)
	{
	state = iter;
	break;
	}
	}
	return state;
	}
	// Reset all states to kNotInitialized

---

This comment was generated by todo based on a TODO comment in e86bd42 in #8084. cc @project-chip.

[todo]

do we need these std::move calls?

connectedhomeip/src/protocols/user_directed_commissioning/UserDirectedCommissioningServer.cpp

Lines 47 to 57 in e86bd42

	// TODO: do we need these std::move calls?
	System::PacketBufferHandle && msg = std::move(msgBuf);
	PayloadHeader payloadHeader;
	ReturnOnFailure(payloadHeader.DecodeAndConsume(msg));
	System::PacketBufferHandle && payload = std::move(msg);
	char instanceName[chip::Mdns::kMaxInstanceNameSize + 1];
	int instanceNameLength =
	(payload->DataLength() > (chip::Mdns::kMaxInstanceNameSize)) ? chip::Mdns::kMaxInstanceNameSize : payload->DataLength();

---

This comment was generated by todo based on a TODO comment in e86bd42 in #8084. cc @project-chip.

[todo]

determine when UDC client's state should time out

connectedhomeip/src/protocols/user_directed_commissioning/UDCClients.h

Lines 29 to 39 in 5547040

	// TODO: determine when UDC client's state should time out
	constexpr const uint64_t kUDCClientTimeoutMs = 60 * 60 * 1000;
	/**
	* Handles a set of UDC Client Processing States.
	*
	* Intended for:
	* - ignoring/dropping duplicate UDC messages for the same instance
	* - tracking state of UDC work flow (see UDCClientProcessingState)
	* - timing out failed/declined UDC Clients
	*/

---

This comment was generated by todo based on a TODO comment in 5547040 in #8084. cc @project-chip.

[todo]

determine when UDC client's state should time out

connectedhomeip/src/protocols/user_directed_commissioning/UDCClients.h

Lines 29 to 39 in e9f1f48

	// TODO: determine when UDC client's state should time out
	constexpr const uint64_t kUDCClientTimeoutMs = 60 * 60 * 1000;
	/**
	* Handles a set of UDC Client Processing States.
	*
	* Intended for:
	* - ignoring/dropping duplicate UDC messages for the same instance
	* - tracking state of UDC work flow (see UDCClientProcessingState)
	* - timing out failed/declined UDC Clients
	*/

---

This comment was generated by todo based on a TODO comment in e9f1f48 in #8084. cc @project-chip.

[todo]

determine when UDC client's state should time out

connectedhomeip/src/protocols/user_directed_commissioning/UDCClients.h

Lines 29 to 39 in 66acd5a

	// TODO: determine when UDC client's state should time out
	constexpr const uint64_t kUDCClientTimeoutMs = 60 * 60 * 1000;
	/**
	* Handles a set of UDC Client Processing States.
	*
	* Intended for:
	* - ignoring/dropping duplicate UDC messages for the same instance
	* - tracking state of UDC work flow (see UDCClientProcessingState)
	* - timing out failed/declined UDC Clients
	*/

---

This comment was generated by todo based on a TODO comment in 66acd5a in #8084. cc @project-chip.

[msandstedt]

I only saw one thing that I thought could warrant action:

https://github.com/project-chip/connectedhomeip/pull/8084/files#r674043623

All else looks good to me. My other comments about ports are editorial in regards to larger stack architecture and / or covered by future work.

Feedback resolved