-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CreateNewUDCClientState is not safe to call more than once in a row #8564
Comments
Fixed in 8084, assigning to Boris to close |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
And just to be clear, @chrisdecenzo this was not addressed in #8084 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Problem
Consider the following order of events:
CreateNewUDCClientState
is called.CreateNewUDCClientState
is called again and returns the same pointer because the time passed was enough for the state we got to not be considered initialized anymore.This never happens in our code right now (as long as all access to the UDC client states is on a single thread) because we never store the pointers
CreateNewUDCClientState
returns across another call toCreateNewUDCClientState
. But this seems pretty fragile.Proposed Solution
Figure out a safer API.
The text was updated successfully, but these errors were encountered: