Add custom ZCL extensions inside src/app/zap-templates #4192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivien-apple
force-pushed
the
Cluster_CustomZCLExtensions
branch
2 times, most recently
from
3fb0894
to
6e46031
Compare
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
rwalker-apple and
saurabhst
bzbarsky-apple
approved these changes
Dec 14, 2020
Comment on lines
+4473
to
+4477
| #define ZCL_CLUSTER_REVISION_CLIENT_ATTRIBUTE_ID (0xFFFD) | ||
| #define ZCL_REPORTING_STATUS_CLIENT_ATTRIBUTE_ID (0xFFFE) | ||
|
|
||
| // Server attributes | ||
| #define ZCL_CLUSTER_REVISION_SERVER_ATTRIBUTE_ID (0xFFFD) | ||
| #define ZCL_REPORTING_STATUS_SERVER_ATTRIBUTE_ID (0xFFFE) |
There was a problem hiding this comment.
So this is duplicating values for other clusters?
Could we just define the "global" attribute ids that are the same for all clusters once? Followup for this, please.
Also, in CHIP, I don't see a "reporting status" attribute. What I do see is a "FeatureMap" attribute with ID 0xFFFC. Again, followup.
There was a problem hiding this comment.
So this is duplicating values for other clusters?
Could we just define the "global" attribute ids that are the same for all clusters once? Followup for this, please.
I opened #4219 for this one (with a patch).
mspang
approved these changes
Dec 15, 2020
vivien-apple
added a commit
to vivien-apple/connectedhomeip-1
that referenced
this pull request
Dec 15, 2020
…and 'src/app/chip-zcl-zpro-codec-api.h' Problem So far `src/app/chip-zcl-zpro-codec-api.h` and `src/app/encoder.cpp` has been generated using times to times by manually adding the related templates to to the `chip-templates.json` and removing it before checking-in the code since this code does not really belongs to application folders. It is error prone. An in fact I broken it with project-chip#4155 since attributes appears multiple times because of the second endpoint. This PR splits the `zap-templates` folder in two, with one folder for the examples and one fodler for chip related code. Summary of changes * Split `zap-templates` folder in two * Split `helper-chip.js` into multiple helpers and move those helpers where they belongs * Add a new `scripts/tools/zap_generate_chip.sh` script to generate the `src/app` content * Add `scripts/tools/zap_generate_chip.sh` to `scripts/tools/zap_regen_all.py` * Create a partial for the licensing `header` instead of relying on js for it * Fix the attribute issue mentioned above * Remove `asChipUnderlyingType` since it relies on `asUnderlyingZclType` and we should be able to fix the issue directly once project-chip#4192 lands and it really does not introduce any problem to remove it
vivien-apple
added a commit
to vivien-apple/connectedhomeip-1
that referenced
this pull request
Dec 15, 2020
…and 'src/app/chip-zcl-zpro-codec-api.h' Problem So far `src/app/chip-zcl-zpro-codec-api.h` and `src/app/encoder.cpp` has been generated using times to times by manually adding the related templates to to the `chip-templates.json` and removing it before checking-in the code since this code does not really belongs to application folders. It is error prone. An in fact I broken it with project-chip#4155 since attributes appears multiple times because of the second endpoint. This PR splits the `zap-templates` folder in two, with one folder for the examples and one fodler for chip related code. Summary of changes * Split `zap-templates` folder in two * Split `helper-chip.js` into multiple helpers and move those helpers where they belongs * Add a new `scripts/tools/zap_generate_chip.sh` script to generate the `src/app` content * Add `scripts/tools/zap_generate_chip.sh` to `scripts/tools/zap_regen_all.py` * Create a partial for the licensing `header` instead of relying on js for it * Fix the attribute issue mentioned above * Remove `asChipUnderlyingType` since it relies on `asUnderlyingZclType` and we should be able to fix the issue directly once project-chip#4192 lands and it really does not introduce any problem to remove it
vivien-apple
added a commit
to vivien-apple/connectedhomeip-1
that referenced
this pull request
Dec 15, 2020
…and 'src/app/chip-zcl-zpro-codec-api.h' Problem So far `src/app/chip-zcl-zpro-codec-api.h` and `src/app/encoder.cpp` has been generated using times to times by manually adding the related templates to to the `chip-templates.json` and removing it before checking-in the code since this code does not really belongs to application folders. It is error prone. An in fact I broken it with project-chip#4155 since attributes appears multiple times because of the second endpoint. This PR splits the `zap-templates` folder in two, with one folder for the examples and one fodler for chip related code. Summary of changes * Split `zap-templates` folder in two * Split `helper-chip.js` into multiple helpers and move those helpers where they belongs * Add a new `scripts/tools/zap_generate_chip.sh` script to generate the `src/app` content * Add `scripts/tools/zap_generate_chip.sh` to `scripts/tools/zap_regen_all.py` * Create a partial for the licensing `header` instead of relying on js for it * Fix the attribute issue mentioned above * Remove `asChipUnderlyingType` since it relies on `asUnderlyingZclType` and we should be able to fix the issue directly once project-chip#4192 lands and it really does not introduce any problem to remove it
vivien-apple
added a commit
to vivien-apple/connectedhomeip-1
that referenced
this pull request
Dec 16, 2020
…and 'src/app/chip-zcl-zpro-codec-api.h' Problem So far `src/app/chip-zcl-zpro-codec-api.h` and `src/app/encoder.cpp` has been generated using times to times by manually adding the related templates to to the `chip-templates.json` and removing it before checking-in the code since this code does not really belongs to application folders. It is error prone. An in fact I broken it with project-chip#4155 since attributes appears multiple times because of the second endpoint. This PR splits the `zap-templates` folder in two, with one folder for the examples and one fodler for chip related code. Summary of changes * Split `zap-templates` folder in two * Split `helper-chip.js` into multiple helpers and move those helpers where they belongs * Add a new `scripts/tools/zap_generate_chip.sh` script to generate the `src/app` content * Add `scripts/tools/zap_generate_chip.sh` to `scripts/tools/zap_regen_all.py` * Create a partial for the licensing `header` instead of relying on js for it * Fix the attribute issue mentioned above * Remove `asChipUnderlyingType` since it relies on `asUnderlyingZclType` and we should be able to fix the issue directly once project-chip#4192 lands and it really does not introduce any problem to remove it
rwalker-apple
approved these changes
Jan 5, 2021
mspang
pushed a commit
that referenced
this pull request
Jan 6, 2021
…and 'src/app/chip-zcl-zpro-codec-api.h' (#4212) Problem So far `src/app/chip-zcl-zpro-codec-api.h` and `src/app/encoder.cpp` has been generated using times to times by manually adding the related templates to to the `chip-templates.json` and removing it before checking-in the code since this code does not really belongs to application folders. It is error prone. An in fact I broken it with #4155 since attributes appears multiple times because of the second endpoint. This PR splits the `zap-templates` folder in two, with one folder for the examples and one fodler for chip related code. Summary of changes * Split `zap-templates` folder in two * Split `helper-chip.js` into multiple helpers and move those helpers where they belongs * Add a new `scripts/tools/zap_generate_chip.sh` script to generate the `src/app` content * Add `scripts/tools/zap_generate_chip.sh` to `scripts/tools/zap_regen_all.py` * Create a partial for the licensing `header` instead of relying on js for it * Fix the attribute issue mentioned above * Remove `asChipUnderlyingType` since it relies on `asUnderlyingZclType` and we should be able to fix the issue directly once #4192 lands and it really does not introduce any problem to remove it
This PR introduces a folder inside `src/app/zap-templates` to host custom ZCL extensions such as the `MfgSpecificPing` command introduced in project-chip#4127 as well as a `Binding Cluster` from project-chip#4156. The `Binding Cluster` exposes 2 methods, `Bind` and `Unbind`. The current spec defines `bindings` has an `RW` attribute but an issue has been opened since it does not look very convenient (see CHIP-Specifications/connectedhomeip-spec#627) The `gen/` folders are also updated to reflect the addition of the `Binding Cluster`. Futhermore, the 2 scripts used to generates the `gen/` folders have also been updated to points to the `src/app/zap-templates/zcl/zcl.json` instead of `third_party/zap/repo/zcl-builtin/silabs/zcl.json` since the former is a superset of the later.
vivien-apple
force-pushed
the
Cluster_CustomZCLExtensions
branch
from
6e46031
to
906e68a
Compare
BroderickCarlin
approved these changes
Jan 8, 2021
kpschoedel
pushed a commit
to kpschoedel/connectedhomeip
that referenced
this pull request
Jan 8, 2021
…and 'src/app/chip-zcl-zpro-codec-api.h' (project-chip#4212) Problem So far `src/app/chip-zcl-zpro-codec-api.h` and `src/app/encoder.cpp` has been generated using times to times by manually adding the related templates to to the `chip-templates.json` and removing it before checking-in the code since this code does not really belongs to application folders. It is error prone. An in fact I broken it with project-chip#4155 since attributes appears multiple times because of the second endpoint. This PR splits the `zap-templates` folder in two, with one folder for the examples and one fodler for chip related code. Summary of changes * Split `zap-templates` folder in two * Split `helper-chip.js` into multiple helpers and move those helpers where they belongs * Add a new `scripts/tools/zap_generate_chip.sh` script to generate the `src/app` content * Add `scripts/tools/zap_generate_chip.sh` to `scripts/tools/zap_regen_all.py` * Create a partial for the licensing `header` instead of relying on js for it * Fix the attribute issue mentioned above * Remove `asChipUnderlyingType` since it relies on `asUnderlyingZclType` and we should be able to fix the issue directly once project-chip#4192 lands and it really does not introduce any problem to remove it
kpschoedel
pushed a commit
to kpschoedel/connectedhomeip
that referenced
this pull request
Jan 8, 2021
…4192) This PR introduces a folder inside `src/app/zap-templates` to host custom ZCL extensions such as the `MfgSpecificPing` command introduced in project-chip#4127 as well as a `Binding Cluster` from project-chip#4156. The `Binding Cluster` exposes 2 methods, `Bind` and `Unbind`. The current spec defines `bindings` has an `RW` attribute but an issue has been opened since it does not look very convenient (see CHIP-Specifications/connectedhomeip-spec#627) The `gen/` folders are also updated to reflect the addition of the `Binding Cluster`. Futhermore, the 2 scripts used to generates the `gen/` folders have also been updated to points to the `src/app/zap-templates/zcl/zcl.json` instead of `third_party/zap/repo/zcl-builtin/silabs/zcl.json` since the former is a superset of the later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR introduces a folder inside
src/app/zap-templatesto host customZCL extensions such as the
MfgSpecificPingcommand introduced in #4127 aswell as the
Binding Clusterfrom #4156.The
Binding Clusterexposes 2 methods,BindandUnbind. The current specdefines
bindingshas anRWattribute but an issue has been opened since it doesnot look very convenient (see https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/627)
The
gen/folders are also updated to reflect the addition of theBinding Cluster.Futhermore, the 2 scripts used to generates the
gen/folders have also been updated topoints to the
src/app/zap-templates/zcl/zcl.jsoninstead ofthird_party/zap/repo/zcl-builtin/silabs/zcl.jsonsince the former is a superset of the later.