-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass ScopedNodeId between Bridge and Admin as Matter unique identifier #35864
Merged
tehampson
merged 4 commits into
project-chip:master
from
tehampson:alternative-scoped-node-refactor
Oct 2, 2024
Merged
Pass ScopedNodeId between Bridge and Admin as Matter unique identifier #35864
tehampson
merged 4 commits into
project-chip:master
from
tehampson:alternative-scoped-node-refactor
Oct 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review changes with SemanticDiff. |
tehampson
commented
Oct 1, 2024
tehampson
commented
Oct 1, 2024
examples/fabric-bridge-app/fabric-bridge-common/include/BridgedDeviceManager.h
Outdated
Show resolved
Hide resolved
PR #35864: Size comparison from 353f4df to 5607228 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
saurabhst
approved these changes
Oct 1, 2024
andy31415
approved these changes
Oct 2, 2024
yufengwangca
approved these changes
Oct 2, 2024
PR #35864: Size comparison from 353f4df to ffaff61 Increases above 0.2%:
Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Solution:
Alternative Considered:
Note: Normally changing a proto should not be done. It is done in this PR as we know that the proto is for examples compiled from source and running on the same machine and not accross networks where it is more difficult to ensure everything is updated all at once.
Fixes: #33221
Test: