Skip to content

Commit

Permalink
Address PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
tehampson committed Oct 2, 2024
1 parent 5607228 commit ffaff61
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions examples/fabric-admin/rpc/RpcServer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,8 @@ class FabricAdmin final : public rpc::FabricAdmin, public IcdManager::Delegate
chip_rpc_OperationStatus & response) override
{
VerifyOrReturnValue(request.has_id, pw::Status::InvalidArgument());
// TODO: OpenDeviceCommissioningWindow uses the same controller every time and doesn't currently accept FabricIndex. For now
// we are dropping fabric index from the scoped node id.
// TODO(#35875): OpenDeviceCommissioningWindow uses the same controller every time and doesn't currently accept
// FabricIndex. For now we are dropping fabric index from the scoped node id.
NodeId nodeId = request.id.node_id;
uint32_t commissioningTimeoutSec = request.commissioning_timeout;
uint32_t iterations = request.iterations;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ class BridgedDeviceManager
*
* This function attempts to remove a device and the associated dynamic endpoint by iterating through
* the available device and checking if the device matches the specified ScopedNodeId. If the device is
* found, it clears the dynamic endpoint.
* found, it removes the dynamic endpoint.
*
* @param scopedNodeId The ScopedNodeId of the device to be removed.
* @return unsigned of the index of the removed dynamic endpoint if successful, nullopt otherwise.
Expand Down

0 comments on commit ffaff61

Please sign in to comment.