[occupancy-sensing] Follow up improvements for Occupancy Sensing Cluster updates for Matter 1.4 #34658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er updates for Matter 1.4 * Apply follow-up suggestions from review PR#34293 * Make HoldTime attribute writable * Fix array index mapping issue reported from PR#34593 in occupancy-sensing-stub.cpp Signed-off-by: Oliver Fan <oliver.fan@nxp.com>
|
Review changes with SemanticDiff. Analyzed 2 of 17 files.
|
|
PR #34658: Size comparison from 51e47f1 to 0771743 Full report (11 builds for cc32xx, mbed, nrfconnect, qpg, stm32, tizen)
|
…th-test-extensions.json file for Occupancy Sensing cluster Signed-off-by: Oliver Fan <oliver.fan@nxp.com>
|
PR #34658: Size comparison from 51e47f1 to 21f9f65 Full report (20 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, nxp, qpg, stm32, tizen)
|
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex and
harsha-rajendran
pullapprove
bot
requested review from
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
examples/all-clusters-app/all-clusters-common/src/occupancy-sensing-stub.cpp
Show resolved
Hide resolved
bzbarsky-apple
approved these changes
Jul 31, 2024
Signed-off-by: Oliver Fan <oliver.fan@nxp.com>
|
PR #34658: Size comparison from 51e47f1 to ff9272d Increases above 0.2%:
Full report (4 builds for mbed, nrfconnect)
|
jadhavrohit924
approved these changes
Aug 1, 2024
… Occupancy Sensing cluster Signed-off-by: Oliver Fan <oliver.fan@nxp.com>
|
PR #34658: Size comparison from bbef51a to f5fe683 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34658: Size comparison from 653a55f to 1ba22e7 Full report (20 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, nxp, qpg, stm32, tizen)
|
Signed-off-by: Oliver Fan <oliver.fan@nxp.com>
|
PR #34658: Size comparison from 653a55f to 4695b14 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
approved these changes
Aug 8, 2024
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Aug 12, 2024
…ter updates for Matter 1.4 (project-chip#34658) * [occupancy-sensing]Follow up improvements for Occupancy Sensing Cluster updates for Matter 1.4 * Apply follow-up suggestions from review PR#34293 * Make HoldTime attribute writable * Fix array index mapping issue reported from PR#34593 in occupancy-sensing-stub.cpp Signed-off-by: Oliver Fan <oliver.fan@nxp.com> * Regen ZAP after adding FeatureMap and HoldTime to zcl.json and zcl-with-test-extensions.json file for Occupancy Sensing cluster Signed-off-by: Oliver Fan <oliver.fan@nxp.com> * Restyled by clang-format * Restyled by prettier-json * Restyled by clang-format * Add an error print in occupancy-sensing-stub.cpp Signed-off-by: Oliver Fan <oliver.fan@nxp.com> * Update all-clusters-app.zap for HoldTime and FeatureMap attributes of Occupancy Sensing cluster Signed-off-by: Oliver Fan <oliver.fan@nxp.com> * Resolve merge conflict in endpoint_config.h Signed-off-by: Oliver Fan <oliver.fan@nxp.com> --------- Signed-off-by: Oliver Fan <oliver.fan@nxp.com> Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[occupancy-sensing] Follow up improvements for Occupancy Sensing Cluster updates for Matter 1.4