Skip to content

Commit

Permalink
Fixed ReviewFabricRestrictions command args (#34647)
Browse files Browse the repository at this point in the history
Was supposed to be a list of AccessRestrictionEntryStructs,
not AccessRestrictionStructs.  Spec text updated in PR #10176
Since AccessRestrictionEntryStruct is fabric-sensitive,
we use CommissioningAccessRestrictionEntryStruct.
  • Loading branch information
tleacmcsa authored Jul 31, 2024
1 parent 161b256 commit 51e47f1
Show file tree
Hide file tree
Showing 97 changed files with 152 additions and 118 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
4 changes: 2 additions & 2 deletions examples/bridge-app/bridge-common/bridge-app.matter
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down Expand Up @@ -566,7 +566,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
2 changes: 1 addition & 1 deletion examples/chef/devices/rootnode_doorlock_aNKYAreMXE.matter
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
2 changes: 1 addition & 1 deletion examples/chef/devices/rootnode_fan_7N2TobIlOX.matter
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
2 changes: 1 addition & 1 deletion examples/chef/devices/rootnode_onofflight_samplemei.matter
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
2 changes: 1 addition & 1 deletion examples/chef/devices/rootnode_pump_5f904818cc.matter
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
2 changes: 1 addition & 1 deletion examples/chef/devices/rootnode_pump_a811bb33a0.matter
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
2 changes: 1 addition & 1 deletion examples/chef/devices/rootnode_speaker_RpzeXdimqA.matter
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ cluster AccessControl = 31 {
readonly attribute int16u clusterRevision = 65533;

request struct ReviewFabricRestrictionsRequest {
AccessRestrictionStruct arl[] = 0;
CommissioningAccessRestrictionEntryStruct arl[] = 0;
}

response struct ReviewFabricRestrictionsResponse = 1 {
Expand Down
Loading

0 comments on commit 51e47f1

Please sign in to comment.