Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't force enable QPG6100 in gn_build.sh #3396

Merged
merged 1 commit into from
Oct 23, 2020
Merged

Don't force enable QPG6100 in gn_build.sh #3396

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Don't force enable QPG6100 in gn_build.sh 
This doesn't build on the Pi right now since we aren't fetching ARM GCC
on the platform yet (and the Ubuntu arm-none-gcc doesn't seem to have 64
bit integer formatting for printf, breaking the build).

Instead accept GN args on the command line of this script and print a
hint about how to enable it.
  • Loading branch information
@mspang
mspang committed Oct 22, 2020
commit dd0e5789b61b13c7a69dedaea05aa6cbc2833dcf
18 changes: 17 additions & 1 deletion gn_build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,16 @@ echo 'To build a custom build (for help run "gn args --list out/debug")'
echo gn args "$CHIP_ROOT/out/custom"
echo ninja -C "$CHIP_ROOT/out/custom"

extra_args=" enable_qpg6100_builds=true"
extra_args=""

for arg; do
case $arg in
enable_qpg6100_builds=true)
qpg6100_enabled=1
;;
esac
extra_args+=" $arg"
done

# Android SDK setup
android_sdk_args=""
Expand Down Expand Up @@ -131,6 +140,13 @@ else
fi
echo

if [[ -z "$qpg6100_enabled" ]]; then
echo "Hint: Pass enable_qpg6100_builds=true to this script to enable building for QPG6100"
else
echo 'To build the QPG6100 lock sample as a standalone project:'
echo "(cd $CHIP_ROOT/examples/lock-app/qpg6100; gn gen out/debug; ninja -C out/debug)"
fi

echo

_chip_banner "Build: GN configure"
Expand Down