Don't force enable QPG6100 in gn_build.sh #3396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't build on the Pi right now since we aren't fetching ARM GCC on the platform yet (and the Ubuntu arm-none-gcc doesn't seem to have 64 bit integer formatting for printf, breaking the build). Instead accept GN args on the command line of this script and print a hint about how to enable it.
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
rwalker-apple and
saurabhst
rwalker-apple
approved these changes
Oct 22, 2020
saurabhst
approved these changes
Oct 22, 2020
andy31415
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't build on the Pi right now since we aren't fetching ARM GCC
on the platform yet (and the Ubuntu arm-none-gcc doesn't seem to have 64
bit integer formatting for printf, breaking the build).
Instead accept GN args on the command line of this script and print a
hint about how to enable it.