Updated unit tests in src/transport/tests/ to use PW instead of NL. #33155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #33155: Size comparison from 742e65b to e355af0 Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
|
PR #33155: Size comparison from 742e65b to 98c095a Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
jlatusek
reviewed
Apr 25, 2024
| @@ -131,10 +128,25 @@ void TestSecureSessionTable::CreateSessionTable(std::vector<SessionParameters> & | |||
| } | |||
| } | |||
|
|
|||
| void TestSecureSessionTable::ValidateSessionSorting(nlTestSuite * inSuite, void * inContext) | |||
| class SecureSessionTableTest : public ::testing::Test | |||
There was a problem hiding this comment.
Merge this class with TestSecureSessionTable
jlatusek
reviewed
Apr 25, 2024
jlatusek
reviewed
Apr 25, 2024
|
PR #33155: Size comparison from a28965b to 20d5280 Full report (38 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
|
PR #33155: Size comparison from a28965b to b6a0dcf Increases (17 builds for esp32, telink)
Decreases (20 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, psoc6)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
jlatusek
suggested changes
Apr 26, 2024
|
PR #33155: Size comparison from a28965b to 64e1a39 Increases above 0.2%:
Increases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (14 builds for bl702l, linux, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
…nto feature/unittest-transport-tests
|
PR #33155: Size comparison from f9ac954 to 6c89ead Full report (6 builds for cc32xx, mbed, qpg, stm32)
|
|
PR #33155: Size comparison from f9ac954 to 3482974 Increases (2 builds for esp32)
Decreases (2 builds for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
|
PR #33155: Size comparison from 80c19cd to 380404f Decreases (2 builds for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
andy31415
reviewed
Apr 30, 2024
| @@ -40,4 +40,4 @@ chip_test_suite_using_nltest("data_model") { | |||
| "${chip_root}/src/transport/raw/tests:helpers", | |||
| "${nlunit_test_root}:nlunit-test", | |||
| ] | |||
| } | |||
| } | |||
There was a problem hiding this comment.
some of these files seem to have lost the trailing newline. Could we add it back?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are replacing NL unit tests with pigweed unit tests. I updated the tests in src/transport/tests/