Skip to content

Commit

Permalink
fix numpy build error on apple silicon (#11580)
Browse files Browse the repository at this point in the history
* fix numpy build error on apple silicon

* also fix document
  • Loading branch information
xylophone21 authored and pull[bot] committed Aug 10, 2022
1 parent 6e71e75 commit 1250587
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 2 deletions.
1 change: 1 addition & 0 deletions .github/.wordlist.txt
Original file line number Diff line number Diff line change
Expand Up @@ -435,6 +435,7 @@ hciconfig
hdlc
HKDF
hoc
homebrew
hostapd
hostname
href
Expand Down
8 changes: 8 additions & 0 deletions docs/guides/BUILDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ brew install openssl pkg-config
However, that does not expose the package to `pkg-config`. To fix that, one
needs to run something like the following:

Intel:

```
cd /usr/local/lib/pkgconfig
ln -s ../../Cellar/openssl@1.1/1.1.1g/lib/pkgconfig/* .
Expand All @@ -68,6 +70,12 @@ ln -s ../../Cellar/openssl@1.1/1.1.1g/lib/pkgconfig/* .
where `openssl@1.1/1.1.1g` may need to be replaced with the actual version of
OpenSSL installed by Brew.

Apple Silicon:

```
export PKG_CONFIG_PATH=$PKG_CONFIG_PATH:"/opt/homebrew/opt/openssl@3/lib/pkgconfig"
```

Note: If using MacPorts, `port install openssl` is sufficient to satisfy this
dependency.

Expand Down
2 changes: 1 addition & 1 deletion scripts/constraints.txt
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ numpy==1.20.3
# via pandas
packaging==20.9
# via west
pandas==1.2.4 ; platform_machine != "aarch64"
pandas==1.2.4 ; platform_machine != "aarch64" and platform_machine != "arm64"
# via -r requirements.txt
parso==0.8.2
# via jedi
Expand Down
2 changes: 1 addition & 1 deletion scripts/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ protobuf
anytree
cxxfilt
ghapi
pandas ; platform_machine != 'aarch64'
pandas ; platform_machine != 'aarch64' and platform_machine != 'arm64'

# scripts/build
click

0 comments on commit 1250587

Please sign in to comment.