Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chef] Fix basicvideoplayer device type #32091

Merged
merged 16 commits into from
Feb 16, 2024
Merged

[Chef] Fix basicvideoplayer device type #32091

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
ce21944
[Chef] Fix basicvideoplayer device type
erwinpan1 Feb 13, 2024
3ad1832
Rename Data() function to GetXxxxName() function
erwinpan1 Feb 13, 2024
a2fa83e
Use `StringBuilder` instead of std::stringstream
erwinpan1 Feb 13, 2024
5ae0816
Simplify codes without unnecessary return variables
erwinpan1 Feb 13, 2024
5e83fbd
Remove unused static_cast
erwinpan1 Feb 13, 2024
9446f0b
Simplify the keypad keycode handling
erwinpan1 Feb 13, 2024
a517281
Restyled by clang-format
restyled-commits Feb 13, 2024
314ab90
Enable Chef BasicVideoPlayer in cloud build
erwinpan1 Feb 13, 2024
75dbcb3
Remove unused GetInputName & GetOutputName function
erwinpan1 Feb 14, 2024
3b4a884
Using struct InputData&OuptutData to refine logics
erwinpan1 Feb 16, 2024
28c1705
Add break in default section
erwinpan1 Feb 16, 2024
0e60bae
Fix recordingFlag type and remove EMBER_ZCL_STATUS_SUCCESS
erwinpan1 Feb 16, 2024
a7c8235
Use std::numeric_limits<uint32_t>::max() as endTime default
erwinpan1 Feb 16, 2024
d7a9512
Remove some unneeded namespace declaration
erwinpan1 Feb 16, 2024
4c84c9b
Restyled by clang-format
restyled-commits Feb 16, 2024
4fa9b19
Restyled by clang-format
restyled-commits Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use StringBuilder instead of std::stringstream
  • Loading branch information
@erwinpan1
erwinpan1 committed Feb 16, 2024
commit a2fa83e18ddf185a443ee0c3214c3b22493e58f7
7 changes: 3 additions & 4 deletions examples/chef/common/clusters/channel/ChannelManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,14 +137,13 @@ CHIP_ERROR ChannelManager::HandleGetCurrentChannel(AttributeValueEncoder & aEnco

bool ChannelManager::isChannelMatched(const ChannelInfoType & channel, const chip::CharSpan & match)
{
std::stringstream ss;
ss << channel.majorNumber << "." << channel.minorNumber;
std::string number = ss.str();
StringBuilder<16> channelNum;
channelNum.AddFormat("%d.%d", channel.majorNumber, channel.minorNumber);

auto isMatch = [&match](const Optional<chip::CharSpan> & a) { return a.HasValue() && a.Value().data_equal(match); };

return isMatch(channel.name) || isMatch(channel.affiliateCallSign) || isMatch(channel.callSign) ||
match.data_equal(chip::CharSpan::fromCharString(number.c_str()));
match.data_equal(chip::CharSpan::fromCharString(channelNum.c_str()));
}

void ChannelManager::HandleChangeChannel(CommandResponseHelper<ChangeChannelResponseType> & helper, const CharSpan & match)
Expand Down