-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chef] Fix basicvideoplayer device type #32091
Merged
andy31415
merged 16 commits into
project-chip:master
from
erwinpan1:fix_basicvideoplayer_3
Feb 16, 2024
Merged
[Chef] Fix basicvideoplayer device type #32091
andy31415
merged 16 commits into
project-chip:master
from
erwinpan1:fix_basicvideoplayer_3
Feb 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mhazley and
mkardous-silabs
February 13, 2024 09:27
andy31415
reviewed
Feb 14, 2024
PR #32091: Size comparison from 598356c to 1218c75 Decreases (1 build for efr32)
Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
andy31415
reviewed
Feb 14, 2024
andy31415
reviewed
Feb 14, 2024
andy31415
reviewed
Feb 14, 2024
examples/chef/common/clusters/audio-output/AudioOutputManager.h
Outdated
Show resolved
Hide resolved
erwinpan1
force-pushed
the
fix_basicvideoplayer_3
branch
from
February 16, 2024 03:45
f38e842
to
cae9910
Compare
PR #32091: Size comparison from 8753139 to f14ff25 Full report (6 builds for cc32xx, mbed, qpg, stm32)
|
PR #32091: Size comparison from 8753139 to c01aa52 Decreases (2 builds for efr32)
Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
This was actually a squashed and rebased commit for PR project-chip#31987 since it mixed with unwanted commit from other people due to conflicts during rebasing
in Chef common/clusters/audio-output/AudioOutputManager.* and common/clusters/media-input/MediaInputManager.*
erwinpan1
force-pushed
the
fix_basicvideoplayer_3
branch
from
February 16, 2024 05:45
84a43c3
to
4fa9b19
Compare
andy31415
reviewed
Feb 16, 2024
andy31415
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was actually a squashed and rebased commit for PR #31987 since it mixed with unwanted commit from other people due to conflicts during rebasing