-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[ICD] Store UserActiveModeTriggerHint and instruction into IC… #30850
Merged
mergify
merged 3 commits into
project-chip:master
from
yunhanw-google:feature/revert_icd_hint
Dec 7, 2023
Merged
Revert "[ICD] Store UserActiveModeTriggerHint and instruction into IC… #30850
mergify
merged 3 commits into
project-chip:master
from
yunhanw-google:feature/revert_icd_hint
Dec 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #30850: Size comparison from f6ae79d to f086442 Full report (15 builds for cc13x4_26x4, cc32xx, k32w, mbed, qpg)
|
…D storage (project-chip#30770)" This reverts commit d809f32.
f086442
to
c48baa0
Compare
PR #30850: Size comparison from 1b11535 to c48baa0 Decreases (2 builds for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@yunhanw-google the summary just says |
mkardous-silabs
approved these changes
Dec 7, 2023
PR #30850: Size comparison from 6907eaa to b334b83 Decreases (2 builds for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30850: Size comparison from 6907eaa to c9654d4 Increases above 0.2%:
Increases (3 builds for k32w)
Decreases (2 builds for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d809f32.
Justification: #30842 (comment)