Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Storing active mode trigger hint information along with check-in keys does not make sense #30842

Closed
bzbarsky-apple opened this issue Dec 6, 2023 · 3 comments
Assignees
Labels
bug Something isn't working icd Intermittently Connected Devices needs triage

Comments

@bzbarsky-apple
Copy link
Contributor

Reproduction steps

#30770 added some code that assumes that the check-in recipient is the entity that will communicate with the user to let them know how to put the ICD into active mode if the user needs it in active mode "now".

This is not a valid assumption; these can generally be different entities.

What probably makes the most sense is making sure that during commissioning the hint information is communicated to the SDK client; they can then decide how and whether to store it and what entities should have it. But having it stored along with the check-in key on the check-in recipient does not really make sense.

Bug prevalence

Always

GitHub hash of the SDK that was being used

master

Platform

core

Platform Version(s)

No response

Anything else?

No response

@bzbarsky-apple bzbarsky-apple added bug Something isn't working icd Intermittently Connected Devices needs triage labels Dec 6, 2023
@github-actions github-actions bot removed the icd Intermittently Connected Devices label Dec 6, 2023
@yunhanw-google
Copy link
Contributor

yunhanw-google commented Dec 6, 2023

During commissioning, we get the hint information and tell application, then application needs to store them in some sort of storage in the entity that actual need to communicate with ICD device.

@yunhanw-google
Copy link
Contributor

reverted https://github.com/project-chip/connectedhomeip/pull/30850/files, and would go with callback which can pass hint information is communicated to the SDK client;

@bzbarsky-apple
Copy link
Contributor Author

Fixed by #30850

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working icd Intermittently Connected Devices needs triage
Projects
None yet
Development

No branches or pull requests

2 participants