Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move WiFi association processing to Rendezvous StateMachine #3019

Merged
merged 7 commits into from
Oct 3, 2020

Conversation

pan-apple
Copy link
Contributor

Problem

As part of Rendezvous state machine, the controller sends network (e.g. WiFi) credentials to the device. Currently, the controller propagates a Rendezvous message from device to the controller app (e.g. CHIP Tool iOS app), which triggers the app to collect the credentials from the user. The app constructs another Rendezvous message containing the credentials and sends it to the device.

This puts extra burden on the app to understand the Rendezvous message structure. Instead, the Rendezvous state machine should process the message, and call the delegate registered by app to collect the WiFi credentials. Also, the state machine should construct the required Rendezvous message and send it to the device.

Summary of Changes

  • Framework to construct and send WiFi association request from Rendezvous Session
  • split NetworkProvisioning from RendezvousSession state machine
  • split WiFi association from RendezvousSessionDelegate to its own delegate

Fixes #2818

@pan-apple pan-apple marked this pull request as ready for review October 2, 2020 17:53
@bzbarsky-apple bzbarsky-apple merged commit 0dfc4db into project-chip:master Oct 3, 2020
@pan-apple pan-apple deleted the issue2818 branch October 3, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use controller delegate callback for gathering the network credentials
6 participants