Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use controller delegate callback for gathering the network credentials #2818

Closed
pan-apple opened this issue Sep 24, 2020 · 1 comment · Fixed by #3019
Closed

Use controller delegate callback for gathering the network credentials #2818

pan-apple opened this issue Sep 24, 2020 · 1 comment · Fixed by #3019

Comments

@pan-apple
Copy link
Contributor

Problem

As part of Rendezvous state machine, the controller sends network (e.g. WiFi) credentials to the device. Currently, the controller propagates a Rendezvous message from device to the controller app (e.g. CHIP Tool iOS app), which triggers the app to collect the credentials from the user. The app constructs another Rendezvous message containing the credentials and sends it to the device.

This puts extra burden on app to understand the Rendezvous message structure. Instead, the Rendezvous state machine should process the message, and call the delegate registered by app to collect the WiFi credentials. Then the state machine should construct the required Rendezvous message and send it to the device.

Proposed Solution

Update Rendezvous state machine, delegate interface and application code.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.88. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant