Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commissioning: Fix fabric check stage and add test #28531

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

cecille
Copy link
Contributor

@cecille cecille commented Aug 4, 2023

also lots of plumbing to the python layers.

Issue: #28135

Note - issue will remain open after this PR goes in for one more fix.

also lots of plumbing to the python layers.
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

PR #28531: Size comparison from 1465733 to d1afbfb

Increases (7 builds for bl602, bl702, cc32xx, k32w, psoc6, telink)
platform target config section 1465733a d1afbfb change % change
bl602 lighting-app bl602+rpc .text 1088802 1088804 2 0.0
bl702 lighting-app bl702+rpc .debug_info 46329694 46329695 1 0.0
.text 1028578 1028580 2 0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19356328 19356329 1 0.0
k32w light k32w0+release (read only) 588828 588844 16 0.0
.text 588292 588308 16 0.0
psoc6 lock cy8ckit_062s2_43012 .debug_info 22216908 22216909 1 0.0
telink all-clusters-app tlsr9518adk80d text 728938 728940 2 0.0
lighting-app-factory-data tlsr9518adk80d (read/write) 993652 993660 8 0.0
text 693086 693090 4 0.0
Decreases (6 builds for esp32, nrfconnect, psoc6, telink)
platform target config section 1465733a d1afbfb change % change
esp32 all-clusters-app c3devkit (read only) 1149562 1149560 -2 -0.0
.flash.text 1149562 1149560 -2 -0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156628 1156612 -16 -0.0
text 810076 810072 -4 -0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 27156283 27156282 -1 -0.0
telink all-clusters-minimal-app tlsr9518adk80d text 669568 669566 -2 -0.0
contact-sensor-app tlsr9518adk80d (read/write) 875860 875852 -8 -0.0
text 590074 590070 -4 -0.0
lighting-app-rpc tlsr9518adk80d text 730508 730506 -2 -0.0
Full report (49 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 1465733a d1afbfb change % change
bl602 lighting-app bl602 (read/write) 1363826 1363826 0 0.0
.bss 73670 73670 0 0.0
.data 9552 9552 0 0.0
.text 1056870 1056870 0 0.0
bl602+rpc (read/write) 1411294 1411294 0 0.0
.bss 81710 81710 0 0.0
.data 9952 9952 0 0.0
.text 1088802 1088804 2 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1166743 1166743 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 41285 41285 0 0.0
.bss_psram 43488 43488 0 0.0
.comment 48 48 0 0.0
.data 3544 3544 0 0.0
.debug_abbrev 1566267 1566267 0 0.0
.debug_aranges 140336 140336 0 0.0
.debug_frame 516340 516340 0 0.0
.debug_info 41434748 41434748 0 0.0
.debug_line 5479108 5479108 0 0.0
.debug_loc 3563974 3563974 0 0.0
.debug_ranges 384608 384608 0 0.0
.debug_str 4011881 4011881 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106856 106856 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 589190 589190 0 0.0
.symtab 175552 175552 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
953894 953894 0 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1265647 1265647 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 49749 49749 0 0.0
.bss_psram 43488 43488 0 0.0
.comment 48 48 0 0.0
.data 4088 4088 0 0.0
.debug_abbrev 1743397 1743397 0 0.0
.debug_aranges 148880 148880 0 0.0
.debug_frame 545244 545244 0 0.0
.debug_info 46329694 46329695 1 0.0
.debug_line 5891643 5891643 0 0.0
.debug_loc 3770121 3770121 0 0.0
.debug_ranges 410360 410360 0 0.0
.debug_str 4431746 4431746 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121508 121508 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 652153 652153 0 0.0
.symtab 194480 194480 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1028578 1028580 2 0.0
bl702l lighting-app bl702l (read only) 278 278 0 0.0
(read/write) 1152652 1152652 0 0.0
.boot2 292 292 0 0.0
.bss 15988 15988 0 0.0
.bss_psram 77904 77904 0 0.0
.comment 48 48 0 0.0
.data 4512 4512 0 0.0
.debug_abbrev 1568486 1568486 0 0.0
.debug_aranges 134840 134840 0 0.0
.debug_frame 496028 496028 0 0.0
.debug_info 41435857 41435857 0 0.0
.debug_line 5394776 5394776 0 0.0
.debug_loc 3500142 3500142 0 0.0
.debug_ranges 389816 389816 0 0.0
.debug_str 4024350 4024350 0 0.0
.hbn 3244 3244 0 0.0
.hbn_noinit 308 308 0 0.0
.init 408 408 0 0.0
.init_array 144 144 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 100740 100740 0 0.0
.romdata 3224 3224 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 286 286 0 0.0
.stack 2048 2048 0 0.0
.strtab 589415 589415 0 0.0
.symtab 175120 175120 0 0.0
.tcm_data 692 692 0 0.0
.tcmcode 278 278 0 0.0
.text 0 0 0 0.0
942964 942964 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 615546 615546 0 0.0
(read/write) 207872 207872 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 201320 201320 0 0.0
.comment 206 206 0 0.0
.data 1432 1432 0 0.0
.debug_abbrev 959724 959724 0 0.0
.debug_aranges 109040 109040 0 0.0
.debug_frame 369924 369924 0 0.0
.debug_info 19356328 19356329 1 0.0
.debug_line 2811692 2811692 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1596540 1596540 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 100669 100669 0 0.0
.debug_str 3426584 3426584 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106282 106282 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 496184 496184 0 0.0
.symtab 293280 293280 0 0.0
.text 507144 507144 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 550055 550055 0 0.0
.app_xip_area 441305 441305 0 0.0
.bss 63776 63776 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 537039 537039 0 0.0
.app_xip_area 423241 423241 0 0.0
.bss 68800 68800 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 573743 573743 0 0.0
.app_xip_area 466073 466073 0 0.0
.bss 62768 62768 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 546431 546431 0 0.0
.app_xip_area 435809 435809 0 0.0
.bss 65648 65648 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1010888 1010888 0 0.0
.bss 183556 183556 0 0.0
.data 2640 2640 0 0.0
.text 824672 824672 0 0.0
BRD4187C (read/write) 1035264 1035264 0 0.0
.bss 163148 163148 0 0.0
.data 3236 3236 0 0.0
.text 868860 868860 0 0.0
lock-app BRD4161A+wf200 (read/write) 1087396 1087396 0 0.0
.bss 177612 177612 0 0.0
.data 2660 2660 0 0.0
.text 907104 907104 0 0.0
window-app BRD4187C (read/write) 1106852 1106852 0 0.0
.bss 146188 146188 0 0.0
.data 3120 3120 0 0.0
.text 957524 957524 0 0.0
esp32 all-clusters-app c3devkit (read only) 1149562 1149560 -2 -0.0
(read/write) 1701996 1701996 0 0.0
.dram0.bss 79088 79088 0 0.0
.dram0.data 13076 13076 0 0.0
.flash.rodata 266088 266088 0 0.0
.flash.text 1149562 1149560 -2 -0.0
.iram0.text 75262 75262 0 0.0
m5stack (read only) 1191607 1191607 0 0.0
(read/write) 550206 550206 0 0.0
.dram0.bss 85464 85464 0 0.0
.dram0.data 34020 34020 0 0.0
.flash.rodata 297080 297080 0 0.0
.flash.text 1186223 1186223 0 0.0
.iram0.text 123311 123311 0 0.0
k32w contact k32w0+release (read only) 590140 590140 0 0.0
(read/write) 91312 91312 0 0.0
.bss 67372 67372 0 0.0
.data 2116 2116 0 0.0
.text 589604 589604 0 0.0
light k32w0+release (read only) 588828 588844 16 0.0
(read/write) 90960 90960 0 0.0
.bss 67020 67020 0 0.0
.data 2104 2104 0 0.0
.text 588292 588308 16 0.0
lock k32w0+release (read only) 561396 561396 0 0.0
(read/write) 88792 88792 0 0.0
.bss 64908 64908 0 0.0
.data 2048 2048 0 0.0
.text 560860 560860 0 0.0
linux chip-tool-ipv6only arm64 (read only) 16981524 16981524 0 0.0
(read/write) 1122712 1122712 0 0.0
.bss 103064 103064 0 0.0
.data 4392 4392 0 0.0
.data.rel.ro 986400 986400 0 0.0
.dynamic 512 512 0 0.0
.got 23360 23360 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 827632 827632 0 0.0
.text 13914072 13914072 0 0.0
thermostat-no-ble arm64 (read only) 4450052 4450052 0 0.0
(read/write) 244168 244168 0 0.0
.bss 122552 122552 0 0.0
.data 2864 2864 0 0.0
.data.rel.ro 102296 102296 0 0.0
.dynamic 512 512 0 0.0
.got 11976 11976 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 161996 161996 0 0.0
.text 3949880 3949880 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2521616 2521616 0 0.0
.bss 220040 220040 0 0.0
.data 5120 5120 0 0.0
.text 1484300 1484300 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1218700 1218700 0 0.0
bss 154660 154660 0 0.0
rodata 141392 141392 0 0.0
text 843632 843632 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1337364 1337364 0 0.0
bss 140118 140118 0 0.0
rodata 135484 135484 0 0.0
text 771080 771080 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1156628 1156612 -16 -0.0
bss 154839 154839 0 0.0
rodata 112776 112776 0 0.0
text 810076 810072 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 837568 837568 0 0.0
(read/write) 1766900 1766900 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 193252 193252 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2520 2520 0 0.0
.debug_abbrev 1378296 1378296 0 0.0
.debug_aranges 143888 143888 0 0.0
.debug_frame 479364 479364 0 0.0
.debug_info 30059977 30059977 0 0.0
.debug_line 4142027 4142027 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2247923 2247923 0 0.0
.debug_rnglists 142436 142436 0 0.0
.debug_str 4119257 4119257 0 0.0
.heap 837568 837568 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 802559 802559 0 0.0
.symtab 500128 500128 0 0.0
.text 1562740 1562740 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 839520 839520 0 0.0
(read/write) 1674348 1674348 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 191364 191364 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1283914 1283914 0 0.0
.debug_aranges 137192 137192 0 0.0
.debug_frame 462452 462452 0 0.0
.debug_info 27156283 27156282 -1 -0.0
.debug_line 3958916 3958916 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2148811 2148811 0 0.0
.debug_rnglists 135557 135557 0 0.0
.debug_str 3978806 3978806 0 0.0
.heap 839520 839520 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 713193 713193 0 0.0
.symtab 465776 465776 0 0.0
.text 1472140 1472140 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 845784 845784 0 0.0
(read/write) 1605828 1605828 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185212 185212 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2344 2344 0 0.0
.debug_abbrev 1124168 1124168 0 0.0
.debug_aranges 127320 127320 0 0.0
.debug_frame 425592 425592 0 0.0
.debug_info 22303095 22303095 0 0.0
.debug_line 3523451 3523451 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 1985883 1985883 0 0.0
.debug_rnglists 125337 125337 0 0.0
.debug_str 3786878 3786878 0 0.0
.heap 845784 845784 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 634185 634185 0 0.0
.symtab 430416 430416 0 0.0
.text 1409884 1409884 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 818264 818264 0 0.0
(read/write) 1639220 1639220 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 212716 212716 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2360 2360 0 0.0
.debug_abbrev 1115833 1115833 0 0.0
.debug_aranges 126232 126232 0 0.0
.debug_frame 421636 421636 0 0.0
.debug_info 22216908 22216909 1 0.0
.debug_line 3479623 3479623 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 1966212 1966212 0 0.0
.debug_rnglists 123525 123525 0 0.0
.debug_str 3751416 3751416 0 0.0
.heap 818264 818264 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 608085 608085 0 0.0
.symtab 422544 422544 0 0.0
.text 1415756 1415756 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1177620 1177620 0 0.0
.bss 101232 101232 0 0.0
.data 736 736 0 0.0
.text 624464 624464 0 0.0
lock-app qpg6105+debug (read/write) 1134668 1134668 0 0.0
.bss 95952 95952 0 0.0
.data 740 740 0 0.0
.text 581508 581508 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1070172 1070172 0 0.0
bss 107356 107356 0 0.0
text 728938 728940 2 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 976632 976632 0 0.0
bss 105332 105332 0 0.0
text 669568 669566 -2 -0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 943944 943944 0 0.0
bss 109716 109716 0 0.0
text 646722 646722 0 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 875860 875852 -8 -0.0
bss 98896 98896 0 0.0
text 590074 590070 -4 -0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 904736 904736 0 0.0
bss 99488 99488 0 0.0
text 615702 615702 0 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 982280 982280 0 0.0
bss 107572 107572 0 0.0
text 685572 685572 0 0.0
lighting-app-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 993652 993660 8 0.0
bss 111820 111820 0 0.0
text 693086 693090 4 0.0
lighting-app-rpc tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1051812 1051812 0 0.0
bss 109144 109144 0 0.0
text 730508 730506 -2 -0.0
lighting-app-shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1083148 1083148 0 0.0
bss 120220 120220 0 0.0
text 750612 750612 0 0.0
lock-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 933328 933328 0 0.0
bss 99616 99616 0 0.0
text 620762 620762 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 898480 898480 0 0.0
bss 100196 100196 0 0.0
text 611956 611956 0 0.0
pump-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 881348 881348 0 0.0
bss 99028 99028 0 0.0
text 595764 595764 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 868504 868504 0 0.0
bss 98828 98828 0 0.0
text 586202 586202 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 744228 744228 0 0.0
bss 97256 97256 0 0.0
text 478644 478644 0 0.0
smoke_co_alarm-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 878336 878336 0 0.0
bss 99008 99008 0 0.0
text 593530 593530 0 0.0
temperature-measurement-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 864628 864628 0 0.0
bss 98736 98736 0 0.0
text 581806 581806 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 910572 910572 0 0.0
bss 99280 99280 0 0.0
text 621248 621248 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 906328 906328 0 0.0
bss 99616 99616 0 0.0
text 616520 616520 0 0.0

@mergify mergify bot merged commit 6a891ac into project-chip:master Aug 16, 2023
@cecille cecille deleted the time_sync_commissioning_fix_2 branch September 28, 2023 14:34
HunsupJung pushed a commit to HunsupJung/connectedhomeip that referenced this pull request Oct 23, 2023
* Fix fabric check stage and add test

also lots of plumbing to the python layers.

* Missed one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controller examples platform review - approved time sync Implementation of the Time Synchronization cluster
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants