-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commissioning: Fix fabric check stage and add test #28531
Merged
mergify
merged 2 commits into
project-chip:master
from
cecille:time_sync_commissioning_fix_2
Aug 16, 2023
Merged
Commissioning: Fix fabric check stage and add test #28531
mergify
merged 2 commits into
project-chip:master
from
cecille:time_sync_commissioning_fix_2
Aug 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also lots of plumbing to the python layers.
PR #28531: Size comparison from 1465733 to d1afbfb Increases (7 builds for bl602, bl702, cc32xx, k32w, psoc6, telink)
Decreases (6 builds for esp32, nrfconnect, psoc6, telink)
Full report (49 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Aug 5, 2023
jtung-apple
approved these changes
Aug 16, 2023
jmartinez-silabs
approved these changes
Aug 16, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Fix fabric check stage and add test also lots of plumbing to the python layers. * Missed one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
controller
examples
platform
review - approved
time sync
Implementation of the Time Synchronization cluster
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also lots of plumbing to the python layers.
Issue: #28135
Note - issue will remain open after this PR goes in for one more fix.