Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.2] Address review comments on commissioning time sync code #28135

Open
2 of 3 tasks
bzbarsky-apple opened this issue Jul 20, 2023 · 2 comments
Open
2 of 3 tasks

[1.2] Address review comments on commissioning time sync code #28135

bzbarsky-apple opened this issue Jul 20, 2023 · 2 comments
Assignees
@cecille
Labels
bug Something isn't working needs triage security v1.2
Milestone
1.2

Comments

@bzbarsky-apple
Copy link
Contributor

bzbarsky-apple commented Jul 20, 2023 •
edited by cecille
Loading

Reproduction steps

See #27812 (review)

There are a few issues:

  • I think the kCheckForMatchingFabric bits got broken
  • I don't think TrustedTimeSource is being set correctly. [Being addressed in https://github.com/Timesync commissioner: Fix TrustedTimeSource. #28284 ]
  • The ComissioningParameters handling has use-after-free issues.

Bug prevalence

always

GitHub hash of the SDK that was being used

ac3535b

Platform

core

Platform Version(s)

No response

Type

Security Issue

Anything else?

No response
@bzbarsky-apple bzbarsky-apple added bug Something isn't working needs triage labels Jul 20, 2023
@cecille cecille added the time sync Implementation of the Time Synchronization cluster label Jul 20, 2023
@cecille cecille mentioned this issue Jul 26, 2023
Merged
@github-actions github-actions bot removed the time sync Implementation of the Time Synchronization cluster label Jul 26, 2023
@cecille cecille mentioned this issue Aug 4, 2023
Merged
@bzbarsky-apple
Copy link
Contributor Author

Fixed in #29908

@bzbarsky-apple
Copy link
Contributor Author

No, I was wrong. mDefaultNTP is still broken.

@woody-apple woody-apple added this to the 1.2 milestone Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cecille cecille

Labels
bug Something isn't working needs triage security v1.2
Projects
[Feature] Time Sync
Status: In Progress
Milestone
1.2
Development

No branches or pull requests
3 participants
@cecille @woody-apple @bzbarsky-apple