Commissioning: Implement time sync requirements #27812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests added in TestCommissioningTimeSync.py
Test: Ran TestCommissioningTimeSync.py against all-clusters
(has a time cluster) and lock (no time cluster)
commissioned all-clusters and lock with chip-tool
|
PR #27812: Size comparison from e532537 to 136b96b Increases above 0.2%:
Increases (4 builds for k32w, linux, psoc6)
Decreases (4 builds for bl602, bl702, cc32xx, psoc6)
Full report (29 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
|
PR #27812: Size comparison from e532537 to 5610d98 Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
|
PR #27812: Size comparison from e532537 to 2889a95 Increases above 0.2%:
Increases (2 builds for k32w, linux)
Decreases (4 builds for bl602, cc32xx, nrfconnect, qpg)
Full report (17 builds for bl602, bl702, bl702l, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
|
PR #27812: Size comparison from e532537 to a6a5b42 Increases above 0.2%:
Increases (56 builds for bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (11 builds for bl602, bl702, bl702l, efr32, linux, psoc6)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
added
time sync
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
carol-apple,
chrisdecenzo and
chshu
pullapprove
bot
requested review from
msandstedt,
nivi-apple,
p0fi,
plauric,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yufengwangca
woody-apple
approved these changes
Jul 11, 2023
|
PR #27812: Size comparison from badc0c8 to 50da6b8 Increases above 0.2%:
Increases (11 builds for bl602, bl702l, linux, telink)
Decreases (11 builds for bl602, bl702, esp32, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
| SendCommissioningReadRequest(proxy, timeout, readPaths, 9); | ||
| } | ||
| break; | ||
| case CommissioningStage::kCheckForMatchingFabric: { | ||
| // Read the current fabrics | ||
| if (params.GetCheckForMatchingFabric()) |
There was a problem hiding this comment.
Is this test backwards?
| return; | ||
| } | ||
| TimeSynchronization::Commands::SetTrustedTimeSource::Type request; | ||
| request.trustedTimeSource.SetNull(); |
There was a problem hiding this comment.
Shouldn't this use params.GetTrustedTimeSource() somehow? I am surprised the tests did not catch this....
| @@ -453,6 +518,11 @@ class CommissioningParameters | |||
| Optional<uint16_t> mFailsafeTimerSeconds; | |||
| Optional<uint16_t> mCASEFailsafeTimerSeconds; | |||
| Optional<app::Clusters::GeneralCommissioning::RegulatoryLocationTypeEnum> mDeviceRegulatoryLocation; | |||
| Optional<app::DataModel::List<app::Clusters::TimeSynchronization::Structs::TimeZoneStruct::Type>> mTimeZone; | |||
There was a problem hiding this comment.
Don't these need to get added to ClearExternalBufferDependentValues?
There was a problem hiding this comment.
AutoCommissioner::SetCommissioningParameters needs to copy the new buffer things, no? Otherwise consumers who pass in a CommissioningParameters that we are then just grabbing raw pointers from have no way to control lifetime and we get use-after-free.
3 tasks
erwinpan1
pushed a commit
to erwinpan1/connectedhomeip
that referenced
this pull request
Jul 21, 2023
* Commissioning: Implement time sync requirements
Tests added in TestCommissioningTimeSync.py
Test: Ran TestCommissioningTimeSync.py against all-clusters
(has a time cluster) and lock (no time cluster)
commissioned all-clusters and lock with chip-tool
* Add missing include
* Note to self: commit ALL changes before uploading
* Restyled by isort
* Fix CGEN test for commissioning.
* Read time sync in initial read, fabrics later
Also fix tests
* Remove extra log
* Add new pairing delegate call, fix tv-app
---------
Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests added in TestCommissioningTimeSync.py
Test: Ran TestCommissioningTimeSync.py against all-clusters
(has a time cluster) and lock (no time cluster)
commissioned all-clusters and lock with chip-tool
NOTE: uses the ordering in spec issue https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/7291
Fixes: #27342