Make main build python env not depend on all platform build requirements. #27267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…selectively add more things
… various platforms
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi and
electrocucaracha
pullapprove
bot
requested review from
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
…ntire .environment at some point
|
PR #27267: Size comparison from 5efdd31 to 4da90e7 Increases (7 builds for cyw30739, nrfconnect, telink)
Decreases (9 builds for bl602, bl702, esp32, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Damian-Nordic
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build environment will create sub-environments for compilation.
This updates the build scripts to only depend on
requirements.build.txtand any additional packages can be installed in the main build env without pulling them into sub_environments (like the ones built for test).This also allows bootstrap/activate to decide what requirements to install. We default to "all" for backwards compatibility, however expect people to be able to do
source bootstrap.sh -p esp32,telinkor similar in the future, for fewer packages getting instaled.Changes:
requirements.txtrequirements.build.txt-p/--platformargument for a comma separated list of platforms to also pip-install$PW_ENVIRONMENT_ROOTto allow re-bootstrap without switching to .envionment. If found the removal of PW_ENVIRONMENT_ROOT to be an easy footgun when working in different docker/podman images with the same source code root.$CIPD_CACHE_DIRso that we have the option to cache this instead of the full python install (i.e. maybe faster bootstrap but allowing for separate python installs for every separate CI build)NOTE: since we share a bootstrap cache, we cannot currently make our CI workflows select the platform and we seem to still need "all". This only is expected to speed up internal sub-enviroments created during builds (e.g. test or other python script execution)