Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Bootstrap script fails to run in zsh #27338

Closed
hare-siterwell opened this issue Jun 20, 2023 · 6 comments · Fixed by #27347
Closed

[BUG] Bootstrap script fails to run in zsh #27338

hare-siterwell opened this issue Jun 20, 2023 · 6 comments · Fixed by #27347
Assignees

Comments

@hare-siterwell
Copy link
Contributor

Reproduction steps

  1. Open zsh shell.
  2. After executing . ./scripts/bootstrap.sh, return _install_additional_pip_requirements:read:19: bad option: -a.

Bug prevalence

always

GitHub hash of the SDK that was being used

9a5b909

Platform

other

Platform Version(s)

No response

Anything else?

No response

@bzbarsky-apple
Copy link
Contributor

Presumably fallout from #27267 ?

@andy31415
Copy link
Contributor

I never tried to use zsh ... I had assumed we just use bash everywhere as our only supported shell.

@bzbarsky-apple
Copy link
Contributor

zsh is the default shell on any somewhat recent mac. So if we expect people to be able to bootstrap on Mac, it probably needs to work in zsh or give a much clearer and earlier error.

https://stackoverflow.com/questions/36453146/why-does-read-a-fail-in-zsh seems relevant....

@bzbarsky-apple
Copy link
Contributor

The silly part is that what needs to be sourced is the activate part, not the bootstrap part. So maybe we could move the bootstrap bits out into a script that does actually run via bash?

@andy31415
Copy link
Contributor

ZSH should also have a way to say "split out comma separated string". Looking to see what we can do.

@bzbarsky-apple
Copy link
Contributor

See the stackoverflow above. You can read -r -A in zsh...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants