addressed PR comments

src/app/clusters/time-synchronization-server/TimeSyncManager.cpp

@@ -20,36 +20,25 @@
 
 using namespace chip::app::Clusters::TimeSynchronization;
 
-void TimeSyncManager::HandleTimeZoneChanged(TimeZoneList timeZoneList)
+void TimeSyncManager::HandleTimeZoneChanged(const TimeZoneList timeZoneList)
 {
-    // do nothing
-    ChipLogProgress(Zcl, "%s", __FUNCTION__);
+    // placeholder implementation
 }
 
-CHIP_ERROR TimeSyncManager::HandleDSTOffsetLookup()
+bool TimeSyncManager::HandleUpdateDSTOffset(chip::CharSpan name)
 {
-    ChipLogProgress(Zcl, "%s", __FUNCTION__);
-    return CHIP_NO_ERROR;
-}
-
-bool TimeSyncManager::HandleDSTOffsetAvailable(chip::CharSpan name)
-{
-    ChipLogProgress(Zcl, "%s", __FUNCTION__);
+    // placeholder implementation
     return false;
 }
 
-CHIP_ERROR TimeSyncManager::HandleGetDSTOffset()
-{
-    ChipLogProgress(Zcl, "%s", __FUNCTION__);
-    return CHIP_NO_ERROR;
-}
-
-bool TimeSyncManager::isNTPAddressValid(chip::CharSpan ntp)
+bool TimeSyncManager::IsNTPAddressValid(chip::CharSpan ntp)
 {
+    // placeholder implementation
     return true;
 }
 
-bool TimeSyncManager::isNTPAddressDomain(chip::CharSpan ntp)
+bool TimeSyncManager::IsNTPAddressDomain(chip::CharSpan ntp)
 {
+    // placeholder implementation
     return false;
 }

src/app/clusters/time-synchronization-server/TimeSyncManager.h

@@ -35,12 +35,10 @@ class TimeSyncManager : public Delegate
     using TimeZoneList = DataModel::List<chip::app::Clusters::TimeSynchronization::Structs::TimeZoneStruct::Type>;
 
     TimeSyncManager() : Delegate(){};
-    void HandleTimeZoneChanged(TimeZoneList timeZoneList) override;
-    CHIP_ERROR HandleDSTOffsetLookup() override;
-    bool HandleDSTOffsetAvailable(chip::CharSpan name) override;
-    CHIP_ERROR HandleGetDSTOffset() override;
-    bool isNTPAddressValid(chip::CharSpan ntp) override;
-    bool isNTPAddressDomain(chip::CharSpan ntp) override;
+    void HandleTimeZoneChanged(const TimeZoneList timeZoneList) override;
+    bool HandleUpdateDSTOffset(chip::CharSpan name) override;
+    bool IsNTPAddressValid(chip::CharSpan ntp) override;
+    bool IsNTPAddressDomain(chip::CharSpan ntp) override;
 };
 
 } // namespace TimeSynchronization

src/app/clusters/time-synchronization-server/time-synchronization-delegate.h

@@ -25,7 +25,6 @@ namespace app {
 namespace Clusters {
 namespace TimeSynchronization {
 
-using namespace chip::app::Clusters::TimeSynchronization;
 using TimeZoneList = DataModel::List<chip::app::Clusters::TimeSynchronization::Structs::TimeZoneStruct::Type>;
 
 /** @brief
@@ -41,12 +40,30 @@ class Delegate
         return success ? (map & to_underlying(feature)) : false;
     }
 
-    virtual void HandleTimeZoneChanged(TimeZoneList timeZoneList) = 0;
-    virtual CHIP_ERROR HandleDSTOffsetLookup()                    = 0;
-    virtual bool HandleDSTOffsetAvailable(chip::CharSpan name)    = 0;
-    virtual CHIP_ERROR HandleGetDSTOffset()                       = 0;
-    virtual bool isNTPAddressValid(chip::CharSpan ntp)            = 0;
-    virtual bool isNTPAddressDomain(chip::CharSpan ntp)           = 0;
+    /**
+     * @brief Notifies through the delegate that time zone has changed.
+     *
+     * @param timeZoneList new time zone list
+     */
+    virtual void HandleTimeZoneChanged(const TimeZoneList timeZoneList) = 0;
+    /**
+     * @brief Give the delegate the chance to populate DNSOffset based on active time zone.
+     *
+     * @param name name of active time zone
+     */
+    virtual bool HandleUpdateDSTOffset(const chip::CharSpan name) = 0;
+    /**
+     * @brief Validate NTP address
+     *
+     * @param ntp NTP address
+     */
+    virtual bool IsNTPAddressValid(const chip::CharSpan ntp) = 0;
+    /**
+     * @brief Check if NTP address is domain
+     *
+     * @param ntp NTP address
+     */
+    virtual bool IsNTPAddressDomain(const chip::CharSpan ntp) = 0;
 
     virtual ~Delegate() = default;
 };