Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time synchronization cluster #26082

Commits on May 5, 2023

  1. update time sync cluster XML based on updated spec

    added attribute access interface handled attributes
    
    GNSS
    
    Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
    
    TrustedTimeSource is optional with TSC feature
    
    Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
    
    SetUTCTime
    
    Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
    
    SetTrustedTimeSource is optional
    
    Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
    
    UTCTime
    
    Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
    
    TimeZoneDatabase default 2 (None)
    MissingTrustedTimeSource is optional
    
    regenerate code
    
    update default values
    fessehaeve committed May 5, 2023
    Configuration menu
    Copy the full SHA
    c843519 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4c54583 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0691f54 View commit details
    Browse the repository at this point in the history
  4. GNSS

    Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
    fessehaeve and bzbarsky-apple committed May 5, 2023
    Configuration menu
    Copy the full SHA
    fdd9a4c View commit details
    Browse the repository at this point in the history
  5. TrustedTimeSource is optional with TSC feature

    Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
    fessehaeve and bzbarsky-apple committed May 5, 2023
    Configuration menu
    Copy the full SHA
    c311d21 View commit details
    Browse the repository at this point in the history
  6. SetUTCTime

    Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
    fessehaeve and bzbarsky-apple committed May 5, 2023
    Configuration menu
    Copy the full SHA
    182aecf View commit details
    Browse the repository at this point in the history
  7. SetTrustedTimeSource is optional

    Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
    fessehaeve and bzbarsky-apple committed May 5, 2023
    Configuration menu
    Copy the full SHA
    808d7b3 View commit details
    Browse the repository at this point in the history
  8. UTCTime

    Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
    fessehaeve and bzbarsky-apple committed May 5, 2023
    Configuration menu
    Copy the full SHA
    e1b4578 View commit details
    Browse the repository at this point in the history
  9. TimeZoneDatabase default 2 (None)

    MissingTrustedTimeSource is optional
    fessehaeve committed May 5, 2023
    Configuration menu
    Copy the full SHA
    652bcb0 View commit details
    Browse the repository at this point in the history
  10. regenerate code

    fessehaeve committed May 5, 2023
    Configuration menu
    Copy the full SHA
    80ccd23 View commit details
    Browse the repository at this point in the history
  11. update default values

    fessehaeve committed May 5, 2023
    Configuration menu
    Copy the full SHA
    844783e View commit details
    Browse the repository at this point in the history
  12. updated time-synchronization cluster definition based on PR project-c…

    …hip#6352
    
    add Time Synchronization cluster in all-clusters-app, controller-app and light-switch-app zap and regenerate all
    
    remove constraint from a single element attribute
    
    first code commit
    
    initialize timezone and trustedtimesource to 0 and null
    
    added statuscode and changed to fabricIndex
    
    regenerate zap
    
    use time sync server code
    
    set default zap setting to external for complex time sync attributes
    
    add endpoint to trustedtimesourcestruct and set command for it
    
    regenerate
    
    using updated trustedtimesourcestruct
    
    update time sync xml definition
    
    update zap files
    
    regenerate
    
    added persistent data provider for time sync cluster
    
    added new commands based on PR project-chip#6353
    
    added test template for TimeSyncDataProvider
    
    changed command arguments to list type
    
    regenerate
    
    update SetTrustedTimeSource definition
    
    regenerate
    
    use consistent data types of attributes
    
    user CHIP_CONFIG to set size of lists
    
    clean up read handler
    
    adde TSC feature and change attribute ids
    
    include time sync related resource for build
    
    regenerate after changing attribute ids and adding time sync client feature
    
    reorganize code and implement defaultNTP handlers
    
    handle span data the right way
    improved overall implementation
    
    change default time zone list size to 1
    
    made settrustedtimesource command to be fabric scoped
    
    update time sync cluster definition based on latest PR merges
    
    regenerate and changes related to attribute names and access
    
    setdefaultntp parameter is nullable
    
    implemented setdefaultntp
    
    changed the id of settimezoneresponse command to the current in spec
    
    removed curly brace that sneaked in to previous commits
    
    ValidUntil of DSTOffsetStruct is nullable
    
    added basic rules of operation in comment/psuedo-code
    
    added DSTOffsetActive predicate for DSTStatus event
    
    fixed clang compiler errors
    
    added skeleton delegate implementation for time sync
    
    use delegate placeholder and implemented events
    
    clean up usage of namespaces
    
    seems like unused code
    
    skleton verifiers for NTP address
    
    moved init from header
    
    removed conflicting generated files
    
    regenerate all
    
    enum now starts at 0, name field is optional in timezonestatus event
    
    force external storage for UTCTime and LocalTime attributes
    
    moved time sync cluster code to cpp file
    added mechanism to track real size of list data
    removed custom encoder for TimeZone attribute
    changed TimeZone list size to 2 for better testing behavior
    addressed multiple PR comments
    
    improved defaultNTP implementation and storage usage
    cleaned up return usage
    
    changed time logic to be able to set older time but not old than default LastKnownTime
    
    ignore attribute storage values for sizes with F quality
    
    resolve rebase conflicts
    
    some random generated code that needs to be there
    
    use consistent data types
    
    changes based on CI failures
    
    TrustedTimeSource is not a list
    
    fixed response behavior of setttimezone command
    
    missed generated code
    fessehaeve committed May 5, 2023
    Configuration menu
    Copy the full SHA
    1367a2f View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    df786be View commit details
    Browse the repository at this point in the history
  14. code improvements

    fessehaeve committed May 5, 2023
    Configuration menu
    Copy the full SHA
    7d089a0 View commit details
    Browse the repository at this point in the history
  15. truncate span size to actual data when retreiving defaultNTP

    wrote test for time sync persistent storage
    fessehaeve committed May 5, 2023
    Configuration menu
    Copy the full SHA
    48633d1 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2023

  1. bring back section removed by rebase

    Signed-off-by: Fesseha <fesseha@evehome.com>
    fessehaeve committed May 8, 2023
    Configuration menu
    Copy the full SHA
    8c59a50 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'pull-request/time-synchronization-xml' into pull-reques…

    …t/time-synchronization-cluster
    fessehaeve committed May 8, 2023
    Configuration menu
    Copy the full SHA
    2b87054 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a843dd5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4b19983 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. Configuration menu
    Copy the full SHA
    f0c5943 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    19cf4f7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    113a7cf View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. Configuration menu
    Copy the full SHA
    1c57991 View commit details
    Browse the repository at this point in the history
  2. improved time zone and dst offset attributes validation,

    skeleton functions for validating and purging time zone and dst offset,
    made dst offset list size to 2 for testing purposes
    fessehaeve committed May 11, 2023
    Configuration menu
    Copy the full SHA
    6a856d4 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. Configuration menu
    Copy the full SHA
    a01af6d View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. Configuration menu
    Copy the full SHA
    c410517 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2023

  1. Configuration menu
    Copy the full SHA
    627d921 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. Configuration menu
    Copy the full SHA
    eb26f18 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f799c32 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. Configuration menu
    Copy the full SHA
    5d12183 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3c27a07 View commit details
    Browse the repository at this point in the history
  3. update feature map attribute name

    validate offset in timezone
    bring back merge removed code in CHIPConfig.h
    fessehaeve committed May 24, 2023
    Configuration menu
    Copy the full SHA
    561a32d View commit details
    Browse the repository at this point in the history
  4. use static_cast instead

    fessehaeve committed May 24, 2023
    Configuration menu
    Copy the full SHA
    f166702 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    80e0e58 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    31a6ab7 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. Configuration menu
    Copy the full SHA
    db7e060 View commit details
    Browse the repository at this point in the history
  2. run restyler

    fessehaeve committed May 25, 2023
    Configuration menu
    Copy the full SHA
    6b580c7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ff4c60f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6133fe0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d7468e3 View commit details
    Browse the repository at this point in the history
  6. update yaml test and generate code

    fix type error
    fessehaeve committed May 25, 2023
    Configuration menu
    Copy the full SHA
    06823c0 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. use TLV size estimator

    fessehaeve committed May 26, 2023
    Configuration menu
    Copy the full SHA
    69065c8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    462cb33 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. Configuration menu
    Copy the full SHA
    ae9b95e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    092843a View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. Update src/app/clusters/time-synchronization-server/TimeSyncDataProvi…

    …der.cpp
    
    Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
    fessehaeve and bzbarsky-apple authored Jun 1, 2023
    Configuration menu
    Copy the full SHA
    96121b9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    df139ef View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. address PR comments

    Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
    fessehaeve and bzbarsky-apple committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    e2a2f10 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. Merge remote-tracking branch 'origin/master' into pull-request/time-s…

    …ynchronization-cluster
    
    # Conflicts:
    #	src/app/chip_data_model.gni
    #	src/app/zap_cluster_list.json
    #	src/controller/data_model/controller-clusters.zap
    #	src/controller/java/zap-generated/chip/devicecontroller/ChipClusters.java
    #	src/controller/java/zap-generated/chip/devicecontroller/ClusterInfoMapping.java
    fessehaeve committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    72ade1c View commit details
    Browse the repository at this point in the history
  2. typo changes

    fessehaeve committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    664766e View commit details
    Browse the repository at this point in the history
  3. Revert parts of "address PR comments"

    This reverts commit e2a2f10.
    fessehaeve committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    8dceb9f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1aa9151 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    43464d7 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. addressed PR comments

    fessehaeve committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    ed54358 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Configuration menu
    Copy the full SHA
    726626e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b3d81b7 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. changed time zone stuct, improved tests, fixed local time calculation…

    … overflow and more PR comments fix
    fessehaeve committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    5446531 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. restyle, use DSTOffsetobj with size element, improved error response …

    …in few instances, and some more minor tweaks
    fessehaeve committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    1c6175d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a00499d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f6a6b92 View commit details
    Browse the repository at this point in the history
  4. update dstoffset NL test

    fessehaeve committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    90eefcc View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. cleaned up for loop indexes, catch dst validUntil expiring, nullable …

    …localtime, generate dst table empty event correctly
    fessehaeve committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    a2c6169 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. Configuration menu
    Copy the full SHA
    aca64c6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f3b4600 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2023

  1. validate NTP addresses in default delegate and few more improvements

    Co-authored-by: C Freeman <cecille@google.com>
    fessehaeve and cecille committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    5b1a0d7 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2023

  1. Configuration menu
    Copy the full SHA
    12e9232 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    98db550 View commit details
    Browse the repository at this point in the history
  3. apply restyle patch

    fessehaeve committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    1579179 View commit details
    Browse the repository at this point in the history
  4. another restyle patch

    fessehaeve committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    ab106b8 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. Configuration menu
    Copy the full SHA
    87f9098 View commit details
    Browse the repository at this point in the history
  2. apply restyler patch

    fessehaeve committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    c0d7ad7 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. Configuration menu
    Copy the full SHA
    80afe93 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    23dd47e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e57c01e View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2023

  1. Configuration menu
    Copy the full SHA
    abb7a80 View commit details
    Browse the repository at this point in the history