Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Add the TLVReader/TLVWriter lib for generic IM write/invoke APIs #25411

Merged
merged 2 commits into from
Mar 2, 2023
Merged

[Java] Add the TLVReader/TLVWriter lib for generic IM write/invoke APIs #25411

merged 2 commits into from
Mar 2, 2023

Conversation

yufengwangca
Copy link
Contributor

For generic IM write/invoke in Java controller side, we would use TLV blob as input argument, we need ways to encode/decode the tlv blob, we prefer using kotlin to create this tlv library.

Fix: #25386

@yufengwangca yufengwangca changed the title [Java] Add tlv writer and reader lib [Java] Add the TLVReader/TLVWriter lib for generic IM write/invoke APIs Mar 1, 2023
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

PR #25411: Size comparison from e434c6a to ac60da0

Increases (1 build for qpg)
platform target config section e434c6a ac60da0 change % change
qpg lighting-app qpg6105+debug (read/write) 1151676 1151684 8 0.0
.text 598772 598780 8 0.0
Decreases (1 build for cc32xx)
platform target config section e434c6a ac60da0 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 2026292 20262922 -2 -0.0
Full report (9 builds for cc32xx, linux, mbed, nrfconnect, qpg)
platform target config section e434c6a ac60da0 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643465 643465 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930213 930213 0 0.0
.debug_aranges 87336 87336 0 0.0
.debug_frame 300024 300024 0 0.0
.debug_info 2026292 20262922 -2 -0.0
.debug_line 2657815 2657815 0 0.0
.debug_loc 2800026 2800026 0 0.0
.debug_ranges 282240 282240 0 0.0
.debug_str 3023883 3023883 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378514 378514 0 0.0
.symtab 256560 256560 0 0.0
.text 535412 535412 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12138116 12138116 0 0.0
(read/write) 733448 733448 0 0.0
.bss 34296 34296 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 675552 675552 0 0.0
.dynamic 560 560 0 0.0
.got 15376 15376 0 0.0
.init 24 24 0 0.0
.init_array 216 216 0 0.0
.rodata 587140 587140 0 0.0
.text 9810356 9810356 0 0.0
thermostat-no-ble arm64 (read only) 2519284 2519284 0 0.0
(read/write) 145208 145208 0 0.0
.bss 56344 56344 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 77688 77688 0 0.0
.dynamic 560 560 0 0.0
.got 5336 5336 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150704 150704 0 0.0
.text 2106272 2106272 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2467384 2467384 0 0.0
.bss 215804 215804 0 0.0
.data 5880 5880 0 0.0
.text 1430028 1430028 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1167876 1167876 0 0.0
bss 143423 143423 0 0.0
rodata 136352 136352 0 0.0
text 808260 808260 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1112896 1112896 0 0.0
bss 142579 142579 0 0.0
rodata 113196 113196 0 0.0
text 777400 777400 0 0.0
all-clusters-app nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1372880 1372880 0 0.0
bss 105902 105902 0 0.0
rodata 213740 213740 0 0.0
text 767744 767744 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151676 1151684 8 0.0
.bss 99804 99804 0 0.0
.data 852 852 0 0.0
.text 598772 598780 8 0.0
lock-app qpg6105+debug (read/write) 1118892 1118892 0 0.0
.bss 96292 96292 0 0.0
.data 864 864 0 0.0
.text 565992 565992 0 0.0

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

PR #25411: Size comparison from e434c6a to 059265c

Decreases (1 build for cc32xx)
platform target config section e434c6a 059265c change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 2026292 20262923 -1 -0.0
Full report (2 builds for cc32xx, mbed)
platform target config section e434c6a 059265c change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643465 643465 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930213 930213 0 0.0
.debug_aranges 87336 87336 0 0.0
.debug_frame 300024 300024 0 0.0
.debug_info 2026292 20262923 -1 -0.0
.debug_line 2657815 2657815 0 0.0
.debug_loc 2800026 2800026 0 0.0
.debug_ranges 282240 282240 0 0.0
.debug_str 3023883 3023883 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378514 378514 0 0.0
.symtab 256560 256560 0 0.0
.text 535412 535412 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2467384 2467384 0 0.0
.bss 215804 215804 0 0.0
.data 5880 5880 0 0.0
.text 1430028 1430028 0 0.0

@github-actions
Copy link

github-actions bot commented Mar 2, 2023

PR #25411: Size comparison from c126158 to 40ccae9

Decreases (1 build for cc32xx)
platform target config section c126158 40ccae9 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20262928 20262927 -1 -0.0
Full report (1 build for cc32xx)
platform target config section c126158 40ccae9 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643465 643465 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930213 930213 0 0.0
.debug_aranges 87336 87336 0 0.0
.debug_frame 300024 300024 0 0.0
.debug_info 20262928 20262927 -1 -0.0
.debug_line 2657820 2657820 0 0.0
.debug_loc 2800026 2800026 0 0.0
.debug_ranges 282240 282240 0 0.0
.debug_str 3023883 3023883 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378514 378514 0 0.0
.symtab 256560 256560 0 0.0
.text 535412 535412 0 0.0

@github-actions
Copy link

github-actions bot commented Mar 2, 2023

PR #25411: Size comparison from 251a7c5 to 0a959a5

Increases (1 build for cc32xx)
platform target config section 251a7c5 0a959a5 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20262927 20262929 2 0.0
Full report (1 build for cc32xx)
platform target config section 251a7c5 0a959a5 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643465 643465 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930213 930213 0 0.0
.debug_aranges 87336 87336 0 0.0
.debug_frame 300024 300024 0 0.0
.debug_info 20262927 20262929 2 0.0
.debug_line 2657820 2657820 0 0.0
.debug_loc 2800026 2800026 0 0.0
.debug_ranges 282240 282240 0 0.0
.debug_str 3023883 3023883 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378514 378514 0 0.0
.symtab 256560 256560 0 0.0
.text 535412 535412 0 0.0

@yufengwangca yufengwangca merged commit 3f05692 into project-chip:master Mar 2, 2023
@yufengwangca yufengwangca deleted the pr/kotlin/tlv_lib branch March 2, 2023 19:17
@joonhaengHeo
Copy link
Contributor

joonhaengHeo commented Mar 3, 2023 •
edited
Loading

@yufengwangca
After merging this, android build can't run because of kotlinc.
I think you should add contents related to kotlinc in the guide document below.
https://github.com/project-chip/connectedhomeip/blob/master/docs/guides/android_building.md

"sudo snap install --classic kotlin"

@g-coppock g-coppock mentioned this pull request Mar 3, 2023
Merged
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@yufengwangca
[Java] Add the TLVReader/TLVWriter lib for generic IM write/invoke AP…
1952ffd 
…Is (project-chip#25411)

* [java] Add tlv writer and reader lib

* Address review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 left review comments

@g-coppock g-coppock g-coppock approved these changes

@emargolis emargolis emargolis approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@joonhaengHeo joonhaengHeo joonhaengHeo approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
controller fast track github review - pending workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the TLVReader/TLVWriter for Kotlin version
6 participants
@yufengwangca @joonhaengHeo @andy31415 @emargolis @yunhanw-google @g-coppock