Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
yufengwangca committed Mar 2, 2023
1 parent 1e953de commit 0a959a5
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/smoketest-android.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
if: github.actor != 'restyled-io[bot]'

container:
image: connectedhomeip/chip-build-android:0.6.44
image: connectedhomeip/chip-build-android:0.6.46
volumes:
- "/tmp/log_output:/tmp/test_logs"

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,7 @@ jobs:
runs-on: ubuntu-latest

container:
image: connectedhomeip/chip-build:0.6.44
image: connectedhomeip/chip-build-java:0.6.46
options: --privileged --sysctl "net.ipv6.conf.all.disable_ipv6=0
net.ipv4.conf.all.forwarding=0 net.ipv6.conf.all.forwarding=0"

Expand Down
6 changes: 2 additions & 4 deletions src/controller/java/src/chip/tlv/TlvReader.kt
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,7 @@ import java.lang.Double.longBitsToDouble
import java.lang.Float.intBitsToFloat

/**
* Implements Weave/Matter TLV reader that supports all values and tags as defined in the Spec.
*
* See go/weave-tlv-format and go/chip-specs#tlv for specification.
* Implements Matter TLV reader that supports all values and tags as defined in the Spec.
*
* @param bytes the bytes to interpret
*/
Expand Down Expand Up @@ -382,6 +380,6 @@ class TlvReader(bytes: ByteArray) : Iterable<Element> {
}
}

/** Exception thrown if there was an issue decoding the Weave TLV data. */
/** Exception thrown if there was an issue decoding the Matter TLV data. */
class TlvParsingException internal constructor(msg: String, cause: Throwable? = null) :
RuntimeException(msg, cause)
4 changes: 1 addition & 3 deletions src/controller/java/src/chip/tlv/TlvWriter.kt
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,7 @@ import com.google.protobuf.ByteString
import java.io.ByteArrayOutputStream

/**
* Implements Weave/Matter TLV writer that supports all values and tags as defined in the Spec.
*
* See go/weave-tlv-format and go/chip-specs#tlv for specification.
* Implements Matter TLV writer that supports all values and tags as defined in the Spec.
*
* @param bytes the bytes to interpret
*/
Expand Down

0 comments on commit 0a959a5

Please sign in to comment.