Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using non-namespaced attribute ids in core SDK code. #24649

Merged
merged 6 commits into from
Jan 27, 2023
Merged

Stop using non-namespaced attribute ids in core SDK code. #24649

merged 6 commits into from
Jan 27, 2023

Commits on Jan 25, 2023

  1. Stop using non-namespaced attribute ids in core SDK code.

    @bzbarsky-apple
    bzbarsky-apple committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    728375e View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2023

  1. Also remove now-unused attribute-id.h includes in core code.

    @bzbarsky-apple
    bzbarsky-apple committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    da4b853 View commit details
    Browse the repository at this point in the history

  2. Fix clang-tidy else-after-return complaint.

    @bzbarsky-apple
    bzbarsky-apple committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    0dbf92e View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Jonathan Mégevand <77852424+jmeg-sfy@users.noreply.github.com>
    @bzbarsky-apple @jmeg-sfy
    bzbarsky-apple and jmeg-sfy authored Jan 26, 2023
    Configuration menu
    Copy the full SHA
    a301b35 View commit details
    Browse the repository at this point in the history

  4. One more "target" addition.

    @bzbarsky-apple
    bzbarsky-apple authored Jan 26, 2023
    Configuration menu
    Copy the full SHA
    9d40b03 View commit details
    Browse the repository at this point in the history

  5. Fix restyle issue.

    @bzbarsky-apple
    bzbarsky-apple committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    c560730 View commit details
    Browse the repository at this point in the history