-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using non-namespaced attribute ids in core SDK code. #24649
Merged
bzbarsky-apple
merged 6 commits into
project-chip:master
from
bzbarsky-apple:attribute-ids-src
Jan 27, 2023
Merged
Stop using non-namespaced attribute ids in core SDK code. #24649
bzbarsky-apple
merged 6 commits into
project-chip:master
from
bzbarsky-apple:attribute-ids-src
Jan 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mlepage-google
January 25, 2023 18:16
bzbarsky-apple
force-pushed
the
attribute-ids-src
branch
from
January 26, 2023 01:43
805191e
to
da4b853
Compare
PR #24649: Size comparison from 2ce5f2d to da4b853 Increases above 0.2%:
Increases (41 builds for bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (10 builds for bl702, cc13x2_26x2, esp32, linux, psoc6)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #24649: Size comparison from 2ce5f2d to 0dbf92e Increases above 0.2%:
Increases (41 builds for bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (12 builds for bl602, bl702, cc13x2_26x2, esp32, linux, psoc6)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmeg-sfy
reviewed
Jan 26, 2023
jmeg-sfy
reviewed
Jan 26, 2023
jmeg-sfy
reviewed
Jan 26, 2023
jmeg-sfy
reviewed
Jan 26, 2023
jmeg-sfy
reviewed
Jan 26, 2023
jmeg-sfy
reviewed
Jan 26, 2023
jmeg-sfy
reviewed
Jan 26, 2023
jmeg-sfy
reviewed
Jan 26, 2023
jmeg-sfy
reviewed
Jan 26, 2023
jmeg-sfy
reviewed
Jan 26, 2023
jmeg-sfy
reviewed
Jan 26, 2023
jmeg-sfy
reviewed
Jan 26, 2023
jmeg-sfy
reviewed
Jan 26, 2023
jmeg-sfy
reviewed
Jan 26, 2023
jmeg-sfy
approved these changes
Jan 26, 2023
Co-authored-by: Jonathan Mégevand <77852424+jmeg-sfy@users.noreply.github.com>
bzbarsky-apple
commented
Jan 26, 2023
PR #24649: Size comparison from 2ce5f2d to 9d40b03 Increases (13 builds for bl702, k32w, linux, mbed, nrfconnect, qpg)
Decreases (3 builds for bl702, linux)
Full report (15 builds for bl602, bl702, k32w, linux, mbed, nrfconnect, qpg)
|
PR #24649: Size comparison from 2ce5f2d to c560730 Increases above 0.2%:
Increases (41 builds for bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (9 builds for bl702, cc13x2_26x2, linux, psoc6)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…ip#24649) * Stop using non-namespaced attribute ids in core SDK code. * Also remove now-unused attribute-id.h includes in core code. * Fix clang-tidy else-after-return complaint. * Apply suggestions from code review Co-authored-by: Jonathan Mégevand <77852424+jmeg-sfy@users.noreply.github.com> * One more "target" addition. * Fix restyle issue. Co-authored-by: Jonathan Mégevand <77852424+jmeg-sfy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd like to remove the non-namespaced defines.
Also switches scenes to use the type-safe attribute getters/setters.