Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using non-namespaced attribute ids in core SDK code. #24649

Merged
merged 6 commits into from
Jan 27, 2023
Merged

Stop using non-namespaced attribute ids in core SDK code. #24649

merged 6 commits into from
Jan 27, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

We'd like to remove the non-namespaced defines.

Also switches scenes to use the type-safe attribute getters/setters.

@github-actions
Copy link

github-actions bot commented Jan 26, 2023 •
edited
Loading

PR #24649: Size comparison from 2ce5f2d to da4b853

Increases above 0.2%:

platform target config section 2ce5f2d da4b853 change % change
efr32 window-app BRD4187C .text 981708 983788 2080 0.2
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1749972 1755644 5672 0.3
.data 2664 2672 8 0.3
.debug_line 3766626 3778958 12332 0.3
.debug_loc 3651664 3673103 21439 0.6
.debug_ranges 357376 362248 4872 1.4
.strtab 575760 577246 1486 0.3
.text 1549184 1554720 5536 0.4
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1691372 1697516 6144 0.4
.debug_line 3774912 3787324 12412 0.3
.debug_loc 3635394 3656832 21438 0.6
.debug_ranges 355344 360216 4872 1.4
.strtab 536226 538662 2436 0.5
.symtab 408432 409712 1280 0.3
.text 1491392 1497408 6016 0.4
Increases (41 builds for bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 2ce5f2d da4b853 change % change
bl702 lighting-app bl702 .debug_abbrev 1549734 1549986 252 0.0
.debug_info 40190809 40197950 7141 0.0
.debug_line 5266055 5267114 1059 0.0
.debug_loc 3401794 3401860 66 0.0
.debug_ranges 371904 371928 24 0.0
.strtab 571662 571692 30 0.0
.symtab 173168 173184 16 0.0
bl702+rpc .debug_abbrev 1698172 1698382 210 0.0
.debug_info 44587089 44594230 7141 0.0
.debug_line 5664380 5665439 1059 0.0
.debug_loc 3597945 3598011 66 0.0
.debug_ranges 395608 395632 24 0.0
.strtab 632259 632289 30 0.0
.symtab 191520 191536 16 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677223 677295 72 0.0
(read/write) 174632 174688 56 0.0
.bss 81548 81676 128 0.2
.text 589440 589508 68 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640847 641375 528 0.1
(read/write) 158240 158368 128 0.1
.bss 80740 80868 128 0.2
.text 563100 563632 532 0.1
lock-ftd LP_CC2652R7 (read only) 674347 674379 32 0.0
.text 597600 597632 32 0.0
lock-mtd LP_CC2652R7 (read only) 660663 660711 48 0.0
.text 557448 557496 48 0.0
pump-app LP_CC2652R7 (read only) 687379 687427 48 0.0
.text 596504 596552 48 0.0
pump-controller-app LP_CC2652R7 (read only) 672811 672875 64 0.0
.text 585856 585920 64 0.0
shell LP_CC2652R7 (read only) 668494 668542 48 0.0
(read/write) 185432 185512 80 0.0
.bss 83620 83748 128 0.2
.text 583972 584024 52 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 585402 585434 32 0.0
.app_xip_area 461420 461452 32 0.0
lock cyw930739m2evb_01 (read/write) 589118 589174 56 0.0
.app_xip_area 459840 459896 56 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 550758 550814 56 0.0
.app_xip_area 432264 432320 56 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974096 974144 48 0.0
.text 824728 824776 48 0.0
BRD4161A+rs911x (read/write) 1037116 1037148 32 0.0
.text 853424 853456 32 0.0
BRD4187C (read/write) 1151248 1151280 32 0.0
.text 990456 990488 32 0.0
lock-app BRD4161A+wf200 (read/write) 1064740 1064772 32 0.0
.text 909520 909552 32 0.0
window-app BRD4187C (read/write) 1143940 1146120 2180 0.2
.bss 135068 135164 96 0.1
.data 2568 2572 4 0.2
.text 981708 983788 2080 0.2
esp32 all-clusters-app c3devkit (read only) 1041534 1042084 550 0.1
(read/write) 1515938 1516066 128 0.0
.dram0.bss 75904 76032 128 0.2
.flash.text 1041534 1042084 550 0.1
m5stack (read only) 1093751 1094263 512 0.0
(read/write) 497599 497711 112 0.0
.dram0.bss 80952 81080 128 0.2
.flash.text 1088367 1088879 512 0.0
k32w contact k32w0+release (read/write) 660908 660924 16 0.0
.text 562324 562340 16 0.0
light k32w0+release (read/write) 672820 672868 48 0.0
.text 592884 592932 48 0.0
lock k32w0+release (read/write) 632288 632320 32 0.0
.text 551564 551596 32 0.0
linux chip-tool-ipv6only arm64 (read only) 10994156 10994332 176 0.0
.text 8771380 8771556 176 0.0
thermostat-no-ble arm64 (read only) 2503556 2504436 880 0.0
.text 2090944 2091840 896 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2463192 2463256 64 0.0
.text 1425836 1425900 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1164968 1165172 204 0.0
bss 147118 147246 128 0.1
rodata 133232 133244 12 0.0
text 804400 804460 60 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1366544 1366740 196 0.0
bss 106418 106546 128 0.1
rodata 210720 210724 4 0.0
text 763568 763624 56 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1110692 1111420 728 0.1
bss 146274 146402 128 0.1
rodata 110380 110388 8 0.0
text 773936 774528 592 0.1
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1749972 1755644 5672 0.3
.bss 189736 189864 128 0.1
.data 2664 2672 8 0.3
.debug_abbrev 1251009 1251453 444 0.0
.debug_aranges 111256 111280 24 0.0
.debug_frame 373620 373636 16 0.0
.debug_info 27465099 27505712 40613 0.1
.debug_line 3766626 3778958 12332 0.3
.debug_loc 3651664 3673103 21439 0.6
.debug_ranges 357376 362248 4872 1.4
.debug_str 3484013 3485010 997 0.0
.strtab 575760 577246 1486 0.3
.symtab 423440 424272 832 0.2
.text 1549184 1554720 5536 0.4
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1691372 1697516 6144 0.4
.bss 188928 189056 128 0.1
.debug_abbrev 1236720 1237164 444 0.0
.debug_aranges 110520 110544 24 0.0
.debug_frame 376064 376080 16 0.0
.debug_info 27022864 27063476 40612 0.2
.debug_line 3774912 3787324 12412 0.3
.debug_loc 3635394 3656832 21438 0.6
.debug_ranges 355344 360216 4872 1.4
.debug_str 3469766 3470763 997 0.0
.strtab 536226 538662 2436 0.5
.symtab 408432 409712 1280 0.3
.text 1491392 1497408 6016 0.4
light cy8ckit_062s2_43012 (read/write) 1611148 1611180 32 0.0
.debug_abbrev 1071778 1072030 252 0.0
.debug_info 22483782 22490921 7139 0.0
.debug_line 3339092 3340136 1044 0.0
.debug_loc 3336402 3336501 99 0.0
.debug_ranges 319416 319440 24 0.0
.strtab 474042 474072 30 0.0
.symtab 377600 377632 32 0.0
.text 1419360 1419392 32 0.0
lock cy8ckit_062s2_43012 (read/write) 1645212 1645244 32 0.0
.debug_abbrev 1073126 1073378 252 0.0
.debug_info 22704397 22711565 7168 0.0
.debug_line 3340859 3341860 1001 0.0
.debug_loc 3357990 3358015 25 0.0
.debug_ranges 321272 321296 24 0.0
.strtab 476977 477007 30 0.0
.symtab 379424 379456 32 0.0
.text 1448440 1448472 32 0.0
qpg lighting-app qpg6105+debug (read/write) 1148304 1148344 40 0.0
.text 595404 595444 40 0.0
lock-app qpg6105+debug (read/write) 1115992 1116040 48 0.0
.text 563088 563136 48 0.0
telink all-clusters-app tlsr9518adk80d (read/write) 1026616 1027384 768 0.1
bss 98552 98680 128 0.1
text 688798 689440 642 0.1
all-clusters-minimal-app tlsr9518adk80d (read/write) 964972 966356 1384 0.1
bss 97696 97824 128 0.1
text 652282 653536 1254 0.2
contact-sensor-app tlsr9518adk80d (read/write) 869244 869308 64 0.0
text 582574 582640 66 0.0
light-switch-app tlsr9518adk80d (read/write) 885700 885764 64 0.0
text 597176 597242 66 0.0
lighting-app tlsr9518adk80d (read/write) 964044 964116 72 0.0
text 663180 663246 66 0.0
ota-requestor-app tlsr9518adk80d (read/write) 899540 899604 64 0.0
text 608290 608354 64 0.0
thermostat tlsr9518adk80d (read/write) 888916 889052 136 0.0
text 597940 598080 140 0.0
Decreases (10 builds for bl702, cc13x2_26x2, esp32, linux, psoc6)
platform target config section 2ce5f2d da4b853 change % change
bl702 lighting-app bl702 (read/write) 1184951 1184935 -16 -0.0
.debug_frame 491000 490996 -4 -0.0
.text 952354 952352 -2 -0.0
bl702+rpc .debug_frame 518704 518700 -4 -0.0
.text 1029342 1029340 -2 -0.0
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 174980 174948 -32 -0.0
lock-mtd LP_CC2652R7 (read/write) 183928 183880 -48 -0.0
pump-app LP_CC2652R7 (read/write) 162676 162628 -48 -0.0
pump-controller-app LP_CC2652R7 (read/write) 177356 177292 -64 -0.0
esp32 all-clusters-app m5stack .flash.rodata 248804 248788 -16 -0.0
linux thermostat-no-ble arm64 .rodata 150816 150800 -16 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840944 840808 -136 -0.0
.heap 840944 840808 -136 -0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841752 841624 -128 -0.0
.heap 841752 841624 -128 -0.0
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 2ce5f2d da4b853 change % change
bl602 lighting-app bl602 (read/write) 1345482 1345482 0 0.0
.bss 94858 94858 0 0.0
.data 9736 9736 0 0.0
.text 1022520 1022520 0 0.0
bl602+rpc (read/write) 1390930 1390930 0 0.0
.bss 102906 102906 0 0.0
.data 10128 10128 0 0.0
.text 1053454 1053454 0 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1184951 1184935 -16 -0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 70701 70701 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4056 4056 0 0.0
.debug_abbrev 1549734 1549986 252 0.0
.debug_aranges 134056 134056 0 0.0
.debug_frame 491000 490996 -4 -0.0
.debug_info 40190809 40197950 7141 0.0
.debug_line 5266055 5267114 1059 0.0
.debug_loc 3401794 3401860 66 0.0
.debug_ranges 371904 371928 24 0.0
.debug_str 3535090 3535090 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106704 106704 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 571662 571692 30 0.0
.symtab 173168 173184 16 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
952354 952352 -2 -0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1277579 1277579 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 78749 78749 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1698172 1698382 210 0.0
.debug_aranges 142280 142280 0 0.0
.debug_frame 518704 518700 -4 -0.0
.debug_info 44587089 44594230 7141 0.0
.debug_line 5664380 5665439 1059 0.0
.debug_loc 3597945 3598011 66 0.0
.debug_ranges 395608 395632 24 0.0
.debug_str 3938399 3938399 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121232 121232 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 632259 632289 30 0.0
.symtab 191520 191536 16 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1029342 1029340 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677223 677295 72 0.0
(read/write) 174632 174688 56 0.0
.bss 81548 81676 128 0.2
.data 3384 3384 0 0.0
.rodata 87471 87471 0 0.0
.text 589440 589508 68 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640847 641375 528 0.1
(read/write) 158240 158368 128 0.1
.bss 80740 80868 128 0.2
.data 3384 3384 0 0.0
.rodata 77423 77423 0 0.0
.text 563100 563632 532 0.1
lock-ftd LP_CC2652R7 (read only) 674347 674379 32 0.0
(read/write) 174980 174948 -32 -0.0
.bss 79108 79108 0 0.0
.data 3312 3312 0 0.0
.rodata 76267 76267 0 0.0
.text 597600 597632 32 0.0
lock-mtd LP_CC2652R7 (read only) 660663 660711 48 0.0
(read/write) 183928 183880 -48 -0.0
.bss 74372 74372 0 0.0
.data 3312 3312 0 0.0
.rodata 102735 102735 0 0.0
.text 557448 557496 48 0.0
pump-app LP_CC2652R7 (read only) 687379 687427 48 0.0
(read/write) 162676 162628 -48 -0.0
.bss 79068 79068 0 0.0
.data 3276 3276 0 0.0
.rodata 90395 90395 0 0.0
.text 596504 596552 48 0.0
pump-controller-app LP_CC2652R7 (read only) 672811 672875 64 0.0
(read/write) 177356 177292 -64 -0.0
.bss 79180 79180 0 0.0
.data 3300 3300 0 0.0
.rodata 86475 86475 0 0.0
.text 585856 585920 64 0.0
shell LP_CC2652R7 (read only) 668494 668542 48 0.0
(read/write) 185432 185512 80 0.0
.bss 83620 83748 128 0.2
.data 3380 3380 0 0.0
.rodata 84206 84206 0 0.0
.text 583972 584024 52 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 585402 585434 32 0.0
.app_xip_area 461420 461452 32 0.0
.bss 66432 66432 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589118 589174 56 0.0
.app_xip_area 459840 459896 56 0.0
.bss 71720 71720 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 550758 550814 56 0.0
.app_xip_area 432264 432320 56 0.0
.bss 60984 60984 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974096 974144 48 0.0
.bss 147152 147152 0 0.0
.data 2196 2196 0 0.0
.text 824728 824776 48 0.0
BRD4161A+rs911x (read/write) 1037116 1037148 32 0.0
.bss 181632 181632 0 0.0
.data 2040 2040 0 0.0
.text 853424 853456 32 0.0
BRD4187C (read/write) 1151248 1151280 32 0.0
.bss 133652 133652 0 0.0
.data 2544 2544 0 0.0
.text 990456 990488 32 0.0
lock-app BRD4161A+wf200 (read/write) 1064740 1064772 32 0.0
.bss 153152 153152 0 0.0
.data 2048 2048 0 0.0
.text 909520 909552 32 0.0
window-app BRD4187C (read/write) 1143940 1146120 2180 0.2
.bss 135068 135164 96 0.1
.data 2568 2572 4 0.2
.text 981708 983788 2080 0.2
esp32 all-clusters-app c3devkit (read only) 1041534 1042084 550 0.1
(read/write) 1515938 1516066 128 0.0
.dram0.bss 75904 76032 128 0.2
.dram0.data 13792 13792 0 0.0
.flash.rodata 220024 220024 0 0.0
.flash.text 1041534 1042084 550 0.1
.iram0.text 72896 72896 0 0.0
m5stack (read only) 1093751 1094263 512 0.0
(read/write) 497599 497711 112 0.0
.dram0.bss 80952 81080 128 0.2
.dram0.data 34072 34072 0 0.0
.flash.rodata 248804 248788 -16 -0.0
.flash.text 1088367 1088879 512 0.0
.iram0.text 124855 124855 0 0.0
k32w contact k32w0+release (read/write) 660908 660924 16 0.0
.bss 77360 77360 0 0.0
.data 2112 2112 0 0.0
.text 562324 562340 16 0.0
light k32w0+release (read/write) 672820 672868 48 0.0
.bss 75144 75144 0 0.0
.data 2064 2064 0 0.0
.text 592884 592932 48 0.0
lock k32w0+release (read/write) 632288 632320 32 0.0
.bss 75912 75912 0 0.0
.data 2084 2084 0 0.0
.text 551564 551596 32 0.0
linux chip-tool-ipv6only arm64 (read only) 10994156 10994332 176 0.0
(read/write) 697032 697032 0 0.0
.bss 34248 34248 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 640464 640464 0 0.0
.dynamic 560 560 0 0.0
.got 14112 14112 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 572428 572428 0 0.0
.text 8771380 8771556 176 0.0
thermostat-no-ble arm64 (read only) 2503556 2504436 880 0.0
(read/write) 144648 144648 0 0.0
.bss 56456 56456 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 76944 76944 0 0.0
.dynamic 560 560 0 0.0
.got 5392 5392 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150816 150800 -16 -0.0
.text 2090944 2091840 896 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2463192 2463256 64 0.0
.bss 215956 215956 0 0.0
.data 5880 5880 0 0.0
.text 1425836 1425900 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1164968 1165172 204 0.0
bss 147118 147246 128 0.1
rodata 133232 133244 12 0.0
text 804400 804460 60 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1366544 1366740 196 0.0
bss 106418 106546 128 0.1
rodata 210720 210724 4 0.0
text 763568 763624 56 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1110692 1111420 728 0.1
bss 146274 146402 128 0.1
rodata 110380 110388 8 0.0
text 773936 774528 592 0.1
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840944 840808 -136 -0.0
(read/write) 1749972 1755644 5672 0.3
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189736 189864 128 0.1
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2672 8 0.3
.debug_abbrev 1251009 1251453 444 0.0
.debug_aranges 111256 111280 24 0.0
.debug_frame 373620 373636 16 0.0
.debug_info 27465099 27505712 40613 0.1
.debug_line 3766626 3778958 12332 0.3
.debug_loc 3651664 3673103 21439 0.6
.debug_ranges 357376 362248 4872 1.4
.debug_str 3484013 3485010 997 0.0
.heap 840944 840808 -136 -0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 575760 577246 1486 0.3
.symtab 423440 424272 832 0.2
.text 1549184 1554720 5536 0.4
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841752 841624 -128 -0.0
(read/write) 1691372 1697516 6144 0.4
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188928 189056 128 0.1
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1236720 1237164 444 0.0
.debug_aranges 110520 110544 24 0.0
.debug_frame 376064 376080 16 0.0
.debug_info 27022864 27063476 40612 0.2
.debug_line 3774912 3787324 12412 0.3
.debug_loc 3635394 3656832 21438 0.6
.debug_ranges 355344 360216 4872 1.4
.debug_str 3469766 3470763 997 0.0
.heap 841752 841624 -128 -0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 536226 538662 2436 0.5
.symtab 408432 409712 1280 0.3
.text 1491392 1497408 6016 0.4
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849944 849944 0 0.0
(read/write) 1611148 1611180 32 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180936 180936 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1071778 1072030 252 0.0
.debug_aranges 102800 102800 0 0.0
.debug_frame 346624 346624 0 0.0
.debug_info 22483782 22490921 7139 0.0
.debug_line 3339092 3340136 1044 0.0
.debug_loc 3336402 3336501 99 0.0
.debug_ranges 319416 319440 24 0.0
.debug_str 3274787 3274787 0 0.0
.heap 849944 849944 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474042 474072 30 0.0
.symtab 377600 377632 32 0.0
.text 1419360 1419392 32 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 844960 844960 0 0.0
(read/write) 1645212 1645244 32 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185912 185912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1073126 1073378 252 0.0
.debug_aranges 103184 103184 0 0.0
.debug_frame 348424 348424 0 0.0
.debug_info 22704397 22711565 7168 0.0
.debug_line 3340859 3341860 1001 0.0
.debug_loc 3357990 3358015 25 0.0
.debug_ranges 321272 321296 24 0.0
.debug_str 3291194 3291194 0 0.0
.heap 844960 844960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 476977 477007 30 0.0
.symtab 379424 379456 32 0.0
.text 1448440 1448472 32 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1148304 1148344 40 0.0
.bss 100668 100668 0 0.0
.data 848 848 0 0.0
.text 595404 595444 40 0.0
lock-app qpg6105+debug (read/write) 1115992 1116040 48 0.0
.bss 97188 97188 0 0.0
.data 860 860 0 0.0
.text 563088 563136 48 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1026616 1027384 768 0.1
bss 98552 98680 128 0.1
text 688798 689440 642 0.1
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 964972 966356 1384 0.1
bss 97696 97824 128 0.1
text 652282 653536 1254 0.2
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 869244 869308 64 0.0
bss 89844 89844 0 0.0
text 582574 582640 66 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 885700 885764 64 0.0
bss 89940 89940 0 0.0
text 597176 597242 66 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 964044 964116 72 0.0
bss 97996 97996 0 0.0
text 663180 663246 66 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 899540 899604 64 0.0
bss 90888 90888 0 0.0
text 608290 608354 64 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 888916 889052 136 0.0
bss 91328 91328 0 0.0
text 597940 598080 140 0.0

@github-actions
Copy link

github-actions bot commented Jan 26, 2023 •
edited
Loading

PR #24649: Size comparison from 2ce5f2d to 0dbf92e

Increases above 0.2%:

platform target config section 2ce5f2d 0dbf92e change % change
efr32 window-app BRD4187C .text 981708 983788 2080 0.2
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1749972 1755644 5672 0.3
.data 2664 2672 8 0.3
.debug_line 3766626 3778954 12328 0.3
.debug_loc 3651664 3673103 21439 0.6
.debug_ranges 357376 362248 4872 1.4
.strtab 575760 577246 1486 0.3
.text 1549184 1554720 5536 0.4
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1691372 1697516 6144 0.4
.debug_line 3774912 3787320 12408 0.3
.debug_loc 3635394 3656832 21438 0.6
.debug_ranges 355344 360216 4872 1.4
.strtab 536226 538662 2436 0.5
.symtab 408432 409712 1280 0.3
.text 1491392 1497408 6016 0.4
Increases (41 builds for bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 2ce5f2d 0dbf92e change % change
bl702 lighting-app bl702 .debug_abbrev 1549734 1549986 252 0.0
.debug_info 40190809 40197951 7142 0.0
.debug_line 5266055 5267110 1055 0.0
.debug_loc 3401794 3401860 66 0.0
.debug_ranges 371904 371928 24 0.0
.strtab 571662 571692 30 0.0
.symtab 173168 173184 16 0.0
bl702+rpc .debug_abbrev 1698172 1698382 210 0.0
.debug_info 44587089 44594231 7142 0.0
.debug_line 5664380 5665435 1055 0.0
.debug_loc 3597945 3598011 66 0.0
.debug_ranges 395608 395632 24 0.0
.strtab 632259 632289 30 0.0
.symtab 191520 191536 16 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677223 677295 72 0.0
(read/write) 174632 174688 56 0.0
.bss 81548 81676 128 0.2
.text 589440 589508 68 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640847 641375 528 0.1
(read/write) 158240 158368 128 0.1
.bss 80740 80868 128 0.2
.text 563100 563632 532 0.1
lock-ftd LP_CC2652R7 (read only) 674347 674379 32 0.0
.text 597600 597632 32 0.0
lock-mtd LP_CC2652R7 (read only) 660663 660711 48 0.0
.text 557448 557496 48 0.0
pump-app LP_CC2652R7 (read only) 687379 687427 48 0.0
.text 596504 596552 48 0.0
pump-controller-app LP_CC2652R7 (read only) 672811 672875 64 0.0
.text 585856 585920 64 0.0
shell LP_CC2652R7 (read only) 668494 668542 48 0.0
(read/write) 185432 185512 80 0.0
.bss 83620 83748 128 0.2
.text 583972 584024 52 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 585402 585442 40 0.0
.app_xip_area 461420 461460 40 0.0
lock cyw930739m2evb_01 (read/write) 589118 589174 56 0.0
.app_xip_area 459840 459896 56 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 550758 550814 56 0.0
.app_xip_area 432264 432320 56 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974096 974144 48 0.0
.text 824728 824776 48 0.0
BRD4161A+rs911x (read/write) 1037116 1037148 32 0.0
.text 853424 853456 32 0.0
BRD4187C (read/write) 1151248 1151280 32 0.0
.text 990456 990488 32 0.0
lock-app BRD4161A+wf200 (read/write) 1064740 1064772 32 0.0
.text 909520 909552 32 0.0
window-app BRD4187C (read/write) 1143940 1146120 2180 0.2
.bss 135068 135164 96 0.1
.data 2568 2572 4 0.2
.text 981708 983788 2080 0.2
esp32 all-clusters-app c3devkit (read only) 1041534 1042084 550 0.1
(read/write) 1515938 1516066 128 0.0
.dram0.bss 75904 76032 128 0.2
.flash.text 1041534 1042084 550 0.1
m5stack (read only) 1093751 1094263 512 0.0
(read/write) 497599 497711 112 0.0
.dram0.bss 80952 81080 128 0.2
.flash.text 1088367 1088879 512 0.0
k32w contact k32w0+release (read/write) 660908 660924 16 0.0
.text 562324 562340 16 0.0
light k32w0+release (read/write) 672820 672868 48 0.0
.text 592884 592932 48 0.0
lock k32w0+release (read/write) 632288 632320 32 0.0
.text 551564 551596 32 0.0
linux chip-tool-ipv6only arm64 (read only) 10994156 10994316 160 0.0
.text 8771380 8771540 160 0.0
thermostat-no-ble arm64 (read only) 2503556 2504420 864 0.0
.text 2090944 2091824 880 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2463192 2463256 64 0.0
.text 1425836 1425900 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1164968 1165172 204 0.0
bss 147118 147246 128 0.1
rodata 133232 133244 12 0.0
text 804400 804456 56 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1366544 1366740 196 0.0
bss 106418 106546 128 0.1
rodata 210720 210724 4 0.0
text 763568 763624 56 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1110692 1111436 744 0.1
bss 146274 146402 128 0.1
rodata 110380 110388 8 0.0
text 773936 774532 596 0.1
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1749972 1755644 5672 0.3
.bss 189736 189864 128 0.1
.data 2664 2672 8 0.3
.debug_abbrev 1251009 1251453 444 0.0
.debug_aranges 111256 111280 24 0.0
.debug_frame 373620 373636 16 0.0
.debug_info 27465099 27505712 40613 0.1
.debug_line 3766626 3778954 12328 0.3
.debug_loc 3651664 3673103 21439 0.6
.debug_ranges 357376 362248 4872 1.4
.debug_str 3484013 3485010 997 0.0
.strtab 575760 577246 1486 0.3
.symtab 423440 424272 832 0.2
.text 1549184 1554720 5536 0.4
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1691372 1697516 6144 0.4
.bss 188928 189056 128 0.1
.debug_abbrev 1236720 1237164 444 0.0
.debug_aranges 110520 110544 24 0.0
.debug_frame 376064 376080 16 0.0
.debug_info 27022864 27063477 40613 0.2
.debug_line 3774912 3787320 12408 0.3
.debug_loc 3635394 3656832 21438 0.6
.debug_ranges 355344 360216 4872 1.4
.debug_str 3469766 3470763 997 0.0
.strtab 536226 538662 2436 0.5
.symtab 408432 409712 1280 0.3
.text 1491392 1497408 6016 0.4
light cy8ckit_062s2_43012 (read/write) 1611148 1611180 32 0.0
.debug_abbrev 1071778 1072030 252 0.0
.debug_info 22483782 22490923 7141 0.0
.debug_line 3339092 3340132 1040 0.0
.debug_loc 3336402 3336501 99 0.0
.debug_ranges 319416 319440 24 0.0
.strtab 474042 474072 30 0.0
.symtab 377600 377632 32 0.0
.text 1419360 1419392 32 0.0
lock cy8ckit_062s2_43012 (read/write) 1645212 1645244 32 0.0
.debug_abbrev 1073126 1073378 252 0.0
.debug_info 22704397 22711565 7168 0.0
.debug_line 3340859 3341856 997 0.0
.debug_loc 3357990 3358015 25 0.0
.debug_ranges 321272 321296 24 0.0
.strtab 476977 477007 30 0.0
.symtab 379424 379456 32 0.0
.text 1448440 1448472 32 0.0
qpg lighting-app qpg6105+debug (read/write) 1148304 1148344 40 0.0
.text 595404 595444 40 0.0
lock-app qpg6105+debug (read/write) 1115992 1116032 40 0.0
.text 563088 563128 40 0.0
telink all-clusters-app tlsr9518adk80d (read/write) 1026616 1027384 768 0.1
bss 98552 98680 128 0.1
text 688798 689436 638 0.1
all-clusters-minimal-app tlsr9518adk80d (read/write) 964972 966356 1384 0.1
bss 97696 97824 128 0.1
text 652282 653536 1254 0.2
contact-sensor-app tlsr9518adk80d (read/write) 869244 869308 64 0.0
text 582574 582640 66 0.0
light-switch-app tlsr9518adk80d (read/write) 885700 885764 64 0.0
text 597176 597244 68 0.0
lighting-app tlsr9518adk80d (read/write) 964044 964116 72 0.0
text 663180 663248 68 0.0
ota-requestor-app tlsr9518adk80d (read/write) 899540 899604 64 0.0
text 608290 608358 68 0.0
thermostat tlsr9518adk80d (read/write) 888916 889052 136 0.0
text 597940 598082 142 0.0
Decreases (12 builds for bl602, bl702, cc13x2_26x2, esp32, linux, psoc6)
platform target config section 2ce5f2d 0dbf92e change % change
bl602 lighting-app bl602 .text 1022520 1022518 -2 -0.0
bl602+rpc .text 1053454 1053452 -2 -0.0
bl702 lighting-app bl702 .debug_frame 491000 490996 -4 -0.0
bl702+rpc .debug_frame 518704 518700 -4 -0.0
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 174980 174948 -32 -0.0
lock-mtd LP_CC2652R7 (read/write) 183928 183880 -48 -0.0
pump-app LP_CC2652R7 (read/write) 162676 162628 -48 -0.0
pump-controller-app LP_CC2652R7 (read/write) 177356 177292 -64 -0.0
esp32 all-clusters-app m5stack .flash.rodata 248804 248788 -16 -0.0
linux thermostat-no-ble arm64 .rodata 150816 150800 -16 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840944 840808 -136 -0.0
.heap 840944 840808 -136 -0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841752 841624 -128 -0.0
.heap 841752 841624 -128 -0.0
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 2ce5f2d 0dbf92e change % change
bl602 lighting-app bl602 (read/write) 1345482 1345482 0 0.0
.bss 94858 94858 0 0.0
.data 9736 9736 0 0.0
.text 1022520 1022518 -2 -0.0
bl602+rpc (read/write) 1390930 1390930 0 0.0
.bss 102906 102906 0 0.0
.data 10128 10128 0 0.0
.text 1053454 1053452 -2 -0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1184951 1184951 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 70701 70701 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4056 4056 0 0.0
.debug_abbrev 1549734 1549986 252 0.0
.debug_aranges 134056 134056 0 0.0
.debug_frame 491000 490996 -4 -0.0
.debug_info 40190809 40197951 7142 0.0
.debug_line 5266055 5267110 1055 0.0
.debug_loc 3401794 3401860 66 0.0
.debug_ranges 371904 371928 24 0.0
.debug_str 3535090 3535090 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106704 106704 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 571662 571692 30 0.0
.symtab 173168 173184 16 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
952354 952354 0 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1277579 1277579 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 78749 78749 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1698172 1698382 210 0.0
.debug_aranges 142280 142280 0 0.0
.debug_frame 518704 518700 -4 -0.0
.debug_info 44587089 44594231 7142 0.0
.debug_line 5664380 5665435 1055 0.0
.debug_loc 3597945 3598011 66 0.0
.debug_ranges 395608 395632 24 0.0
.debug_str 3938399 3938399 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121232 121232 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 632259 632289 30 0.0
.symtab 191520 191536 16 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1029342 1029342 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677223 677295 72 0.0
(read/write) 174632 174688 56 0.0
.bss 81548 81676 128 0.2
.data 3384 3384 0 0.0
.rodata 87471 87471 0 0.0
.text 589440 589508 68 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640847 641375 528 0.1
(read/write) 158240 158368 128 0.1
.bss 80740 80868 128 0.2
.data 3384 3384 0 0.0
.rodata 77423 77423 0 0.0
.text 563100 563632 532 0.1
lock-ftd LP_CC2652R7 (read only) 674347 674379 32 0.0
(read/write) 174980 174948 -32 -0.0
.bss 79108 79108 0 0.0
.data 3312 3312 0 0.0
.rodata 76267 76267 0 0.0
.text 597600 597632 32 0.0
lock-mtd LP_CC2652R7 (read only) 660663 660711 48 0.0
(read/write) 183928 183880 -48 -0.0
.bss 74372 74372 0 0.0
.data 3312 3312 0 0.0
.rodata 102735 102735 0 0.0
.text 557448 557496 48 0.0
pump-app LP_CC2652R7 (read only) 687379 687427 48 0.0
(read/write) 162676 162628 -48 -0.0
.bss 79068 79068 0 0.0
.data 3276 3276 0 0.0
.rodata 90395 90395 0 0.0
.text 596504 596552 48 0.0
pump-controller-app LP_CC2652R7 (read only) 672811 672875 64 0.0
(read/write) 177356 177292 -64 -0.0
.bss 79180 79180 0 0.0
.data 3300 3300 0 0.0
.rodata 86475 86475 0 0.0
.text 585856 585920 64 0.0
shell LP_CC2652R7 (read only) 668494 668542 48 0.0
(read/write) 185432 185512 80 0.0
.bss 83620 83748 128 0.2
.data 3380 3380 0 0.0
.rodata 84206 84206 0 0.0
.text 583972 584024 52 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 585402 585442 40 0.0
.app_xip_area 461420 461460 40 0.0
.bss 66432 66432 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589118 589174 56 0.0
.app_xip_area 459840 459896 56 0.0
.bss 71720 71720 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 550758 550814 56 0.0
.app_xip_area 432264 432320 56 0.0
.bss 60984 60984 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974096 974144 48 0.0
.bss 147152 147152 0 0.0
.data 2196 2196 0 0.0
.text 824728 824776 48 0.0
BRD4161A+rs911x (read/write) 1037116 1037148 32 0.0
.bss 181632 181632 0 0.0
.data 2040 2040 0 0.0
.text 853424 853456 32 0.0
BRD4187C (read/write) 1151248 1151280 32 0.0
.bss 133652 133652 0 0.0
.data 2544 2544 0 0.0
.text 990456 990488 32 0.0
lock-app BRD4161A+wf200 (read/write) 1064740 1064772 32 0.0
.bss 153152 153152 0 0.0
.data 2048 2048 0 0.0
.text 909520 909552 32 0.0
window-app BRD4187C (read/write) 1143940 1146120 2180 0.2
.bss 135068 135164 96 0.1
.data 2568 2572 4 0.2
.text 981708 983788 2080 0.2
esp32 all-clusters-app c3devkit (read only) 1041534 1042084 550 0.1
(read/write) 1515938 1516066 128 0.0
.dram0.bss 75904 76032 128 0.2
.dram0.data 13792 13792 0 0.0
.flash.rodata 220024 220024 0 0.0
.flash.text 1041534 1042084 550 0.1
.iram0.text 72896 72896 0 0.0
m5stack (read only) 1093751 1094263 512 0.0
(read/write) 497599 497711 112 0.0
.dram0.bss 80952 81080 128 0.2
.dram0.data 34072 34072 0 0.0
.flash.rodata 248804 248788 -16 -0.0
.flash.text 1088367 1088879 512 0.0
.iram0.text 124855 124855 0 0.0
k32w contact k32w0+release (read/write) 660908 660924 16 0.0
.bss 77360 77360 0 0.0
.data 2112 2112 0 0.0
.text 562324 562340 16 0.0
light k32w0+release (read/write) 672820 672868 48 0.0
.bss 75144 75144 0 0.0
.data 2064 2064 0 0.0
.text 592884 592932 48 0.0
lock k32w0+release (read/write) 632288 632320 32 0.0
.bss 75912 75912 0 0.0
.data 2084 2084 0 0.0
.text 551564 551596 32 0.0
linux chip-tool-ipv6only arm64 (read only) 10994156 10994316 160 0.0
(read/write) 697032 697032 0 0.0
.bss 34248 34248 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 640464 640464 0 0.0
.dynamic 560 560 0 0.0
.got 14112 14112 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 572428 572428 0 0.0
.text 8771380 8771540 160 0.0
thermostat-no-ble arm64 (read only) 2503556 2504420 864 0.0
(read/write) 144648 144648 0 0.0
.bss 56456 56456 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 76944 76944 0 0.0
.dynamic 560 560 0 0.0
.got 5392 5392 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150816 150800 -16 -0.0
.text 2090944 2091824 880 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2463192 2463256 64 0.0
.bss 215956 215956 0 0.0
.data 5880 5880 0 0.0
.text 1425836 1425900 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1164968 1165172 204 0.0
bss 147118 147246 128 0.1
rodata 133232 133244 12 0.0
text 804400 804456 56 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1366544 1366740 196 0.0
bss 106418 106546 128 0.1
rodata 210720 210724 4 0.0
text 763568 763624 56 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1110692 1111436 744 0.1
bss 146274 146402 128 0.1
rodata 110380 110388 8 0.0
text 773936 774532 596 0.1
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840944 840808 -136 -0.0
(read/write) 1749972 1755644 5672 0.3
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189736 189864 128 0.1
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2672 8 0.3
.debug_abbrev 1251009 1251453 444 0.0
.debug_aranges 111256 111280 24 0.0
.debug_frame 373620 373636 16 0.0
.debug_info 27465099 27505712 40613 0.1
.debug_line 3766626 3778954 12328 0.3
.debug_loc 3651664 3673103 21439 0.6
.debug_ranges 357376 362248 4872 1.4
.debug_str 3484013 3485010 997 0.0
.heap 840944 840808 -136 -0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 575760 577246 1486 0.3
.symtab 423440 424272 832 0.2
.text 1549184 1554720 5536 0.4
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841752 841624 -128 -0.0
(read/write) 1691372 1697516 6144 0.4
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188928 189056 128 0.1
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1236720 1237164 444 0.0
.debug_aranges 110520 110544 24 0.0
.debug_frame 376064 376080 16 0.0
.debug_info 27022864 27063477 40613 0.2
.debug_line 3774912 3787320 12408 0.3
.debug_loc 3635394 3656832 21438 0.6
.debug_ranges 355344 360216 4872 1.4
.debug_str 3469766 3470763 997 0.0
.heap 841752 841624 -128 -0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 536226 538662 2436 0.5
.symtab 408432 409712 1280 0.3
.text 1491392 1497408 6016 0.4
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849944 849944 0 0.0
(read/write) 1611148 1611180 32 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180936 180936 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1071778 1072030 252 0.0
.debug_aranges 102800 102800 0 0.0
.debug_frame 346624 346624 0 0.0
.debug_info 22483782 22490923 7141 0.0
.debug_line 3339092 3340132 1040 0.0
.debug_loc 3336402 3336501 99 0.0
.debug_ranges 319416 319440 24 0.0
.debug_str 3274787 3274787 0 0.0
.heap 849944 849944 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474042 474072 30 0.0
.symtab 377600 377632 32 0.0
.text 1419360 1419392 32 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 844960 844960 0 0.0
(read/write) 1645212 1645244 32 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185912 185912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1073126 1073378 252 0.0
.debug_aranges 103184 103184 0 0.0
.debug_frame 348424 348424 0 0.0
.debug_info 22704397 22711565 7168 0.0
.debug_line 3340859 3341856 997 0.0
.debug_loc 3357990 3358015 25 0.0
.debug_ranges 321272 321296 24 0.0
.debug_str 3291194 3291194 0 0.0
.heap 844960 844960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 476977 477007 30 0.0
.symtab 379424 379456 32 0.0
.text 1448440 1448472 32 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1148304 1148344 40 0.0
.bss 100668 100668 0 0.0
.data 848 848 0 0.0
.text 595404 595444 40 0.0
lock-app qpg6105+debug (read/write) 1115992 1116032 40 0.0
.bss 97188 97188 0 0.0
.data 860 860 0 0.0
.text 563088 563128 40 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1026616 1027384 768 0.1
bss 98552 98680 128 0.1
text 688798 689436 638 0.1
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 964972 966356 1384 0.1
bss 97696 97824 128 0.1
text 652282 653536 1254 0.2
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 869244 869308 64 0.0
bss 89844 89844 0 0.0
text 582574 582640 66 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 885700 885764 64 0.0
bss 89940 89940 0 0.0
text 597176 597244 68 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 964044 964116 72 0.0
bss 97996 97996 0 0.0
text 663180 663248 68 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 899540 899604 64 0.0
bss 90888 90888 0 0.0
text 608290 608358 68 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 888916 889052 136 0.0
bss 91328 91328 0 0.0
text 597940 598082 142 0.0

@bzbarsky-apple @jmeg-sfy
Apply suggestions from code review
a301b35 
Co-authored-by: Jonathan Mégevand <77852424+jmeg-sfy@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Jan 26, 2023 •
edited
Loading

PR #24649: Size comparison from 2ce5f2d to 9d40b03

Increases (13 builds for bl702, k32w, linux, mbed, nrfconnect, qpg)
platform target config section 2ce5f2d 9d40b03 change % change
bl702 lighting-app bl702 .debug_abbrev 1549734 1549986 252 0.0
.debug_info 40190809 40198110 7301 0.0
.debug_line 5266055 5267110 1055 0.0
.debug_loc 3401794 3401860 66 0.0
.debug_ranges 371904 371928 24 0.0
.strtab 571662 571692 30 0.0
.symtab 173168 173184 16 0.0
bl702+rpc .debug_abbrev 1698172 1698382 210 0.0
.debug_info 44587089 44594403 7314 0.0
.debug_line 5664380 5665435 1055 0.0
.debug_loc 3597945 3597998 53 0.0
.debug_ranges 395608 395632 24 0.0
.strtab 632259 632289 30 0.0
.symtab 191520 191536 16 0.0
k32w contact k32w0+release (read/write) 660908 660924 16 0.0
.text 562324 562340 16 0.0
light k32w0+release (read/write) 672820 672868 48 0.0
.text 592884 592932 48 0.0
lock k32w0+release (read/write) 632288 632320 32 0.0
.text 551564 551596 32 0.0
linux chip-tool-ipv6only arm64 (read only) 10994156 10994316 160 0.0
.text 8771380 8771540 160 0.0
thermostat-no-ble arm64 (read only) 2503556 2504420 864 0.0
.text 2090944 2091824 880 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2463192 2463256 64 0.0
.text 1425836 1425900 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1164968 1165280 312 0.0
bss 147118 147246 128 0.1
rodata 133232 133352 120 0.1
text 804400 804460 60 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1366544 1366848 304 0.0
bss 106418 106546 128 0.1
rodata 210720 210832 112 0.1
text 763568 763624 56 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1110692 1111544 852 0.1
bss 146274 146402 128 0.1
rodata 110380 110496 116 0.1
text 773936 774532 596 0.1
qpg lighting-app qpg6105+debug (read/write) 1148304 1148344 40 0.0
.text 595404 595444 40 0.0
lock-app qpg6105+debug (read/write) 1115992 1116032 40 0.0
.text 563088 563128 40 0.0
Decreases (3 builds for bl702, linux)
platform target config section 2ce5f2d 9d40b03 change % change
bl702 lighting-app bl702 (read/write) 1184951 1184935 -16 -0.0
.debug_frame 491000 490996 -4 -0.0
.text 952354 952352 -2 -0.0
bl702+rpc .debug_frame 518704 518700 -4 -0.0
linux thermostat-no-ble arm64 .rodata 150816 150800 -16 -0.0
Full report (15 builds for bl602, bl702, k32w, linux, mbed, nrfconnect, qpg)
platform target config section 2ce5f2d 9d40b03 change % change
bl602 lighting-app bl602 (read/write) 1345482 1345482 0 0.0
.bss 94858 94858 0 0.0
.data 9736 9736 0 0.0
.text 1022520 1022520 0 0.0
bl602+rpc (read/write) 1390930 1390930 0 0.0
.bss 102906 102906 0 0.0
.data 10128 10128 0 0.0
.text 1053454 1053454 0 0.0
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1184951 1184935 -16 -0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 70701 70701 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4056 4056 0 0.0
.debug_abbrev 1549734 1549986 252 0.0
.debug_aranges 134056 134056 0 0.0
.debug_frame 491000 490996 -4 -0.0
.debug_info 40190809 40198110 7301 0.0
.debug_line 5266055 5267110 1055 0.0
.debug_loc 3401794 3401860 66 0.0
.debug_ranges 371904 371928 24 0.0
.debug_str 3535090 3535090 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106704 106704 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 571662 571692 30 0.0
.symtab 173168 173184 16 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 952354 952352 -2 -0.0
bl702+rpc 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1277579 1277579 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 78749 78749 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1698172 1698382 210 0.0
.debug_aranges 142280 142280 0 0.0
.debug_frame 518704 518700 -4 -0.0
.debug_info 44587089 44594403 7314 0.0
.debug_line 5664380 5665435 1055 0.0
.debug_loc 3597945 3597998 53 0.0
.debug_ranges 395608 395632 24 0.0
.debug_str 3938399 3938399 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121232 121232 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 632259 632289 30 0.0
.symtab 191520 191536 16 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 1029342 1029342 0 0.0
k32w contact k32w0+release (read/write) 660908 660924 16 0.0
.bss 77360 77360 0 0.0
.data 2112 2112 0 0.0
.text 562324 562340 16 0.0
light k32w0+release (read/write) 672820 672868 48 0.0
.bss 75144 75144 0 0.0
.data 2064 2064 0 0.0
.text 592884 592932 48 0.0
lock k32w0+release (read/write) 632288 632320 32 0.0
.bss 75912 75912 0 0.0
.data 2084 2084 0 0.0
.text 551564 551596 32 0.0
linux chip-tool-ipv6only arm64 (read only) 10994156 10994316 160 0.0
(read/write) 697032 697032 0 0.0
.bss 34248 34248 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 640464 640464 0 0.0
.dynamic 560 560 0 0.0
.got 14112 14112 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 572428 572428 0 0.0
.text 8771380 8771540 160 0.0
thermostat-no-ble arm64 (read only) 2503556 2504420 864 0.0
(read/write) 144648 144648 0 0.0
.bss 56456 56456 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 76944 76944 0 0.0
.dynamic 560 560 0 0.0
.got 5392 5392 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150816 150800 -16 -0.0
.text 2090944 2091824 880 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2463192 2463256 64 0.0
.bss 215956 215956 0 0.0
.data 5880 5880 0 0.0
.text 1425836 1425900 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1164968 1165280 312 0.0
bss 147118 147246 128 0.1
rodata 133232 133352 120 0.1
text 804400 804460 60 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1366544 1366848 304 0.0
bss 106418 106546 128 0.1
rodata 210720 210832 112 0.1
text 763568 763624 56 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1110692 1111544 852 0.1
bss 146274 146402 128 0.1
rodata 110380 110496 116 0.1
text 773936 774532 596 0.1
qpg lighting-app qpg6105+debug (read/write) 1148304 1148344 40 0.0
.bss 100668 100668 0 0.0
.data 848 848 0 0.0
.text 595404 595444 40 0.0
lock-app qpg6105+debug (read/write) 1115992 1116032 40 0.0
.bss 97188 97188 0 0.0
.data 860 860 0 0.0
.text 563088 563128 40 0.0

@github-actions
Copy link

github-actions bot commented Jan 26, 2023 •
edited
Loading

PR #24649: Size comparison from 2ce5f2d to c560730

Increases above 0.2%:

platform target config section 2ce5f2d c560730 change % change
efr32 window-app BRD4187C .text 981708 983892 2184 0.2
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1749972 1755748 5776 0.3
.data 2664 2672 8 0.3
.debug_line 3766626 3778954 12328 0.3
.debug_loc 3651664 3673102 21438 0.6
.debug_ranges 357376 362248 4872 1.4
.strtab 575760 577246 1486 0.3
.text 1549184 1554824 5640 0.4
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1691372 1697628 6256 0.4
.debug_line 3774912 3787320 12408 0.3
.debug_loc 3635394 3656833 21439 0.6
.debug_ranges 355344 360216 4872 1.4
.strtab 536226 538662 2436 0.5
.symtab 408432 409728 1296 0.3
.text 1491392 1497520 6128 0.4
Increases (41 builds for bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 2ce5f2d c560730 change % change
bl702 lighting-app bl702 .debug_abbrev 1549734 1549986 252 0.0
.debug_info 40190809 40198111 7302 0.0
.debug_line 5266055 5267110 1055 0.0
.debug_loc 3401794 3401860 66 0.0
.debug_ranges 371904 371928 24 0.0
.strtab 571662 571692 30 0.0
.symtab 173168 173184 16 0.0
bl702+rpc .debug_abbrev 1698172 1698382 210 0.0
.debug_info 44587089 44594404 7315 0.0
.debug_line 5664380 5665435 1055 0.0
.debug_loc 3597945 3597998 53 0.0
.debug_ranges 395608 395632 24 0.0
.strtab 632259 632289 30 0.0
.symtab 191520 191536 16 0.0
.text 1029342 1029344 2 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677223 677295 72 0.0
(read/write) 174632 174688 56 0.0
.bss 81548 81676 128 0.2
.text 589440 589508 68 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640847 641367 520 0.1
(read/write) 158240 158368 128 0.1
.bss 80740 80868 128 0.2
.text 563100 563624 524 0.1
lock-ftd LP_CC2652R7 (read only) 674347 674379 32 0.0
.text 597600 597632 32 0.0
lock-mtd LP_CC2652R7 (read only) 660663 660711 48 0.0
.text 557448 557496 48 0.0
pump-app LP_CC2652R7 (read only) 687379 687427 48 0.0
.text 596504 596552 48 0.0
pump-controller-app LP_CC2652R7 (read only) 672811 672875 64 0.0
.text 585856 585920 64 0.0
shell LP_CC2652R7 (read only) 668494 668542 48 0.0
(read/write) 185432 185512 80 0.0
.bss 83620 83748 128 0.2
.text 583972 584024 52 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 585402 585442 40 0.0
.app_xip_area 461420 461460 40 0.0
lock cyw930739m2evb_01 (read/write) 589118 589174 56 0.0
.app_xip_area 459840 459896 56 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 550758 550814 56 0.0
.app_xip_area 432264 432320 56 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974096 974144 48 0.0
.text 824728 824776 48 0.0
BRD4161A+rs911x (read/write) 1037116 1037148 32 0.0
.text 853424 853456 32 0.0
BRD4187C (read/write) 1151248 1151280 32 0.0
.text 990456 990488 32 0.0
lock-app BRD4161A+wf200 (read/write) 1064740 1064772 32 0.0
.text 909520 909552 32 0.0
window-app BRD4187C (read/write) 1143940 1146224 2284 0.2
.bss 135068 135164 96 0.1
.data 2568 2572 4 0.2
.text 981708 983892 2184 0.2
esp32 all-clusters-app c3devkit (read only) 1041534 1042084 550 0.1
(read/write) 1515938 1516178 240 0.0
.dram0.bss 75904 76032 128 0.2
.flash.rodata 220024 220136 112 0.1
.flash.text 1041534 1042084 550 0.1
m5stack (read only) 1093751 1094271 520 0.0
(read/write) 497599 497823 224 0.0
.dram0.bss 80952 81080 128 0.2
.flash.rodata 248804 248900 96 0.0
.flash.text 1088367 1088887 520 0.0
k32w contact k32w0+release (read/write) 660908 660924 16 0.0
.text 562324 562340 16 0.0
light k32w0+release (read/write) 672820 672868 48 0.0
.text 592884 592932 48 0.0
lock k32w0+release (read/write) 632288 632320 32 0.0
.text 551564 551596 32 0.0
linux chip-tool-ipv6only arm64 (read only) 10994156 10994316 160 0.0
.text 8771380 8771540 160 0.0
thermostat-no-ble arm64 (read only) 2503556 2504420 864 0.0
.text 2090944 2091824 880 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2463192 2463256 64 0.0
.text 1425836 1425900 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1164968 1165280 312 0.0
bss 147118 147246 128 0.1
rodata 133232 133352 120 0.1
text 804400 804460 60 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1366544 1366848 304 0.0
bss 106418 106546 128 0.1
rodata 210720 210832 112 0.1
text 763568 763624 56 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1110692 1111544 852 0.1
bss 146274 146402 128 0.1
rodata 110380 110496 116 0.1
text 773936 774532 596 0.1
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1749972 1755748 5776 0.3
.bss 189736 189864 128 0.1
.data 2664 2672 8 0.3
.debug_abbrev 1251009 1251453 444 0.0
.debug_aranges 111256 111280 24 0.0
.debug_frame 373620 373636 16 0.0
.debug_info 27465099 27505885 40786 0.1
.debug_line 3766626 3778954 12328 0.3
.debug_loc 3651664 3673102 21438 0.6
.debug_ranges 357376 362248 4872 1.4
.debug_str 3484013 3485010 997 0.0
.strtab 575760 577246 1486 0.3
.symtab 423440 424288 848 0.2
.text 1549184 1554824 5640 0.4
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1691372 1697628 6256 0.4
.bss 188928 189056 128 0.1
.debug_abbrev 1236720 1237164 444 0.0
.debug_aranges 110520 110544 24 0.0
.debug_frame 376064 376080 16 0.0
.debug_info 27022864 27063637 40773 0.2
.debug_line 3774912 3787320 12408 0.3
.debug_loc 3635394 3656833 21439 0.6
.debug_ranges 355344 360216 4872 1.4
.debug_str 3469766 3470763 997 0.0
.strtab 536226 538662 2436 0.5
.symtab 408432 409728 1296 0.3
.text 1491392 1497520 6128 0.4
light cy8ckit_062s2_43012 (read/write) 1611148 1611180 32 0.0
.debug_abbrev 1071778 1072030 252 0.0
.debug_info 22483782 22491068 7286 0.0
.debug_line 3339092 3340132 1040 0.0
.debug_loc 3336402 3336501 99 0.0
.debug_ranges 319416 319440 24 0.0
.strtab 474042 474072 30 0.0
.symtab 377600 377632 32 0.0
.text 1419360 1419392 32 0.0
lock cy8ckit_062s2_43012 (read/write) 1645212 1645244 32 0.0
.debug_abbrev 1073126 1073378 252 0.0
.debug_info 22704397 22711727 7330 0.0
.debug_line 3340859 3341856 997 0.0
.debug_loc 3357990 3358029 39 0.0
.debug_ranges 321272 321296 24 0.0
.strtab 476977 477007 30 0.0
.symtab 379424 379456 32 0.0
.text 1448440 1448472 32 0.0
qpg lighting-app qpg6105+debug (read/write) 1148304 1148352 48 0.0
.text 595404 595452 48 0.0
lock-app qpg6105+debug (read/write) 1115992 1116040 48 0.0
.text 563088 563136 48 0.0
telink all-clusters-app tlsr9518adk80d (read/write) 1026616 1027492 876 0.1
bss 98552 98680 128 0.1
text 688798 689440 642 0.1
all-clusters-minimal-app tlsr9518adk80d (read/write) 964972 966464 1492 0.2
bss 97696 97824 128 0.1
text 652282 653538 1256 0.2
contact-sensor-app tlsr9518adk80d (read/write) 869244 869308 64 0.0
text 582574 582642 68 0.0
light-switch-app tlsr9518adk80d (read/write) 885700 885764 64 0.0
text 597176 597244 68 0.0
lighting-app tlsr9518adk80d (read/write) 964044 964116 72 0.0
text 663180 663246 66 0.0
ota-requestor-app tlsr9518adk80d (read/write) 899540 899604 64 0.0
text 608290 608356 66 0.0
thermostat tlsr9518adk80d (read/write) 888916 889052 136 0.0
text 597940 598080 140 0.0
Decreases (9 builds for bl702, cc13x2_26x2, linux, psoc6)
platform target config section 2ce5f2d c560730 change % change
bl702 lighting-app bl702 .debug_frame 491000 490996 -4 -0.0
bl702+rpc .debug_frame 518704 518700 -4 -0.0
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 174980 174948 -32 -0.0
lock-mtd LP_CC2652R7 (read/write) 183928 183880 -48 -0.0
pump-app LP_CC2652R7 (read/write) 162676 162628 -48 -0.0
pump-controller-app LP_CC2652R7 (read/write) 177356 177292 -64 -0.0
linux thermostat-no-ble arm64 .rodata 150816 150800 -16 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840944 840808 -136 -0.0
.heap 840944 840808 -136 -0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841752 841624 -128 -0.0
.heap 841752 841624 -128 -0.0
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 2ce5f2d c560730 change % change
bl602 lighting-app bl602 (read/write) 1345482 1345482 0 0.0
.bss 94858 94858 0 0.0
.data 9736 9736 0 0.0
.text 1022520 1022520 0 0.0
bl602+rpc (read/write) 1390930 1390930 0 0.0
.bss 102906 102906 0 0.0
.data 10128 10128 0 0.0
.text 1053454 1053454 0 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1184951 1184951 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 70701 70701 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4056 4056 0 0.0
.debug_abbrev 1549734 1549986 252 0.0
.debug_aranges 134056 134056 0 0.0
.debug_frame 491000 490996 -4 -0.0
.debug_info 40190809 40198111 7302 0.0
.debug_line 5266055 5267110 1055 0.0
.debug_loc 3401794 3401860 66 0.0
.debug_ranges 371904 371928 24 0.0
.debug_str 3535090 3535090 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106704 106704 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 571662 571692 30 0.0
.symtab 173168 173184 16 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
952354 952354 0 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1277579 1277579 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 78749 78749 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1698172 1698382 210 0.0
.debug_aranges 142280 142280 0 0.0
.debug_frame 518704 518700 -4 -0.0
.debug_info 44587089 44594404 7315 0.0
.debug_line 5664380 5665435 1055 0.0
.debug_loc 3597945 3597998 53 0.0
.debug_ranges 395608 395632 24 0.0
.debug_str 3938399 3938399 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121232 121232 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 632259 632289 30 0.0
.symtab 191520 191536 16 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1029342 1029344 2 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677223 677295 72 0.0
(read/write) 174632 174688 56 0.0
.bss 81548 81676 128 0.2
.data 3384 3384 0 0.0
.rodata 87471 87471 0 0.0
.text 589440 589508 68 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640847 641367 520 0.1
(read/write) 158240 158368 128 0.1
.bss 80740 80868 128 0.2
.data 3384 3384 0 0.0
.rodata 77423 77423 0 0.0
.text 563100 563624 524 0.1
lock-ftd LP_CC2652R7 (read only) 674347 674379 32 0.0
(read/write) 174980 174948 -32 -0.0
.bss 79108 79108 0 0.0
.data 3312 3312 0 0.0
.rodata 76267 76267 0 0.0
.text 597600 597632 32 0.0
lock-mtd LP_CC2652R7 (read only) 660663 660711 48 0.0
(read/write) 183928 183880 -48 -0.0
.bss 74372 74372 0 0.0
.data 3312 3312 0 0.0
.rodata 102735 102735 0 0.0
.text 557448 557496 48 0.0
pump-app LP_CC2652R7 (read only) 687379 687427 48 0.0
(read/write) 162676 162628 -48 -0.0
.bss 79068 79068 0 0.0
.data 3276 3276 0 0.0
.rodata 90395 90395 0 0.0
.text 596504 596552 48 0.0
pump-controller-app LP_CC2652R7 (read only) 672811 672875 64 0.0
(read/write) 177356 177292 -64 -0.0
.bss 79180 79180 0 0.0
.data 3300 3300 0 0.0
.rodata 86475 86475 0 0.0
.text 585856 585920 64 0.0
shell LP_CC2652R7 (read only) 668494 668542 48 0.0
(read/write) 185432 185512 80 0.0
.bss 83620 83748 128 0.2
.data 3380 3380 0 0.0
.rodata 84206 84206 0 0.0
.text 583972 584024 52 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 585402 585442 40 0.0
.app_xip_area 461420 461460 40 0.0
.bss 66432 66432 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589118 589174 56 0.0
.app_xip_area 459840 459896 56 0.0
.bss 71720 71720 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 550758 550814 56 0.0
.app_xip_area 432264 432320 56 0.0
.bss 60984 60984 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974096 974144 48 0.0
.bss 147152 147152 0 0.0
.data 2196 2196 0 0.0
.text 824728 824776 48 0.0
BRD4161A+rs911x (read/write) 1037116 1037148 32 0.0
.bss 181632 181632 0 0.0
.data 2040 2040 0 0.0
.text 853424 853456 32 0.0
BRD4187C (read/write) 1151248 1151280 32 0.0
.bss 133652 133652 0 0.0
.data 2544 2544 0 0.0
.text 990456 990488 32 0.0
lock-app BRD4161A+wf200 (read/write) 1064740 1064772 32 0.0
.bss 153152 153152 0 0.0
.data 2048 2048 0 0.0
.text 909520 909552 32 0.0
window-app BRD4187C (read/write) 1143940 1146224 2284 0.2
.bss 135068 135164 96 0.1
.data 2568 2572 4 0.2
.text 981708 983892 2184 0.2
esp32 all-clusters-app c3devkit (read only) 1041534 1042084 550 0.1
(read/write) 1515938 1516178 240 0.0
.dram0.bss 75904 76032 128 0.2
.dram0.data 13792 13792 0 0.0
.flash.rodata 220024 220136 112 0.1
.flash.text 1041534 1042084 550 0.1
.iram0.text 72896 72896 0 0.0
m5stack (read only) 1093751 1094271 520 0.0
(read/write) 497599 497823 224 0.0
.dram0.bss 80952 81080 128 0.2
.dram0.data 34072 34072 0 0.0
.flash.rodata 248804 248900 96 0.0
.flash.text 1088367 1088887 520 0.0
.iram0.text 124855 124855 0 0.0
k32w contact k32w0+release (read/write) 660908 660924 16 0.0
.bss 77360 77360 0 0.0
.data 2112 2112 0 0.0
.text 562324 562340 16 0.0
light k32w0+release (read/write) 672820 672868 48 0.0
.bss 75144 75144 0 0.0
.data 2064 2064 0 0.0
.text 592884 592932 48 0.0
lock k32w0+release (read/write) 632288 632320 32 0.0
.bss 75912 75912 0 0.0
.data 2084 2084 0 0.0
.text 551564 551596 32 0.0
linux chip-tool-ipv6only arm64 (read only) 10994156 10994316 160 0.0
(read/write) 697032 697032 0 0.0
.bss 34248 34248 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 640464 640464 0 0.0
.dynamic 560 560 0 0.0
.got 14112 14112 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 572428 572428 0 0.0
.text 8771380 8771540 160 0.0
thermostat-no-ble arm64 (read only) 2503556 2504420 864 0.0
(read/write) 144648 144648 0 0.0
.bss 56456 56456 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 76944 76944 0 0.0
.dynamic 560 560 0 0.0
.got 5392 5392 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150816 150800 -16 -0.0
.text 2090944 2091824 880 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2463192 2463256 64 0.0
.bss 215956 215956 0 0.0
.data 5880 5880 0 0.0
.text 1425836 1425900 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1164968 1165280 312 0.0
bss 147118 147246 128 0.1
rodata 133232 133352 120 0.1
text 804400 804460 60 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1366544 1366848 304 0.0
bss 106418 106546 128 0.1
rodata 210720 210832 112 0.1
text 763568 763624 56 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1110692 1111544 852 0.1
bss 146274 146402 128 0.1
rodata 110380 110496 116 0.1
text 773936 774532 596 0.1
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840944 840808 -136 -0.0
(read/write) 1749972 1755748 5776 0.3
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189736 189864 128 0.1
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2672 8 0.3
.debug_abbrev 1251009 1251453 444 0.0
.debug_aranges 111256 111280 24 0.0
.debug_frame 373620 373636 16 0.0
.debug_info 27465099 27505885 40786 0.1
.debug_line 3766626 3778954 12328 0.3
.debug_loc 3651664 3673102 21438 0.6
.debug_ranges 357376 362248 4872 1.4
.debug_str 3484013 3485010 997 0.0
.heap 840944 840808 -136 -0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 575760 577246 1486 0.3
.symtab 423440 424288 848 0.2
.text 1549184 1554824 5640 0.4
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841752 841624 -128 -0.0
(read/write) 1691372 1697628 6256 0.4
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188928 189056 128 0.1
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1236720 1237164 444 0.0
.debug_aranges 110520 110544 24 0.0
.debug_frame 376064 376080 16 0.0
.debug_info 27022864 27063637 40773 0.2
.debug_line 3774912 3787320 12408 0.3
.debug_loc 3635394 3656833 21439 0.6
.debug_ranges 355344 360216 4872 1.4
.debug_str 3469766 3470763 997 0.0
.heap 841752 841624 -128 -0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 536226 538662 2436 0.5
.symtab 408432 409728 1296 0.3
.text 1491392 1497520 6128 0.4
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849944 849944 0 0.0
(read/write) 1611148 1611180 32 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180936 180936 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1071778 1072030 252 0.0
.debug_aranges 102800 102800 0 0.0
.debug_frame 346624 346624 0 0.0
.debug_info 22483782 22491068 7286 0.0
.debug_line 3339092 3340132 1040 0.0
.debug_loc 3336402 3336501 99 0.0
.debug_ranges 319416 319440 24 0.0
.debug_str 3274787 3274787 0 0.0
.heap 849944 849944 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474042 474072 30 0.0
.symtab 377600 377632 32 0.0
.text 1419360 1419392 32 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 844960 844960 0 0.0
(read/write) 1645212 1645244 32 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185912 185912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1073126 1073378 252 0.0
.debug_aranges 103184 103184 0 0.0
.debug_frame 348424 348424 0 0.0
.debug_info 22704397 22711727 7330 0.0
.debug_line 3340859 3341856 997 0.0
.debug_loc 3357990 3358029 39 0.0
.debug_ranges 321272 321296 24 0.0
.debug_str 3291194 3291194 0 0.0
.heap 844960 844960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 476977 477007 30 0.0
.symtab 379424 379456 32 0.0
.text 1448440 1448472 32 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1148304 1148352 48 0.0
.bss 100668 100668 0 0.0
.data 848 848 0 0.0
.text 595404 595452 48 0.0
lock-app qpg6105+debug (read/write) 1115992 1116040 48 0.0
.bss 97188 97188 0 0.0
.data 860 860 0 0.0
.text 563088 563136 48 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1026616 1027492 876 0.1
bss 98552 98680 128 0.1
text 688798 689440 642 0.1
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 964972 966464 1492 0.2
bss 97696 97824 128 0.1
text 652282 653538 1256 0.2
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 869244 869308 64 0.0
bss 89844 89844 0 0.0
text 582574 582642 68 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 885700 885764 64 0.0
bss 89940 89940 0 0.0
text 597176 597244 68 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 964044 964116 72 0.0
bss 97996 97996 0 0.0
text 663180 663246 66 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 899540 899604 64 0.0
bss 90888 90888 0 0.0
text 608290 608356 66 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 888916 889052 136 0.0
bss 91328 91328 0 0.0
text 597940 598080 140 0.0

@bzbarsky-apple bzbarsky-apple merged commit 15a135f into project-chip:master Jan 27, 2023
@bzbarsky-apple bzbarsky-apple deleted the attribute-ids-src branch January 27, 2023 02:27
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple @jmeg-sfy
Stop using non-namespaced attribute ids in core SDK code. (project-ch…
ab81971 
…ip#24649)

* Stop using non-namespaced attribute ids in core SDK code.

* Also remove now-unused attribute-id.h includes in core code.

* Fix clang-tidy else-after-return complaint.

* Apply suggestions from code review

Co-authored-by: Jonathan Mégevand <77852424+jmeg-sfy@users.noreply.github.com>

* One more "target" addition.

* Fix restyle issue.

Co-authored-by: Jonathan Mégevand <77852424+jmeg-sfy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmeg-sfy jmeg-sfy jmeg-sfy approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@saurabhst saurabhst Awaiting requested review from saurabhst

@andy31415 andy31415 Awaiting requested review from andy31415

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app github review - approved workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @andy31415 @jmeg-sfy