-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SetupPayload to include if Discriminator is short #23304
Update SetupPayload to include if Discriminator is short #23304
Conversation
898ea1d
to
ff5f77e
Compare
d60ec3b
to
3b4aa0b
Compare
The device Discriminator is a 12-bit unsigned integer. For machine-readable formats, the full 12-bit Discriminator is used. For the Manual Pairing Code, only the upper 4 bits out of the 12-bit Discriminator are used. Also adding @deprecated tags to the pairDevice APIs in MTRDeviceController
3b4aa0b
to
be75525
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on the Darwin changes.
Head branch was pushed to by a user without write access
PR #23304: Size comparison from 236e14e to 4b8d160 Increases (4 builds for bl702, psoc6)
Decreases (6 builds for bl602, cc13x2_26x2, esp32, telink)
Full report (34 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, psoc6, qpg, telink)
|
PR #23304: Size comparison from 599ad3b to fcd58db Increases (7 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, telink)
Decreases (4 builds for cc13x2_26x2, cyw30739, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23304: Size comparison from 700ee0e to 6ff2f34 Increases (7 builds for esp32, psoc6, telink)
Decreases (3 builds for cyw30739, esp32)
Full report (47 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23304: Size comparison from 6221fe1 to 343e2e9 Increases (7 builds for bl602, bl702, esp32, nrfconnect, psoc6)
Decreases (4 builds for bl602, psoc6, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23304: Size comparison from bdfc185 to 8fc56e9 Increases (5 builds for cc13x2_26x2, cyw30739, esp32, psoc6)
Decreases (7 builds for cc13x2_26x2, k32w, psoc6, telink)
Full report (47 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23304: Size comparison from fe6c120 to f3643d8 Increases (1 build for cc13x2_26x2)
Decreases (4 builds for cc13x2_26x2, psoc6, telink)
Full report (47 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23304: Size comparison from 669cd47 to 32478aa Increases (11 builds for bl602, bl702, cc13x2_26x2, cyw30739, psoc6, telink)
Decreases (3 builds for cc13x2_26x2, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
The device Discriminator is a 12-bit unsigned integer. For machine-readable formats, the full 12-bit Discriminator is used. For the Manual Pairing Code, only the upper 4 bits out of the 12-bit Discriminator are used.