-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v1.0 cherrypick] Fix delivery of urgent events to actually work correctly. (#23240) #23271
Merged
andy31415
merged 1 commit into
project-chip:v1.0-branch
from
bzbarsky-apple:cherry-pick-293c470fa5c6418001a2b24d5078e6299797a176-for-1.0
Oct 22, 2022
Merged
[v1.0 cherrypick] Fix delivery of urgent events to actually work correctly. (#23240) #23271
andy31415
merged 1 commit into
project-chip:v1.0-branch
from
bzbarsky-apple:cherry-pick-293c470fa5c6418001a2b24d5078e6299797a176-for-1.0
Oct 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #23271: Size comparison from a0595f4 to c8bd393 Increases (6 builds for bl702, mbed, telink)
Decreases (2 builds for bl702)
Full report (6 builds for bl702, mbed, telink)
|
…ip#23240) * Fix delivery of urgent events to actually work correctly. If an urgent event was emitted at a point when the ReadHandler subscribing for it had already gotten its "min interval has elapsed" callback, we would just mark the read handler dirty but not schedule a run of the reporting engine. This would cause us to not report the event until something _did_ trigger such a run (either the max interval being reached, or some other reading/reporting activity). The fix is to make sure ReadHandler always schedules a run when IsReportable() becomes true. * Address review comments. * Make TestSubscribeUrgentWildcardEvent slightly less random-failure-prone.
c8bd393
to
dc613ef
Compare
PR #23271: Size comparison from 3c7d78f to dc613ef Increases (30 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (10 builds for bl702, cc13x2_26x2, psoc6)
Full report (36 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Oct 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an urgent event was emitted at a point when the ReadHandler subscribing for it had already gotten its "min interval has elapsed" callback, we would just mark the read handler dirty but not schedule a run of the reporting engine. This would cause us to not report the event until something did trigger such a run (either the max interval being reached, or some other reading/reporting activity).
The fix is to make sure ReadHandler always schedules a run when IsReportable() becomes true.
Address review comments.
Make TestSubscribeUrgentWildcardEvent slightly less random-failure-prone.
Fixes [v1.0-branch] Delivery of urgent events to subscriptions does not work correctly #23270