Skip to content

[v1.0-branch] Delivery of urgent events to subscriptions does not work correctly #23270

Closed
@bzbarsky-apple

Description

If an urgent event is emitted at a point when the ReadHandler subscribing for it had already gotten its "min interval has elapsed" callback (very likely if it uses a short min-interval and a long max-interval), we just mark the read handler dirty but do not schedule a run of the reporting engine. This causes us to not report the event until something does trigger such a run (either the max interval being reached, or some other reading/reporting activity).

This pretty much breaks subscribing to urgent events with a large max-interval.

Fixed on tip by #23240 but still an issue on 1.0 branch.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions