-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Fix ReadClient to use the right parameters when computing the liveness timeout #22699
Merged
andy31415
merged 2 commits into
project-chip:master
from
mrjerryjohns:fix-liveness-timeout
Sep 20, 2022
Merged
[BUG] Fix ReadClient to use the right parameters when computing the liveness timeout #22699
andy31415
merged 2 commits into
project-chip:master
from
mrjerryjohns:fix-liveness-timeout
Sep 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #22699: Size comparison from 0574c55 to 9d61f7a Increases (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (7 builds for cc13x2_26x2, esp32)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #22699: Size comparison from 6df6e98 to f2fb3c4 Increases (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (7 builds for cc13x2_26x2, esp32)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
54362b2
to
efafd38
Compare
PR #22699: Size comparison from 989ad8e to efafd38 Increases (28 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, psoc6, qpg, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (28 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, psoc6, qpg, telink)
|
efafd38
to
a31ff73
Compare
timeout This fixes the logic in ReadClient to use the local IDLE interval when computing the liveness timeout instead of the IDLE interval of our peer. Testing: Using the REPL and the liveness timer print, confirmed the fixes are indeed applied. Restyled by whitespace Restyled by clang-format Build fixes
a31ff73
to
5ea8571
Compare
PR #22699: Size comparison from 2466360 to 5ea8571 Increases (6 builds for bl702, linux, qpg)
Full report (6 builds for bl702, linux, qpg)
|
msandstedt
approved these changes
Sep 19, 2022
425a9dc
to
a6254f4
Compare
andy31415
approved these changes
Sep 19, 2022
tcarmelveilleux
approved these changes
Sep 19, 2022
yunhanw-google
approved these changes
Sep 19, 2022
PR #22699: Size comparison from 2466360 to a6254f4 Increases above 0.2%:
Increases (36 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (7 builds for cc13x2_26x2, esp32)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Will bypass Darwin flakyness on merging this. |
andy31415
pushed a commit
to andy31415/connectedhomeip
that referenced
this pull request
Sep 20, 2022
…iveness timeout (project-chip#22699) * Fix ReadClient to use the right parameters when computing the liveness timeout This fixes the logic in ReadClient to use the local IDLE interval when computing the liveness timeout instead of the IDLE interval of our peer. Testing: Using the REPL and the liveness timer print, confirmed the fixes are indeed applied. Restyled by whitespace Restyled by clang-format Build fixes * Review feedback
andy31415
added a commit
that referenced
this pull request
Sep 20, 2022
…iveness timeout (#22699) (#22760) * Fix ReadClient to use the right parameters when computing the liveness timeout This fixes the logic in ReadClient to use the local IDLE interval when computing the liveness timeout instead of the IDLE interval of our peer. Testing: Using the REPL and the liveness timer print, confirmed the fixes are indeed applied. Restyled by whitespace Restyled by clang-format Build fixes * Review feedback Co-authored-by: Jerry Johns <johnsj@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the logic in ReadClient to use the local IDLE interval when computing the liveness timeout instead of the IDLE interval of our peer.
Testing:
Using the REPL and the liveness timer print, confirmed the fixes are indeed applied.
Issue Being Resolved