[BUG] ReadClient uses incorrect parameters when calculating liveness timeout

[mrjerryjohns]

Reproduction steps

ReadClient today arms the liveness timer the following way:

timeout = System::Clock::Seconds16(mMaxInterval) + mReadPrepareParams.mSessionHolder->GetAckTimeout();

GetAckTimeout computes the timeout when sending a message to the peer (server). However, what we want is the ack timeout to us. Which means it should be using the IDLE interval of self to compute that.

Otherwise, this is going to result in extremely long liveness timeouts, which means that the client may end up being out of sync with a server if the subscription goes away for much longer than it should (causing re-subs to also take longer).

This will get particularly problematic with sleepy devices, since their idle intervals are even longer than the default.

Bug prevalence

always

GitHub hash of the SDK that was being used

master

Platform

core

Platform Version(s)

No response

Anything else?

No response