Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spec-compliance of Administrator Commissioning attributes. #21442

Merged
merged 2 commits into from
Jul 31, 2022
Merged

Fix spec-compliance of Administrator Commissioning attributes. #21442

merged 2 commits into from
Jul 31, 2022

Commits on Jul 31, 2022

  1. Fix spec-compliance of Administrator Commissioning attributes. 

    * Move management of the AdminVendorId and AdminFabricIndex to the
  commissioning window opener.
* Fix the types of the attributes in the XML to be nullable.
* Implement the spec provisions about returning null for the fabric
  index when the fabric gets removed.
* Implement the spec provisions about returning "window not open" when
  it was opened via non-cluster means (e.g. boot time.

Fixes project-chip#20882
    @bzbarsky-apple
    bzbarsky-apple committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    e6628f8 View commit details
    Browse the repository at this point in the history

  2. Address review comment

    @bzbarsky-apple
    bzbarsky-apple committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    8dc1953 View commit details
    Browse the repository at this point in the history