-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix spec-compliance of Administrator Commissioning attributes. #21442
Merged
woody-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:admin-commissioning-attrs
Jul 31, 2022
Merged
Fix spec-compliance of Administrator Commissioning attributes. #21442
woody-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:admin-commissioning-attrs
Jul 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
msandstedt,
rgoliver,
robszewczyk,
saurabhst and
selissia
July 29, 2022 21:16
woody-apple
approved these changes
Jul 29, 2022
PR #21442: Size comparison from 561eaea to 0cc47aa Increases above 0.2%:
Increases (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (9 builds for cc13x2_26x2, p6)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
tcarmelveilleux
approved these changes
Jul 30, 2022
bzbarsky-apple
force-pushed
the
admin-commissioning-attrs
branch
from
July 30, 2022 02:23
0cc47aa
to
67b40f4
Compare
PR #21442: Size comparison from 390e391 to 379f114 Increases above 0.2%:
Increases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (10 builds for cc13x2_26x2, linux, p6)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
* Move management of the AdminVendorId and AdminFabricIndex to the commissioning window opener. * Fix the types of the attributes in the XML to be nullable. * Implement the spec provisions about returning null for the fabric index when the fabric gets removed. * Implement the spec provisions about returning "window not open" when it was opened via non-cluster means (e.g. boot time. Fixes project-chip#20882
bzbarsky-apple
force-pushed
the
admin-commissioning-attrs
branch
from
July 31, 2022 04:30
379f114
to
8dc1953
Compare
PR #21442: Size comparison from deea799 to 8dc1953 Increases above 0.2%:
Increases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (10 builds for cc13x2_26x2, linux, p6)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
pushed a commit
that referenced
this pull request
Aug 1, 2022
* Move management of the AdminVendorId and AdminFabricIndex to the commissioning window opener. * Fix the types of the attributes in the XML to be nullable. * Implement the spec provisions about returning null for the fabric index when the fabric gets removed. * Implement the spec provisions about returning "window not open" when it was opened via non-cluster means (e.g. boot time. Fixes #20882
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…ct-chip#21442) * Move management of the AdminVendorId and AdminFabricIndex to the commissioning window opener. * Fix the types of the attributes in the XML to be nullable. * Implement the spec provisions about returning null for the fabric index when the fabric gets removed. * Implement the spec provisions about returning "window not open" when it was opened via non-cluster means (e.g. boot time. Fixes project-chip#20882
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commissioning window opener.
index when the fabric gets removed.
it was opened via non-cluster means (e.g. boot time.
Fixes #20882
Problem
See above.
Change overview
See above.
Testing
Added YAML and unit tests, plus manually tested that during initial PASE the attributes return the right values now.