Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UpdateNOC session invalidation and opcreds timing #20512

Merged

Commits on Jul 8, 2022

  1. Fix UpdateNOC session invalidation and opcreds timing (#20461)

    * Fix UpdateNOC session invalidation and opcreds timing
    
    - UpdateNOC did not clear session of previous fabric like spec intended
      (#20379)
    - All OpCreds cluster slow commands did not try to early-ack to avoid
      MRP timeouts (#19132)
    
    Fixes #20379
    Fixes #19132
    
    This PR:
    
    - Fixes UpdateNOC expiring all sessions for the updated node
    - Adds `FlushAcksRightAwayOnSlowCommand` to CommandHandler to flush acks
      on slow commands
    - Adds Python tests for UpdateNOC behavior of session expiring
    - Adds `ExpireSessions` to Python for testing
    
    Testing done:
    
    - Unit tests all pass
    - Cert tests pass
    - With the session clearing, previous Python tests failed, until
      I fixed them with the new `ExpireSessions` API
    - Observed standalone acks immediately sent on opcreds cluster commands
    
    * Restyled
    
    * Removed leftover debug
    tcarmelveilleux authored and web-flow committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    7f2a23a View commit details
    Browse the repository at this point in the history