Fix UpdateNOC session invalidation and opcreds timing #20461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- UpdateNOC did not clear session of previous fabric like spec intended (project-chip#20379) - All OpCreds cluster slow commands did not try to early-ack to avoid MRP timeouts (project-chip#19132) Fixes project-chip#20379 Fixes project-chip#19132 This PR: - Fixes UpdateNOC expiring all sessions for the updated node - Adds `FlushAcksRightAwayOnSlowCommand` to CommandHandler to flush acks on slow commands - Adds Python tests for UpdateNOC behavior of session expiring - Adds `ExpireSessions` to Python for testing Testing done: - Unit tests all pass - Cert tests pass - With the session clearing, previous Python tests failed, until I fixed them with the new `ExpireSessions` API - Observed standalone acks immediately sent on opcreds cluster commands
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple and
jelderton
pullapprove
bot
requested review from
woody-apple,
tehampson,
xylophone21,
vijs,
vivien-apple,
yunhanw-google and
wbschiller
|
PR #20461: Size comparison from 5810508 to 58a343c Increases above 0.2%:
Increases (29 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (5 builds for cc13x2_26x2)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Jul 7, 2022
mrjerryjohns
reviewed
Jul 7, 2022
|
PR #20461: Size comparison from 996f5f3 to 9f6b248 Increases above 0.2%:
Increases (29 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (5 builds for cc13x2_26x2)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
msandstedt
reviewed
Jul 8, 2022
src/app/clusters/operational-credentials-server/operational-credentials-server.cpp
Show resolved
Hide resolved
|
PR #20461: Size comparison from 996f5f3 to c893548 Increases above 0.2%:
Increases (29 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (6 builds for cc13x2_26x2, nrfconnect)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
msandstedt
approved these changes
Jul 8, 2022
woody-apple
approved these changes
Jul 8, 2022
mrjerryjohns
approved these changes
Jul 8, 2022
|
Do you think it's worthwhile adding methods to |
No, we should NOT do that, since there may be other constraints/reasons. The caller has the APIs they need to build. |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 8, 2022
* Fix UpdateNOC session invalidation and opcreds timing - UpdateNOC did not clear session of previous fabric like spec intended (#20379) - All OpCreds cluster slow commands did not try to early-ack to avoid MRP timeouts (#19132) Fixes #20379 Fixes #19132 This PR: - Fixes UpdateNOC expiring all sessions for the updated node - Adds `FlushAcksRightAwayOnSlowCommand` to CommandHandler to flush acks on slow commands - Adds Python tests for UpdateNOC behavior of session expiring - Adds `ExpireSessions` to Python for testing Testing done: - Unit tests all pass - Cert tests pass - With the session clearing, previous Python tests failed, until I fixed them with the new `ExpireSessions` API - Observed standalone acks immediately sent on opcreds cluster commands * Restyled * Removed leftover debug
andy31415
pushed a commit
that referenced
this pull request
Jul 9, 2022
* Fix UpdateNOC session invalidation and opcreds timing - UpdateNOC did not clear session of previous fabric like spec intended (#20379) - All OpCreds cluster slow commands did not try to early-ack to avoid MRP timeouts (#19132) Fixes #20379 Fixes #19132 This PR: - Fixes UpdateNOC expiring all sessions for the updated node - Adds `FlushAcksRightAwayOnSlowCommand` to CommandHandler to flush acks on slow commands - Adds Python tests for UpdateNOC behavior of session expiring - Adds `ExpireSessions` to Python for testing Testing done: - Unit tests all pass - Cert tests pass - With the session clearing, previous Python tests failed, until I fixed them with the new `ExpireSessions` API - Observed standalone acks immediately sent on opcreds cluster commands * Restyled * Removed leftover debug Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
(UpdateNOC needs to invalidate sessions on previous fabric #20379)
MRP timeouts (Some commands can take longer in sync execution time than the MRP timeout #19132)
Fixes #20379
Fixes #19132
Change overview
FlushAcksRightAwayOnSlowCommandto CommandHandler to flush ackson slow commands
ExpireSessionsto Python for testingTesting
I fixed them with the new
ExpireSessionsAPI