Allow chip-tool to generate onboarding payloads with extra TLV. #20231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specific changes: 1) Clarify the naming of some of the chip-tool payload arguments and add documentation. 2) Fix chip-tool handling of the existing-payload argument so that we error out on invalid existing payloads instead of silently pressing on. 3) Add a way to pass in the TLV-encoded extra bytes to be added to a payload. Unfortunately, only tags that our SetupPayload knows about right now are supported. 4) Add a function on QRCodeSetupPayloadGenerator that allows generating a code without having to guess at how much space the TLV will take up. 5) Add tests for that new function. Fixes project-chip#20226
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
msandstedt and
mspang
pullapprove
bot
requested review from
jelderton,
jepenven-silabs,
jmartinez-silabs and
jtung-apple
pullapprove
bot
requested review from
lazarkov,
LuDuda,
msandstedt,
mspang,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
|
PR #20231: Size comparison from cccd145 to b245151 Increases (6 builds for cc13x2_26x2, cyw30739, linux, telink)
Decreases (5 builds for cc13x2_26x2, cyw30739, esp32, nrfconnect)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Jul 2, 2022
|
Fast tracking tooling updates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specific changes:
documentation.
on invalid existing payloads instead of silently pressing on.
Unfortunately, only tags that our SetupPayload knows about right now are
supported.
without having to guess at how much space the TLV will take up.
Fixes #20226
Problem
See #20226
Change overview
See above.
Testing
Unit tests added for the new function on the QR code generator. Manually tested that I can pass in TLV and get a different QR code, parse that QR code and see the serial number inside, and pass in empty TLV to override an existing QR code that has TLV.